From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47244: 28.0.50; SIGSEGV in long-runnning Emacs Date: Tue, 30 Mar 2021 18:52:15 +0200 Message-ID: References: <87im5ofp3z.fsf@md5i.com> <14e14f28-7ece-cd98-5e49-d4583a0153a0@gmx.at> <16b279ef-a1c2-cd41-b18c-69383174c72a@gmx.at> <87a6qs7z60.fsf@md5i.com> <83eeg3kawg.fsf@gnu.org> <83y2e6kp9t.fsf@gnu.org> <83tuouknpb.fsf@gnu.org> <83sg4eknh5.fsf@gnu.org> <83r1jykmt0.fsf@gnu.org> <2d0dbdc8-3678-cd21-234a-9c63bb004629@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------25A3ED28B70497F85FA5826A" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "mwd@md5i.com" , "schwab@linux-m68k.org" , "47244@debbugs.gnu.org" <47244@debbugs.gnu.org> To: Michael Welsh Duggan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 30 18:53:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRHco-00066F-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 18:53:54 +0200 Original-Received: from localhost ([::1]:52172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRHcn-0006C0-Af for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Mar 2021 12:53:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRHc0-0005lJ-Ao for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 12:53:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRHby-0000eG-EP for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 12:53:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRHby-00077I-C7 for bug-gnu-emacs@gnu.org; Tue, 30 Mar 2021 12:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Mar 2021 16:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47244 X-GNU-PR-Package: emacs Original-Received: via spool by 47244-submit@debbugs.gnu.org id=B47244.161712315527311 (code B ref 47244); Tue, 30 Mar 2021 16:53:02 +0000 Original-Received: (at 47244) by debbugs.gnu.org; 30 Mar 2021 16:52:35 +0000 Original-Received: from localhost ([127.0.0.1]:52735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRHbW-00076R-Hr for submit@debbugs.gnu.org; Tue, 30 Mar 2021 12:52:34 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:58457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRHbS-000769-Pn for 47244@debbugs.gnu.org; Tue, 30 Mar 2021 12:52:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617123138; bh=TOUKRUPGV61YjkR0Q1cV0K81M9/9j2fIXdL4bWnLezY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=lOWQA29OC0Zs4xxGVOE61I4N5O1xmHvt+Y9Ogf9D60gyA0CBFT4h4pN3/kOC4w2mS tCrdubaAdOZ9+Y6BXVXUH5CjzvFe6AQjsy3j86QKoQIK3rkxJlSIFIYTWa0o3XBocJ 1w5mBjXRbUTLctuIYGbzC809MmYxdhigEsKbfKZw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.203]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1lbHVt2g9U-010tGo; Tue, 30 Mar 2021 18:52:17 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:aXgNoSlvXfhRVZLKyqgxJe4rLd3ltxGDgUupax0UWH9l8UIfIYi LKWyQ41B0vIa/Gd22m/eVga3rUiGXqD1+4dduuwgwHTakTMJi6tSrTJ/V+aTvcRiqsPdD5B zKlGYpwZkMqTqqRDIfouGwmr7ZFx3jqEWTpjR7Q+nZyZ661Gy/D4PjURajHg/cHt6wLnJN+ 8GXkuY/93jNYMFGRkR8bA== X-UI-Out-Filterresults: notjunk:1;V03:K0:EEt6ltRlMy0=:BsixYjMWo4iGuVnlhrpKJ/ UeO9VjrGV8BDVq8d9/5D0xNAxU/GtNvV+dRYV5DxjF0thi893m8jMqLe7w8CshniOcKdMF23F dgc1J/SXU3tXjtHQxs2cYfrBPau7HJWR4GjDubvW4wYtBiqH+pdhSZxJhx/JsB1MTHCX0uRX6 sKk45dpbkQbnK/kKpjFciFLEPTdEr7ICYoou9vGstnn5/fbhqg/JH541yjn7zlsumXFU7AH7s rlRDhocOV7m2ad0pTUbbi1o3RgvPLV60TAAFoA+ij6aQaNBOz7Zu02isUw3sfQCV3JNHT9MMr Eb9dmn+CxZWJBpKGWbltVyI07pFJR9BOZJbOK2Esff0pb6Bc3iHX8n2pS8tsx8DRQ1b6IEIwA hGq8+IESf32SqKJ1y/6ch/YG19jC4z7P0NrFrqYbmFBnVQ0Asmv/xZ4J9uPWvHPvQkvaEaAZf RTKUzDe0XwBkY5IzIvIP5bvFif71uuJXZxvAdIaLOClJJ3YSPQWcSgwHS/XWLyyNe3e3QVMeM LbG4y6FJIAeqooULSCzPXhazBPRPI3idyEGBxyk0CloKNyg8CXprYah1dlD4nqkoQSnZtJDN+ BWUsMJ/pNYM4xXE3Pj1bWDTpxQ09Jd2yNPZKgbva8WOPh4o+h65hJfti6zH1KP/rpmdUSEb8h JY/AUUaufEm4DbH4Po+1MvkibOMKsEMYmhzYTyeHCb8BVlmYYBSVeRiMHyYZT5m8M54FYfdaW tMhCLO+rr12qiG7RIf6h1xFZBgzu1PLDTYwH4GdnToZaCa3i4pr4nlYjCYag1p5H3TSRPseM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203321 Archived-At: This is a multi-part message in MIME format. --------------25A3ED28B70497F85FA5826A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit >> Are the buffer names the same as last time? > > Yes. It all sounds so easily reproducible and I have no idea where to start. Please bear with me and run with the attached from now on. Thanks, martin --------------25A3ED28B70497F85FA5826A Content-Type: text/x-patch; name="selected_window_contents.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="selected_window_contents.diff" diff --git a/src/buffer.c b/src/buffer.c index 8e33162989..9ad1e1d4d8 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1991,6 +1991,8 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0= , 1, "bKill buffer: ", =20 run_buffer_list_update_hook (b); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qt; } =0C @@ -2151,6 +2153,9 @@ set_buffer_internal_1 (register struct buffer *b) =20 BUFFER_CHECK_INDIRECTION (b); =20 + if (!BUFFER_LIVE_P (b)) + error ("Selecting deleted buffer"); + old_buf =3D current_buffer; current_buffer =3D b; last_known_column_point =3D -1; /* Invalidate indentation cache. */= diff --git a/src/window.c b/src/window.c index eb16e2a433..8cea0af8ab 100644 --- a/src/window.c +++ b/src/window.c @@ -307,7 +307,11 @@ wset_buffer (struct window *w, Lisp_Object val) if (BUFFERP (val)) /* Make sure that we do not assign the buffer to an internal window. */ - eassert (MARKERP (w->start) && MARKERP (w->pointm)); + { + eassert (BUFFER_LIVE_P (XBUFFER (val))); + eassert (MARKERP (w->start) && MARKERP (w->pointm)); + } + w->contents =3D val; adjust_window_count (w, 1); } @@ -315,6 +319,7 @@ wset_buffer (struct window *w, Lisp_Object val) static void wset_old_buffer (struct window *w, Lisp_Object val) { + eassert (BUFFER_LIVE_P (XBUFFER (val))); w->old_buffer =3D val; } =20 @@ -594,6 +599,8 @@ select_window_1 (Lisp_Object window, bool inhibit_poi= nt_swap) =20 selected_window =3D window; =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + /* Go to the point recorded in the window. This is important when the buffer is in more than one window. It also matters when @@ -3411,6 +3418,8 @@ DEFUN ("delete-other-windows-internal", Fdelete_oth= er_windows_internal, replace_buffer_in_windows (Lisp_Object buffer) { call1 (Qreplace_buffer_in_windows, buffer); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* If BUFFER is shown in a window, safely replace it with some other @@ -3960,6 +3969,8 @@ run_window_change_functions (void) /* Record changes for all frames (if asked for), selected window and frame. */ unbind_to (count, Qnil); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Make WINDOW display BUFFER. RUN_HOOKS_P means it's allowed @@ -4054,6 +4065,9 @@ set_window_buffer (Lisp_Object window, Lisp_Object = buffer, if (!samebuf && !MINI_WINDOW_P (w) && !WINDOW_PSEUDO_P (w)) FRAME_WINDOW_CHANGE (XFRAME (w->frame)) =3D true; =20 + if (WINDOWP (selected_window)) + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents= ))); + unbind_to (count, Qnil); } =20 @@ -5174,6 +5188,8 @@ DEFUN ("delete-window-internal", Fdelete_window_int= ernal, Sdelete_window_interna error ("Deletion failed"); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qnil; } =0C @@ -7233,6 +7249,9 @@ DEFUN ("set-window-configuration", Fset_window_conf= iguration, minibuf_selected_window =3D data->minibuf_selected_window; =20 SAFE_FREE (); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return FRAME_LIVE_P (f) ? Qt : Qnil; } =20 diff --git a/src/xdisp.c b/src/xdisp.c index cc0a689ba3..ea64e5037a 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12980,6 +12980,8 @@ restore_selected_window (Lisp_Object window) /* Abort if we cannot find a live frame. */ emacs_abort (); } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Restore WINDOW, if live, as its frame's selected window. */ @@ -12997,6 +12999,8 @@ restore_frame_selected_window (Lisp_Object window= ) if (EQ (frame, selected_frame)) selected_window =3D window; } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Update the tab-bar item list for frame F. This has to be done @@ -13074,6 +13078,8 @@ update_tab_bar (struct frame *f, bool save_match_= data) XSETFRAME (frame, f); selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); #endif =20 /* Build desired tab-bar items from keymaps. */ @@ -14010,6 +14016,8 @@ update_tool_bar (struct frame *f, bool save_match= _data) selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); + /* Build desired tool-bar items from keymaps. */ new_tool_bar =3D tool_bar_items (Fcopy_sequence (f->tool_bar_items), @@ -17246,6 +17254,8 @@ run_window_scroll_functions (Lisp_Object window, = struct text_pos startp) set_buffer_internal (XBUFFER (w->contents)); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return startp; } =20 @@ -25450,6 +25460,8 @@ display_mode_lines (struct window *w) =20 unbind_to (count, Qnil); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + if (n > 0) w->must_be_updated_p =3D true; return n; --------------25A3ED28B70497F85FA5826A--