From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Date: Thu, 31 Mar 2022 00:43:23 +1300 Message-ID: References: <3947f11808243544dcdd4e4d2fde4922@webmail.orcon.net.nz> <87v8vwap2l.fsf@gnus.org> <878rssaos4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Lars Ingebrigtsen , 54606@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 13:48:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZWoh-00021T-S5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 13:48:47 +0200 Original-Received: from localhost ([::1]:52996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZWof-0001QL-K0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 07:48:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZWk8-0008Ed-4r for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:44:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZWk5-0008Kg-Pp for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZWk5-0006qN-K2 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 07:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 11:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54606 X-GNU-PR-Package: emacs Original-Received: via spool by 54606-submit@debbugs.gnu.org id=B54606.164864061226265 (code B ref 54606); Wed, 30 Mar 2022 11:44:01 +0000 Original-Received: (at 54606) by debbugs.gnu.org; 30 Mar 2022 11:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:34699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZWjc-0006pZ-2u for submit@debbugs.gnu.org; Wed, 30 Mar 2022 07:43:32 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:48087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZWjZ-0006pP-U3 for 54606@debbugs.gnu.org; Wed, 30 Mar 2022 07:43:30 -0400 Original-Received: from [10.253.37.70] (port=34769 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1nZWjT-0007el-Sz; Thu, 31 Mar 2022 00:43:24 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Thu, 31 Mar 2022 00:43:23 +1300 In-Reply-To: <878rssaos4.fsf@gmx.de> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229099 Archived-At: On 2022-03-30 02:09, Michael Albinus wrote: > Lars Ingebrigtsen writes: >> Phil Sainty writes: >>> That call to (file-truename default-directory) for each dired >>> buffer can cause tramp to spin up for closed connections for >>> entirely irrelevant dired buffers. >> >> Hm. Would binding `non-essential' around that call fix the issue? > > That's my expectation. It's on my TODO to test, but I'm occupied yet. > Hope to fix this later this week. I've just tested with this, and it solves the immediate problem, but it's slow. In my test case it's taking ~2s to switch between images, whereas it takes only a fraction of a second when I'm ignoring remote dired buffers by adding (not (file-remote-p default-directory)) to the conditions. I have 15 remote dired buffers (about half of which are using multi- hops), which isn't a small number but also isn't big, so I think that `non-essential' seems inadequate here (unless this is significantly more efficient in newer versions). -Phil