unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 35498-done@debbugs.gnu.org
Subject: bug#35498: 26.2; doc string of `isearch-regexp-function'
Date: Fri, 3 May 2019 07:47:57 -0700 (PDT)	[thread overview]
Message-ID: <b2116392-224e-4df0-89b1-8b1bd95818fe@default> (raw)
In-Reply-To: <<831s1fopq8.fsf@gnu.org>>

> > The doc string should describe the possible values and their
> > meanings/behaviors.  Currently it describes only a function as value.
> 
> I added the existing functions that could be used as values.  Their
> descriptions are available by using the hyperlink, so no need to
> duplicate that here.  The list is, of course, not exhaustive, as Lisp
> programs could define their own functions.

It should instead, or in addition, specify what args it
must accept and what kind of value it must return.
Examples are only nice-to-have, not a replacement for a
description/spec.

> > Searching isearch.el it seems that this variable can be any of the
> > values possible for `search-default-mode'.  Please describe each of the
> > values for `isearch-regexp-function'.
> 
> See above: not needed.

The doc string should say that the value can be t, nil,
or a function. It should say what the behavior is for
each.  Or, as I suggested, it can just say that the
value can be anything acceptable for `search-default-mode'. 

> > Even when the value is a function the description could be better,
> > saying that it must accept a string as its first arg and must return a
> > string.  That can be surmised from saying that it converts a plain
> > search string to a regexp [search string], but it could be clearer.
> 
> Added.

OK, good.  That cancels what I said first, above.  I
thought you were saying that it is sufficient to just
give a list of existing such function values.





       reply	other threads:[~2019-05-03 14:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<95f9cdd4-4d43-458e-8354-dfc8972b14bf@default>
     [not found] ` <<831s1fopq8.fsf@gnu.org>
2019-05-03 14:47   ` Drew Adams [this message]
2019-05-03 15:06     ` bug#35498: 26.2; doc string of `isearch-regexp-function' Eli Zaretskii
2019-04-30  1:48 Drew Adams
2019-05-03  9:24 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2116392-224e-4df0-89b1-8b1bd95818fe@default \
    --to=drew.adams@oracle.com \
    --cc=35498-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).