* bug#27797: 25.2; text-quoting-style interferes with tree-widget
@ 2017-07-23 8:18 Leo Liu
2017-07-24 17:08 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Leo Liu @ 2017-07-23 8:18 UTC (permalink / raw)
To: 27797
tree widget in the terminal uses ` in the lower-left corner of a
rectangle, for example
|
|
`--
This is now shown ugly in emacs 25+:
|
|
‘--
Here is a real example:
[-]Small, fast, modern
‘-[-]<101.316.0>
‘-[-]<101.317.0>
‘-[-]x_sup
‘-x_clock
I think this change makes tree-widget look horrible.
Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27797: 25.2; text-quoting-style interferes with tree-widget
2017-07-23 8:18 bug#27797: 25.2; text-quoting-style interferes with tree-widget Leo Liu
@ 2017-07-24 17:08 ` Glenn Morris
2017-07-24 17:28 ` Drew Adams
2017-07-26 3:55 ` Leo Liu
0 siblings, 2 replies; 4+ messages in thread
From: Glenn Morris @ 2017-07-24 17:08 UTC (permalink / raw)
To: Leo Liu; +Cc: 27797
Your horror prevented you giving a reproducible test-case from emacs -Q,
but I guess this should fix it:
--- a/lisp/tree-widget.el
+++ b/lisp/tree-widget.el
@@ -504,7 +504,7 @@ 'tree-widget-guide
(define-widget 'tree-widget-end-guide 'item
"End of a vertical guide line."
- :tag " `"
+ :tag " \\=`"
;;:tag-glyph (tree-widget-find-image "end-guide")
:format "%t"
)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27797: 25.2; text-quoting-style interferes with tree-widget
2017-07-24 17:08 ` Glenn Morris
@ 2017-07-24 17:28 ` Drew Adams
2017-07-26 3:55 ` Leo Liu
1 sibling, 0 replies; 4+ messages in thread
From: Drew Adams @ 2017-07-24 17:28 UTC (permalink / raw)
To: Glenn Morris, Leo Liu; +Cc: 27797
> Your horror prevented you giving a reproducible test-case from emacs -Q,
> but I guess this should fix it:
>
> (define-widget 'tree-widget-end-guide 'item
> "End of a vertical guide line."
> - :tag " `"
> + :tag " \\=`"
Seriously? We now have to escape ` in :tag too, if we don't
want transformation to crazy quotes?
If so, shouldn't this be documented in the Elisp manual?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27797: 25.2; text-quoting-style interferes with tree-widget
2017-07-24 17:08 ` Glenn Morris
2017-07-24 17:28 ` Drew Adams
@ 2017-07-26 3:55 ` Leo Liu
1 sibling, 0 replies; 4+ messages in thread
From: Leo Liu @ 2017-07-26 3:55 UTC (permalink / raw)
To: Glenn Morris; +Cc: 27797
On 2017-07-24 13:08 -0400, Glenn Morris wrote:
> Your horror prevented you giving a reproducible test-case from emacs -Q,
> but I guess this should fix it:
That looks like the correct fix.
Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-26 3:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-23 8:18 bug#27797: 25.2; text-quoting-style interferes with tree-widget Leo Liu
2017-07-24 17:08 ` Glenn Morris
2017-07-24 17:28 ` Drew Adams
2017-07-26 3:55 ` Leo Liu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).