From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66020: (bug#64735 spin-off): regarding the default for read-process-output-max Date: Sun, 26 May 2024 18:20:15 +0300 Message-ID: References: <8334zmtwwi.fsf@gnu.org> <83tts0rkh5.fsf@gnu.org> <831qf3pd1y.fsf@gnu.org> <28a7916e-92d5-77ab-a61e-f85b59ac76b1@gutov.dev> <83sf7jnq0m.fsf@gnu.org> <5c493f86-0af5-256f-41a7-7d886ab4c5e4@gutov.dev> <83ledanvzw.fsf@gnu.org> <83r0n2m7qz.fsf@gnu.org> <26afa109-9ba3-78a3-0e68-7585ae8e3a19@gutov.dev> <83il8dna30.fsf@gnu.org> <83bke5mhvs.fsf@gnu.org> <83a5tmk79p.fsf@gnu.org> <937d9927-506f-aa36-94e9-3cceb8f629dd@gutov.dev> <83zg1hay6q.fsf@gnu.org> <451d6012-e5ab-df6c-50e3-dac20b91781c@gutov.dev> <83led09dlk.fsf@gnu.org> <1d43341a-2e7c-9f1d-68e9-9bac6f4b5fba@gutov.dev> <838r8w3zr2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33523"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: stefankangas@gmail.com, 66020@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 26 17:21:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBFgX-0008TG-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 May 2024 17:21:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBFgC-0005Zh-0K; Sun, 26 May 2024 11:21:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBFg8-0005Wa-LE for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 11:20:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBFg6-0001hB-5n for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 11:20:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBFgE-0005qL-9B for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66020 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66020-submit@debbugs.gnu.org id=B66020.171673683822420 (code B ref 66020); Sun, 26 May 2024 15:21:02 +0000 Original-Received: (at 66020) by debbugs.gnu.org; 26 May 2024 15:20:38 +0000 Original-Received: from localhost ([127.0.0.1]:42271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBFfp-0005pY-Py for submit@debbugs.gnu.org; Sun, 26 May 2024 11:20:38 -0400 Original-Received: from wfhigh3-smtp.messagingengine.com ([64.147.123.154]:37007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBFfn-0005pJ-LP for 66020@debbugs.gnu.org; Sun, 26 May 2024 11:20:36 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id A46D518000E5; Sun, 26 May 2024 11:20:20 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 26 May 2024 11:20:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1716736820; x=1716823220; bh=a1KxVJm+Di2yhsxzUwmKb5u1t9iX+azdhR5336hW++o=; b= X2flwrCEKdWTcV6ENfr3EmKiBsSOuzfvBKoPEv6zeSSwoH1K1wRI9YLWQUwTunVv TK5SrZPGMNUOgWQRMgenGcB4OCqMxlXX0EEz+9okbO2VEudr4zg5xq9PZBuaHTpA MlUP6Lu+eooAaM2An758aqmiuh5aMG+wjmMyPMG44Dm1oM4y11dFSHGU6UvrmLY0 0I8dMK752gFCfsUfcQ2sOKRABJw/XMnjz1xgKGvwL5luTqUjp9a7/yz7F3DZ0dRw Qcic23Icp9LApZjgvXeOOpTULH6Xce5TL6W5zRg6vlUeVR8jzHqgnPxBrpdA+3Vn LHSlctuN0u0QagOtBnv8cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716736820; x= 1716823220; bh=a1KxVJm+Di2yhsxzUwmKb5u1t9iX+azdhR5336hW++o=; b=c gCqgpl+DVL6fZwxTSDZdRQdixDuYHb8WBUFV/olmmBxc9N0Jwe0VAZ8Jb/X67bjV OjwaSpd9K4opMg3NIyKkKzqoxJVDqMFoHFMnquoSKj6cvQjyxdpeJvak71i0LrzQ Zc9yhovVUtYww2OZ+dGeTn4DTJo/OvACNp32mO1TrrzS2LdoH1S8flzPJPHrMmEM SJzkQWXEkIkJNIw4LdtIgdrDj1KRvtYvLgf9wkgID4NO9BU2PIXN32DzHCXq5yBF aymsa09WjT4tgKk6s1SwK7h6R+mEx072Ylh+SvOcgS6edjSCYKCWUS0eBIqZnQan VCU3lMQRaEo1DgOBdHOKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejvddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 May 2024 11:20:18 -0400 (EDT) Content-Language: en-US In-Reply-To: <838r8w3zr2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285970 Archived-At: Hi Paul and Eli, On 24/09/2023 08:29, Eli Zaretskii wrote: >> What do people think? > I think we should increase the default size, and the rest (querying > the system about the pipe size) looks like an unnecessary complication > to me. > > I've added Paul Eggert to this discussion, as I'd like to hear his > opinions about this stuff. Do you think we can get this in before the emacs-30 branch is cut? To summarize: * Patch 1 (reduces consing when the default filter is used by moving it into C - skipping the creation of Lisp strings). * Patch 2 a) It ensures that the dynamic binding of read-process-output-max is saved when the process it created and used for its processing - ensuring that the current dynamic value is not just used when creating the pipe, but also later when reading from it. b) A few lines are outdated: part of the fix went in with bug#66288. * Patch 3 can be replaced with just upping the default value of read-process-output-max to 65536.