From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 14 Feb 2020 01:23:50 +0200 Message-ID: References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120326"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39452@debbugs.gnu.org To: Wolfgang Scherer , Noam Postavsky , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 00:25:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2Nr5-000VAW-Mz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 00:25:11 +0100 Original-Received: from localhost ([::1]:60902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Nr4-0003yW-FA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Feb 2020 18:25:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49864) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Nqx-0003y4-1m for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 18:25:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2Nqw-0001vt-4W for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 18:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2Nqv-0001vY-Un for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 18:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2Nqv-0002HL-QH for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 18:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Feb 2020 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.15816362428687 (code B ref 39452); Thu, 13 Feb 2020 23:25:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 13 Feb 2020 23:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:60639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2Npy-0002G3-1R for submit@debbugs.gnu.org; Thu, 13 Feb 2020 18:24:02 -0500 Original-Received: from mail-wm1-f67.google.com ([209.85.128.67]:37467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2Npv-0002FZ-V0 for 39452@debbugs.gnu.org; Thu, 13 Feb 2020 18:24:00 -0500 Original-Received: by mail-wm1-f67.google.com with SMTP id a6so8698053wme.2 for <39452@debbugs.gnu.org>; Thu, 13 Feb 2020 15:23:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=at+oB8MiIGYdXvrSqd7TUftXXDYE0x/ej6ieUzFcank=; b=Qkurzrqb4g4E0Wm6LOTMgOEDAXc2ax35AvxPm15eXuwmpzCNTlmaXXTVsV2f1UZ6Gp EU2s6k+AbNxkOC3HltwuoYLj5HtF5+PvTpHCzyuA2s1Z5FofORiqdXvv2UgwV54E0md3 Qb0gclZV/J1SLIOi6HPICnhg2UOH0G03xPP46gdtag9kyA+8qT6LlzFFpMzWOv0XuxjY NN7RlQWZT+sj3yRo+/YdtXsnXdkTFkLq3sVXgKpXsnxoyNURJpuP2dAVqgNEOXAkVM/T bYZ6VrgBGxaD3tnaqHeWy9USwS/Xzk4oyyvzizxVOw0ZtLPQWC+GDfOSOOl9GA8SyIuZ kmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=at+oB8MiIGYdXvrSqd7TUftXXDYE0x/ej6ieUzFcank=; b=s/ozRI1VYHoDANNKS9Yrd5DUBUg4m/2JLKytTXtsBwA9zDK2zC1bFQA5tnj+3yVJH9 3rUc+VHAwfuEZXCwJtLU8gi3xjJVfrSdZUkPwirhbN+J2Djv3wFear+xYoV3j967ZbMj qcBV1Lcuqd0+eOlLHkeDoyI8jUTmg8SS/krCcDhYYE2Q8aT+dVNdPKFDbPIxO7qSp9gt nPUayCCbKXuQOAE3McmLi4GsLLNKomd9FC7WR1XIrqCoMvuCaZsGwpaFrmwnxue5DK0i jAYj4ENUn1xibRq87DsFOGCMl09Q35/SOSXYpoR0ptXH1Ul7+eIRPMgHIA91qjdrnyN2 yrIQ== X-Gm-Message-State: APjAAAX7V/lIS79bGKsvAQ0mDsMq+Az0RHyvwUDoZfvYRmn1g5eNpe7Y FfyHvYK6qGVXTgMfDxM0c5Vt1fqV X-Google-Smtp-Source: APXvYqyzJu9ZAas+9iC9YU6FagIBfP2nBMPT9NCD69xESW+hspDJX9I1Z3361E08g+2rBBjz2dbGyQ== X-Received: by 2002:a7b:cc6a:: with SMTP id n10mr422044wmj.170.1581636233104; Thu, 13 Feb 2020 15:23:53 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o15sm4804439wra.83.2020.02.13.15.23.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Feb 2020 15:23:52 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176021 Archived-At: On 13.02.2020 20:34, Wolfgang Scherer wrote: >> And if Magit does it, it's probably okay for most of VC users too. > > It might be worth documenting in the manual, since the problem comes up quite a lot in issues and Stackoverflow. You mean the problem inside git hooks, if such solution is applied? Weird how I never seen it mentioned before. Anyway, at this point I'd rather hear more opinion. Eli, what do you think is better, applying a more verbose fix (which prepends stuff to every file name) and spending some of our complexity budged on that. Or using the simple fix and documenting the git hooks erratum in the manual (or somewhere else). I'm inclining toward the latter, esp. considering that the problem should be familiar to Magit users already, and thus the fix is prominently documented on the Internet.