unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: Denis Zubarev <dvzubarev@yandex.ru>, 67977@debbugs.gnu.org
Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer
Date: Thu, 28 Dec 2023 13:44:43 +0200	[thread overview]
Message-ID: <b11799ff-11a6-48bb-b9e4-ec5d69fa23c2@gutov.dev> (raw)
In-Reply-To: <FFBB4602-AEE6-49BB-979E-9205B86F0C45@gmail.com>

On 28/12/2023 10:07, Yuan Fu wrote:
> 
>> On Dec 27, 2023, at 4:57 AM, Eli Zaretskii<eliz@gnu.org>  wrote:
>>
>>> From: Yuan Fu<casouri@gmail.com>
>>> Date: Tue, 26 Dec 2023 20:15:24 -0800
>>> Cc: Denis Zubarev<dvzubarev@yandex.ru>,
>>> 67977@debbugs.gnu.org
>>>
>>>> Btw, I hope that these calls to 'widen' don't require unnecessary
>>>> reparsing by tree-sitter, do they?
>>> Yes, but only because we called treesit-node-at while the buffer is narrowed, which triggers a reparse. Font-lock and jit-lock themselves always access the parser with widened buffer so they don’t trigger reparse on their own.
>>>
>>> So it seems working in a narrowed buffer would trigger a lot of back-and-fortch reparse. I wonder if it’s worth optimizing for (eg, use two parsers behind the scenes, one for widened buffer and one for narrowed buffer).
>> Could font-lock-dont-widen help, perhaps?
> Yes. If font-lock doesn’t widen, then there wouldn’t be back-and-forth reparses.

But then treesit major modes will be affected by user narrowing (e.g. if 
the user narrowed to inside the string, the buffer won't be highlighted 
as a string).





  reply	other threads:[~2023-12-28 11:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 23:18 bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Denis Zubarev
2023-12-23  7:26 ` Eli Zaretskii
2023-12-23  8:08   ` Yuan Fu
2023-12-24  3:00     ` Yuan Fu
2023-12-24  7:11       ` Eli Zaretskii
2023-12-27  4:15         ` Yuan Fu
2023-12-27 12:57           ` Eli Zaretskii
2023-12-28  8:07             ` Yuan Fu
2023-12-28 11:44               ` Dmitry Gutov [this message]
2023-12-28 13:53                 ` Eli Zaretskii
2023-12-28 16:16                   ` Dmitry Gutov
2023-12-29  7:00                     ` Yuan Fu
2023-12-29 12:48                       ` Dmitry Gutov
2023-12-30  4:35                         ` Yuan Fu
2023-12-30 16:21       ` Denis Zubarev
2023-12-30 20:23         ` Yuan Fu
2023-12-31  0:08           ` Dmitry Gutov
2023-12-31 10:39           ` Denis Zubarev
2023-12-31 12:56             ` Eli Zaretskii
2023-12-31 13:40             ` Dmitry Gutov
2024-01-02  4:46               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 13:34                 ` Dmitry Gutov
2024-01-02 22:58                   ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b11799ff-11a6-48bb-b9e4-ec5d69fa23c2@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=67977@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dvzubarev@yandex.ru \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).