From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Mon, 18 Nov 2024 03:42:34 +0200 Message-ID: References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15324"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 02:43:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCqnO-0003pb-PX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 02:43:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCqnC-0005oI-6M; Sun, 17 Nov 2024 20:43:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCqnA-0005oA-0H for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 20:43:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCqn9-0003FA-4X for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 20:43:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=13FeU88+AptSwqvQeQrrBpA6zf7vAl3q3TORcMA1GzQ=; b=K8wURcZsbSYhmOb0lRHOMtjaNQmeSDlNc3wKdRAVtMdvC3WSWM40hLCi+R+YkOIFrmkLdrfMts0SJnejhIlBA5r0xEIvi+Qg/PpltBhKEHl6+dKGd5yUQztNi/cmBjxqVeEwoErI4As140iI/3Ps6mxN37iwvd4bfaOpWbcZKYUZp9WkviHN8K0ilU6S7AjC5ZkpxmZpW5O2doBOARVpM7Dxk4WuPqIJsyactHkzpxMo779JLjJOr2NMH2zze7KYR0bQkjo4mHLYI6q7ZuNVm4zk0+ywUVMgy9pPWvbj1TZPR49ThIwGkiRj0utJj0ysdU+y4ggN3BIskEsgG5UOMQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCqn8-0002qR-Rv for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 20:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173189416510898 (code B ref 74361); Mon, 18 Nov 2024 01:43:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 18 Nov 2024 01:42:45 +0000 Original-Received: from localhost ([127.0.0.1]:59264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCqmr-0002pi-G5 for submit@debbugs.gnu.org; Sun, 17 Nov 2024 20:42:45 -0500 Original-Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]:37211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCqmp-0002pO-6J for 74361@debbugs.gnu.org; Sun, 17 Nov 2024 20:42:43 -0500 Original-Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 1864713801EF; Sun, 17 Nov 2024 20:42:38 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sun, 17 Nov 2024 20:42:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1731894158; x=1731980558; bh=13FeU88+AptSwqvQeQrrBpA6zf7vAl3q3TORcMA1GzQ=; b= pVKr6R0IvjwLMjyIf3SaOp5f46ks1GqjvQfJc0o8ARkeQHDTTKT/XCIohCmKNxHW AjpXwgNwuyZQe1+pyGY6Z6MuN5fo9xACq/c1h4p54kCpD1Ese+oBeJC+IDn9eF6k P+OHtSU91VSsC/kBF9bHH1Eo53YuNlw5/qkLDLM5EACSxYbcjG43wLKarI1Wy46e yvkFlH7x6+xJU+b08b5r6pUAEf0HLfIypkyhV8OKXcqT5FrjZzlQL7ytFWsDaI1V oS9oBF3gUflTepIv7PGMTTAm1DB0gB9tet86jjL2/b22N3dS5fa6wuOYpjXJaChO sZ6iad88ZUeaj4IrGeXydg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731894158; x= 1731980558; bh=13FeU88+AptSwqvQeQrrBpA6zf7vAl3q3TORcMA1GzQ=; b=e mHE1xDb0d17pXGhqWVpDti3qZIfb7JKuVVpoaSQyMseUvH40Oi1payl6Zd+LojJO dmfu2lJYuunxvcm0JPVJjOcJM+Ho1DV2OXQiHIM6jgTNUU5uGJpLf8v1HLvEkk/G BrcsYEdnDLKZ6jJdSViAQR+bSIjWhJQsOu/4AXBd2QTZOdbU83wgO7WO+4Qp7oyg OkwlWSdgJg5mSJW327RxIg0gMWpdK3evxoJQp/JRttXDwUcMio+AcXNh1KIiI/tN Y2ob5A9OyVhzgwvBfupejP+iyxaXN7DF9ckDKSs1sJNDYPn/XfDNYtJchz2Ypv0R YkI0kScMJeLbOn86BvX/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdelgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpd hrtghpthhtoheprhhuuggrlhhitghssehgmhigrdgrthdprhgtphhtthhopeejgeefiedu seguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjhhurhhisehlihhnkhhovh drnhgvth X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Nov 2024 20:42:36 -0500 (EST) Content-Language: en-US In-Reply-To: <8634jrin5v.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295575 Archived-At: On 16/11/2024 10:43, Eli Zaretskii wrote: >> That's the term I would use both both, but maybe there could be better >> wording. If xref-find-definition is not a navigation command, is it a >> "search command"? > Let me turn the table and ask: which Xref commands will NOT use this > action, if we exclude commands like > xref-find-definitions-other-window, which specify the window/frame to > use? xref-query-replace-in-results will not (or its twin xref-find-references-and-replace). I suppose not many people would expect them to. Also, there is a nuance: when the Xref buffer itself is shown (i.e. when there are multiple locations matching a xref-find-definitions search), we're not going to pass (category . xref) to display-buffer either - it is reserved for displaying the buffers of destination locations.