From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#51475: read-char-choice should hide the cursor Date: Fri, 29 Oct 2021 18:54:14 +0000 Message-ID: References: <_THq5ypB0YkWSi2rpEAmoEqTA-YZ6yyHoz8z8_DjpB-ER134WTz00UDJ4_-Z-9y_AskMwozCw0Ji-E855Ip9g5rUxaAMcdQXzp2xGAKl_0o=@protonmail.com> <87o878yo8c.fsf@gnus.org> <8735ojvfap.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ndame , 51475@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 21:07:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgXDU-0000Mx-V2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 21:07:05 +0200 Original-Received: from localhost ([::1]:38540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgXDT-0005mt-Us for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 15:07:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgX1q-0002e2-DV for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgX1q-0008BE-4P for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgX1q-0007du-1f for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51475 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51475-submit@debbugs.gnu.org id=B51475.163553365829309 (code B ref 51475); Fri, 29 Oct 2021 18:55:02 +0000 Original-Received: (at 51475) by debbugs.gnu.org; 29 Oct 2021 18:54:18 +0000 Original-Received: from localhost ([127.0.0.1]:55901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgX18-0007cf-24 for submit@debbugs.gnu.org; Fri, 29 Oct 2021 14:54:18 -0400 Original-Received: from heytings.org ([95.142.160.155]:41008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgX16-0007cQ-71 for 51475@debbugs.gnu.org; Fri, 29 Oct 2021 14:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1635533654; bh=K2vPCV8P6P/E9Gf1U5WsgtpVdMEutMBVHECBwafFi+M=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=t/IFlNIlacF7b+p8fNygktvRJ8OyiGR5nuIT6/TxwH+Rq6a8IwlB26apsg8yzlzIm XD3p/J3BbmjuKXPqytyTD8HpLoBfzNkxn1qPAwXgUovCPI77pjwxQWSg3YuDV2Iaby k2nImM9Nx7PgWR9o5H+lGUkpx77nBokQoRG6vefp86g96r4bBztH0GgxfV+CZgHPUd QXnvabEDrew9bFQCXsHP5sqK8Tr0ebqf9k4q4bUQfdOtKua5RUEz4lZEsU37rB+ON9 VnWcdsslNTWOowQJ4Rm+MlXBzr1bFWZtTokUniGom363NS/w8AUes1hOFzfQD8iCYl eFm5Ul4ez057Q== In-Reply-To: <8735ojvfap.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218588 Archived-At: >> Or we could make it depend on a dynamic variable. See attached patch. > > I'd rather have an optional variable if this is something that should be > controlled. > You mean, an optional argument? If so, unless you also add an additional optional argument to read-char-from-minibuffer, you'll need a dynamic variable anyway. > > But I'm not sure we want to. The original example was: > > (read-char-choice " a - good\n b - bad\n c - ugly" '(?a ?b ?c)) > > But that's an ugly prompt in itself. If it's amended to > > (read-char-choice " a - good\n b - bad\n c - ugly: " '(?a ?b ?c)) > > then it's fine showing the cursor. (And that's a prompt should look.) > I'm not sure either. I'm also not sure the OP would agree that your amended version is fine.