From: Gregory Heytings <gregory@heytings.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: ndame <laszlomail@protonmail.com>, 51475@debbugs.gnu.org
Subject: bug#51475: read-char-choice should hide the cursor
Date: Fri, 29 Oct 2021 18:54:14 +0000 [thread overview]
Message-ID: <b0a09f3248a66c7f098a@heytings.org> (raw)
In-Reply-To: <8735ojvfap.fsf@gnus.org>
>> Or we could make it depend on a dynamic variable. See attached patch.
>
> I'd rather have an optional variable if this is something that should be
> controlled.
>
You mean, an optional argument? If so, unless you also add an additional
optional argument to read-char-from-minibuffer, you'll need a dynamic
variable anyway.
>
> But I'm not sure we want to. The original example was:
>
> (read-char-choice " a - good\n b - bad\n c - ugly" '(?a ?b ?c))
>
> But that's an ugly prompt in itself. If it's amended to
>
> (read-char-choice " a - good\n b - bad\n c - ugly: " '(?a ?b ?c))
>
> then it's fine showing the cursor. (And that's a prompt should look.)
>
I'm not sure either. I'm also not sure the OP would agree that your
amended version is fine.
next prev parent reply other threads:[~2021-10-29 18:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 5:24 bug#51475: read-char-choice should hide the cursor ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-29 13:06 ` Lars Ingebrigtsen
2021-10-29 14:53 ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-29 17:13 ` Stefan Kangas
2021-10-29 17:16 ` Lars Ingebrigtsen
2021-10-29 18:41 ` Gregory Heytings
2021-10-29 18:47 ` Lars Ingebrigtsen
2021-10-29 18:54 ` Gregory Heytings [this message]
2021-10-29 19:00 ` Lars Ingebrigtsen
2021-10-29 19:18 ` Gregory Heytings
2021-10-30 11:38 ` Lars Ingebrigtsen
2021-10-29 20:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-29 20:28 ` Gregory Heytings
2021-10-29 21:04 ` Andreas Schwab
2021-10-30 1:24 ` Stefan Kangas
2021-10-30 8:48 ` Gregory Heytings
2021-10-30 11:36 ` Lars Ingebrigtsen
2021-11-01 8:18 ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-01 9:11 ` Gregory Heytings
2021-11-01 16:12 ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0a09f3248a66c7f098a@heytings.org \
--to=gregory@heytings.org \
--cc=51475@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=laszlomail@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).