unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: martin rudalics <rudalics@gmx.at>, 19012@debbugs.gnu.org
Subject: bug#19012: 25.0.50; `help-window-select'
Date: Tue, 11 Nov 2014 11:01:24 -0800 (PST)	[thread overview]
Message-ID: <b07efb3b-c084-4121-bf6e-a310f6615ff7@default> (raw)
In-Reply-To: <5462561B.2030306@gmx.at>

> This one is at least dubious
>  >      (setq return-window  (select-window
>  >                            ^^^^^^^^^^^^^
>  >                            (funcall special-display-function buf args)))
> According to its doc-string `display-buffer' should
> 
>    Display BUFFER-OR-NAME in some window, without selecting it.
> 
> As a rule, `display-buffer' should not select the window used.
> Otherwise, `with-help-window' cannot determine the correct window to
> select when quitting help.

That is a new restriction (beginning with `display-buffer-alist'), if it
is one.  `display-buffer' should, as it did prior to `display-buffer-alist',
respect `special-display-buffer-names' and `special-display-function',
which has no such restriction wrt its value's behavior, AFAIK.

And there should be *no reason* for such a restriction.  The addition
of the zillion things that complicated `display-buffer' was supposed to
make it *more* flexible, not less, letting users get more and finer
control over the behavior - not losing the ability to use an arbitrary
display function.

If `display-buffer' with default values for everything does not want
to select the displayed buffer, fine.  But `display-buffer' trying to
prohibit a user-defined display function from selecting (or doing
anything else) would be unnecessarily restrictive: it is not
`display-buffer's business what a user-defined "display" function
might do.

Besides which, "according to its doc-string `display-buffer'..." is
not a reason.  Its doc string can say nothing about what user-defined
display function `special-display-function' does, beyond what the doc
for that variable says.  It says (and should say) nothing about not
selecting the displayed buffer's window in such a case.

> However, with the current release and trunk, emacs -Q and
> (defun 1on1-display-*Help*-frame (buf &optional args) ...
> (add-to-list 'special-display-buffer-names...
> the *Help* window is always selected here after C-h f, C-h v, ...

Well, there is also non-nil `pop-up-frames' etc.  But I see that from
`emacs -Q', with only the above and non-nil `pop-up-frames', what you
say is true, so there must be something else involved as well.  I will
take a look when I get some time.





  reply	other threads:[~2014-11-11 19:01 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 16:42 bug#19012: 25.0.50; `help-window-select' Drew Adams
2014-11-10 17:28 ` martin rudalics
2014-11-10 18:23   ` Drew Adams
2014-11-11  8:29     ` martin rudalics
2014-11-11 14:26       ` Drew Adams
2014-11-11 18:31         ` martin rudalics
2014-11-11 19:01           ` Drew Adams [this message]
2014-11-11 21:04             ` Drew Adams
2014-11-13  5:12               ` Drew Adams
2014-11-13  7:44                 ` martin rudalics
2014-11-13 15:23                   ` Drew Adams
2014-11-13 16:28                     ` martin rudalics
2014-11-13 16:56                       ` Drew Adams
2014-11-13 18:47                         ` martin rudalics
2014-11-13 19:21                           ` Drew Adams
2014-11-14 11:37                             ` martin rudalics
2014-11-14 15:11                               ` Drew Adams
2014-11-14 16:38                                 ` martin rudalics
2014-11-14 17:09                                   ` Drew Adams
2014-11-14 17:39                                     ` martin rudalics
2014-11-14 17:47                                       ` Drew Adams
2014-11-14 18:10                                         ` martin rudalics
2014-11-14 18:28                                           ` Drew Adams
2014-11-14 18:33                                             ` martin rudalics
2014-11-14 18:44                                               ` Drew Adams
2014-11-14 19:08                                                 ` martin rudalics
2014-11-14 21:21                                                   ` Drew Adams
2014-11-15 11:24                                                     ` martin rudalics
2014-11-15 14:40                                                       ` Drew Adams
2014-11-16 11:36                                                         ` martin rudalics
2014-11-16 16:20                                                           ` Drew Adams
2014-11-16 17:36                                                             ` martin rudalics
2014-11-16 20:06                                                               ` Drew Adams
2014-11-17  9:29                                                                 ` martin rudalics
2014-11-17 14:29                                                                   ` Drew Adams
2014-12-25 19:30                                                                     ` martin rudalics
2014-11-11 22:16             ` Stefan Monnier
2014-11-11 23:10               ` Drew Adams
2014-11-12  1:49                 ` Stefan Monnier
2014-11-12  2:36                   ` Drew Adams
2014-11-12  4:11                     ` Stefan Monnier
2014-11-12  7:18                       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b07efb3b-c084-4121-bf6e-a310f6615ff7@default \
    --to=drew.adams@oracle.com \
    --cc=19012@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).