From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#32276: char-width of a space is 0 when display-table entry has a face. Date: Sat, 28 Jul 2018 15:37:50 -0700 Organization: UCLA Computer Science Department Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8FA0DE66A7E984DA330C17CE" X-Trace: blaine.gmane.org 1532817429 24540 195.159.176.226 (28 Jul 2018 22:37:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jul 2018 22:37:09 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 32276@debbugs.gnu.org, Keith David Bershatsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 29 00:37:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjXpg-0006Hu-ET for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 00:37:04 +0200 Original-Received: from localhost ([::1]:46590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjXrn-0004Du-5f for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jul 2018 18:39:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjXrf-0004Do-Fx for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 18:39:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjXra-0000LP-Hz for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 18:39:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56355) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjXra-0000LL-E5 for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 18:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjXra-0002oc-4m for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 18:39:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jul 2018 22:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32276-submit@debbugs.gnu.org id=B32276.153281748210725 (code B ref 32276); Sat, 28 Jul 2018 22:39:02 +0000 Original-Received: (at 32276) by debbugs.gnu.org; 28 Jul 2018 22:38:02 +0000 Original-Received: from localhost ([127.0.0.1]:33140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjXqb-0002ms-JP for submit@debbugs.gnu.org; Sat, 28 Jul 2018 18:38:01 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjXqZ-0002ma-Eu for 32276@debbugs.gnu.org; Sat, 28 Jul 2018 18:38:00 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0A3BC160661; Sat, 28 Jul 2018 15:37:53 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wTYCESUyZTWV; Sat, 28 Jul 2018 15:37:52 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17CBE1606C2; Sat, 28 Jul 2018 15:37:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lOK-Ux0gbX_9; Sat, 28 Jul 2018 15:37:51 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B3BE3160661; Sat, 28 Jul 2018 15:37:51 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149042 Archived-At: This is a multi-part message in MIME format. --------------8FA0DE66A7E984DA330C17CE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Unfortunately that change causes the emacs-26 build to fail for me: make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src' CC character.o In file included from character.c:34:0: character.c: In function =E2=80=98char_width=E2=80=99: lisp.h:1682:11: error: =E2=80=98c=E2=80=99 may be used uninitialized in t= his function=20 [-Werror=3Dmaybe-uninitialized] ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \ ^ character.c:292:10: note: =E2=80=98c=E2=80=99 was declared here int c; ^ cc1: all warnings being treated as errors Makefile:376: recipe for target 'character.o' failed Although the attached patch fixes this and presumably speeds up the code = a bit=20 when optimized, is this the right thing to do? I have not looked into the= code=20 carefully. --------------8FA0DE66A7E984DA330C17CE Content-Type: text/x-patch; name="0001-Adjust-recent-Bug-32276-fix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Adjust-recent-Bug-32276-fix.patch" =46rom 4c321dc8d6b059ddaf5aab137aadbae18a3cb5af Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 28 Jul 2018 15:36:04 -0700 Subject: [PATCH] Adjust recent Bug#32276 fix * src/character.c (char_width): Make explicit the assumption that a display character vector element is a character if is not a glyph code. --- src/character.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/character.c b/src/character.c index 48268e0..6af9825 100644 --- a/src/character.c +++ b/src/character.c @@ -293,8 +293,11 @@ char_width (int c, struct Lisp_Char_Table *dp) ch =3D AREF (disp, i); if (GLYPH_CODE_P (ch)) c =3D GLYPH_CODE_CHAR (ch); - else if (CHARACTERP (ch)) - c =3D XFASTINT (ch); + else + { + eassert (CHARACTERP (ch)); + c =3D XFASTINT (ch); + } int w =3D CHARACTER_WIDTH (c); if (INT_ADD_WRAPV (width, w, &width)) string_overflow (); --=20 2.7.4 --------------8FA0DE66A7E984DA330C17CE--