From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken Date: Sat, 21 Sep 2024 15:41:03 +0200 Message-ID: References: <86a5g9e32p.fsf@gnu.org> <86a5g148q9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6quecPipE0cPTf2DB7twqt0i" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1227"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73258@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 21 15:42:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss0N6-00005o-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Sep 2024 15:42:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss0Mr-00079B-62; Sat, 21 Sep 2024 09:41:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss0Mo-000790-6v for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 09:41:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ss0Mn-0008Lm-Ny for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 09:41:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=slyKmx1T+1jHaUOlqVHeI0psI4bbnsCoPjlEFdQZFLk=; b=R1Xalq1wS/3fE0p/SevWwrbUWTOVFxdswEIhle1/afKDQ0M9ho3syefy+QQiFiPTz5vQYFZiV+CMS+Zli/vS3VJOYIoLH3kaHVs4XXWDu+BKE8L+K3ZSi0ax/FNzNkrCHZdbw3vzJeIdDPvzqNxpu9tiQTwDJcXXOj4BBQcJq9qz1BBbRWlCZxH07wABDycROIyjKOiIwbILstSTp3T/CALxIuJTAtGHxz2eDwSR2WdBqzZRtjxpm981bEsjg8Uzn250IQvekzETm2zkEHcEA3DeUXXM709uYMeBTNOkH7qrKzX5rFoxw04GxIRqyp3Qt5KrWNXo2siqm/LAtdnlRw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ss0N7-0008Qc-LT for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73258 X-GNU-PR-Package: emacs Original-Received: via spool by 73258-submit@debbugs.gnu.org id=B73258.172692609232353 (code B ref 73258); Sat, 21 Sep 2024 13:42:01 +0000 Original-Received: (at 73258) by debbugs.gnu.org; 21 Sep 2024 13:41:32 +0000 Original-Received: from localhost ([127.0.0.1]:37614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss0Md-0008Pk-Gx for submit@debbugs.gnu.org; Sat, 21 Sep 2024 09:41:31 -0400 Original-Received: from mail.imayhem.com ([82.223.54.191]:45683 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss0Mb-0008PY-Ju for 73258@debbugs.gnu.org; Sat, 21 Sep 2024 09:41:30 -0400 Original-Received: from [192.168.68.103] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 7CB7F825FE; Sat, 21 Sep 2024 13:41:03 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.103] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Language: es-ES In-Reply-To: <86a5g148q9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292190 Archived-At: This is a multi-part message in MIME format. --------------6quecPipE0cPTf2DB7twqt0i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/09/2024 12:11, Eli Zaretskii wrote: > This causes the following warning while byte-compiling: > > In w32-dropped-file-to-url: > term/w32-win.el:129:29: Warning: reference to free variable `window' > > And indeed, 'window' is not bound to any value here, and > dnd-handle-multiple-urls does need it to be a valid window. If I try > drag-and-drop with your patch installed, Emacs signals an error about > 'window' being void. I don't understand how it worked for you. > > Also, what about this comment: > > ;; FIXME: is the W32 build capable only of receiving a single file > ;; from each drop? > > I guess it is no longer pertinent and should be deleted? I messed up when preparing the patch file, I'm sorry. Here is the correct one. --------------6quecPipE0cPTf2DB7twqt0i Content-Type: text/plain; charset=UTF-8; name="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Disposition: attachment; filename="0001-Fix-multifile-drag-n-drop-on-win32.patch" Content-Transfer-Encoding: base64 RnJvbSAzYzVhZjE0YjVjMGQ5NTYxNTNkODNmZTlhNTA0MWFlODk3ZTViOWViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDZWNpbGlvIFBhcmRvIDxjcGFyZG9AaW1heWhlbS5j b20+CkRhdGU6IFNhdCwgMjEgU2VwIDIwMjQgMTU6MzA6MjcgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggbXVsdGlmaWxlIGRyYWctbi1kcm9wIG9uIHdpbjMyCgpQYXNzIGFsbCBkcm9w cGVkIGZpbGVzIHRvIGRuZC1oYW5kbGUtbXVsdGlwbGUtdXJscwpvbiBvbmUgY2FsbCBpbnN0 ZWFkIG9uIGRvaW5nIG11bHRpcGxlIGNhbGxzIChCdWcjNzMyNTgpLgoqIGxpc3AvdGVybS93 MzItd2luLmVsICh3MzItZHJvcHBlZC1maWxlLXRvLXVybCk6IE5ldyBmdW5jdGlvbiB0bwpj b252ZXJ0IGZpbGUgbmFtZSB0byBhIHVybCBmb3IgZG5kCih3MzItaGFuZGxlLWRyb3BwZWQt ZmlsZSk6IENoYW5nZWQgdG8gdXNlIHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsCih3MzItZHJh Zy1uLWRyb3ApOiBDaGFuZ2VkIHRvIHBhc3MgYWxsIGZpbGVzIHRvCmRuZC1oYW5kbGUtbXVs dGlwbGUtdXJscwotLS0KIGxpc3AvdGVybS93MzItd2luLmVsIHwgMjcgKysrKysrKysrKysr KysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXJtL3czMi13aW4uZWwgYi9saXNw L3Rlcm0vdzMyLXdpbi5lbAppbmRleCAzYzBhY2YzNjhmNC4uYjU3YjNkZDNiZWYgMTAwNjQ0 Ci0tLSBhL2xpc3AvdGVybS93MzItd2luLmVsCisrKyBiL2xpc3AvdGVybS93MzItd2luLmVs CkBAIC0xMDEsNiArMTAxLDEzIEBAIHczMi1jb2xvci1tYXAKIDs7ICAgKHByaW5jIGV2ZW50 KSkKIAogKGRlZnVuIHczMi1oYW5kbGUtZHJvcHBlZC1maWxlICh3aW5kb3cgZmlsZS1uYW1l KQorICAoZG5kLWhhbmRsZS1tdWx0aXBsZS11cmxzCisgICB3aW5kb3cKKyAgIChsaXN0Cisg ICAgKHczMi1kcm9wcGVkLWZpbGUtdG8tdXJsIGZpbGUtbmFtZSkpCisgICAncHJpdmF0ZSkp CisKKyhkZWZ1biB3MzItZHJvcHBlZC1maWxlLXRvLXVybCAoZmlsZS1uYW1lKQogICAobGV0 ICgoZiAoaWYgKGVxIHN5c3RlbS10eXBlICdjeWd3aW4pCiAgICAgICAgICAgICAgICAoY3ln d2luLWNvbnZlcnQtZmlsZS1uYW1lLWZyb20td2luZG93cyBmaWxlLW5hbWUgdCkKICAgICAg ICAgICAgICAoc3Vic3QtY2hhci1pbi1zdHJpbmcgP1xcID8vIGZpbGUtbmFtZSkpKQpAQCAt MTE3LDE0ICsxMjQsMTEgQEAgdzMyLWhhbmRsZS1kcm9wcGVkLWZpbGUKICAgICAgICAgICAg ICAgICAgICAgIChzcGxpdC1zdHJpbmcgKGVuY29kZS1jb2Rpbmctc3RyaW5nIGYgY29kaW5n KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLyIpCiAgICAgICAgICAg ICAgICAgICAgICAiLyIpKSkKLSAgOzsgRklYTUU6IGlzIHRoZSBXMzIgYnVpbGQgY2FwYWJs ZSBvbmx5IG9mIHJlY2VpdmluZyBhIHNpbmdsZSBmaWxlCi0gIDs7IGZyb20gZWFjaCBkcm9w PwotICAoZG5kLWhhbmRsZS1tdWx0aXBsZS11cmxzIHdpbmRvdyAobGlzdCAoY29uY2F0Ci0J CQkgICAgICAgICAgICAgICAgICAoaWYgKGVxIHN5c3RlbS10eXBlICdjeWd3aW4pCi0JCQkJ ICAgICAgICAgICAgICAiZmlsZTovLyIKLQkJCSAgICAgICAgICAgICAgICAgICAgImZpbGU6 IikKLQkJCSAgICAgICAgICAgICAgICAgIGZpbGUtbmFtZSkpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ3ByaXZhdGUpKQorICAoY29uY2F0CisgICAoaWYgKGVxIHN5c3RlbS10 eXBlICdjeWd3aW4pCisgICAgICAgImZpbGU6Ly8iCisgICAgICJmaWxlOiIpCisgICBmaWxl LW5hbWUpKQogCiAoZGVmdW4gdzMyLWRyYWctbi1kcm9wIChldmVudCAmb3B0aW9uYWwgbmV3 LWZyYW1lKQogICAiRWRpdCB0aGUgZmlsZXMgbGlzdGVkIGluIHRoZSBkcmFnLW4tZHJvcCBF VkVOVC4KQEAgLTE0Niw4ICsxNTAsMTEgQEAgdzMyLWRyYWctbi1kcm9wCiAgICAgICAocmFp c2UtZnJhbWUpCiAgICAgICAoc2V0cSB3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpCiAKLSAg ICAgIChtYXBjIChhcHBseS1wYXJ0aWFsbHkgIyd3MzItaGFuZGxlLWRyb3BwZWQtZmlsZSB3 aW5kb3cpCi0gICAgICAgICAgICAoY2FyIChjZHIgKGNkciBldmVudCkpKSkpKSkKKyAgICAg IChkbmQtaGFuZGxlLW11bHRpcGxlLXVybHMKKyAgICAgICB3aW5kb3cKKyAgICAgICAobWFw Y2FyICMndzMyLWRyb3BwZWQtZmlsZS10by11cmwKKyAgICAgICAgICAgICAgIChjYXIgKGNk ciAoY2RyIGV2ZW50KSkpKQorICAgICAgICdwcml2YXRlKSkpKQogCiAoZGVmdW4gdzMyLWRy YWctbi1kcm9wLW90aGVyLWZyYW1lIChldmVudCkKICAgIkVkaXQgdGhlIGZpbGVzIGxpc3Rl ZCBpbiB0aGUgZHJhZy1uLWRyb3AgRVZFTlQsIGluIG90aGVyIGZyYW1lcy4KLS0gCjIuMzUu MS53aW5kb3dzLjIKCg== --------------6quecPipE0cPTf2DB7twqt0i--