Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t

[Glenn Morris <rgm@gnu.org>]

martin rudalics wrote:

> (1) The one window one frame minimalist has `pop-up-frames' and
>     `pop-up-windows' both and would like exiting view-mode to restore
>     the window shown before.

Seems to work fine (I assume there's a missing "nil" here).

> (2) The one window per frame type has `pop-up-frames' non-nil and
>     `pop-up-windows' nil and expects view-mode to pop up a new or reuse
>     an existing frame.

Quitting view mode iconifies the frame, which seems odd to me. This issue?

http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00103.html

> (3) The at most two windows per frame user has `pop-up-windows' non-nil
>     and `split-height-threshold' the default.  Such users expect
>     view-mode to reuse any "other window" on the present frame
>     regardless of its mode.

Seems to work fine.

> (4) The many windows per frame user has `pop-up-windows' non-nil and
>     customized `split-height-threshold' appropriately.  Users in this
>     group expect view-mode to reuse an existing window on the same frame
>     iff it's a view-mode window.

Seems to work fine.

> My changes should set up information for exiting view mode correctly for
> all of them.  The message printed when entering view-mode should be
> correct with respect to how to scroll the help window and how to get rid
> of its contents.

Yes, AFAICS.

> - Exiting view-mode should ideally (1) kill a window that has been
>   popped up for view-mode purposes and (2) show the earlier contents of
>   the window when it has been usurpated by view-mode.

Yes, AFAICS.

> - Exit information should not get overwritten when following links,
>   hitting backward/forward buttons and the like (including Nick's
>   `help-xref-go-forward').

Not sure what you mean. If you mean the "type foo to quit" message, it
seems to disappear on scrolling, clicking a link, indeed any key
press. That doesn't seem like a big problem to me though.

> - Something reasonable should be done when a user manually switches to a
>   view-mode buffer and types `q' in that buffer.  Hard to get right for
>   a type (2) user who intermittently displays some unrelated buffer in a
>   view-mode window, manually switches back to the view-mode buffer, and
>   types `q'.  What should I do here?  Kill the frame, display the other
>   buffer and possibly lower the frame, iconify the frame, `bury-buffer',
>   `quit-window', ...

Probably not too important. I would guess either kill the frame, or
display the other buffer, but it's not my use pattern.

> - Is the `help-window-select' option useful?

Looks like it could be.