From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43572: Feature request: make it possible to choose whether the first lines of the minibuffer should be displayed instead of the last ones Date: Wed, 23 Sep 2020 22:59:03 +0000 Message-ID: References: <83h7rov7xy.fsf@gnu.org> <837dskuvx3.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29683"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: 43572@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 24 01:00:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLDkB-0007cn-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Sep 2020 01:00:11 +0200 Original-Received: from localhost ([::1]:38538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLDkA-0008Fb-1I for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 19:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLDk2-0008FT-OZ for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 19:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLDk2-0006qa-Do for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 19:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLDk2-0006II-80 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 19:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Sep 2020 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43572 X-GNU-PR-Package: emacs Original-Received: via spool by 43572-submit@debbugs.gnu.org id=B43572.160090194924104 (code B ref 43572); Wed, 23 Sep 2020 23:00:02 +0000 Original-Received: (at 43572) by debbugs.gnu.org; 23 Sep 2020 22:59:09 +0000 Original-Received: from localhost ([127.0.0.1]:38125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLDjB-0006Gi-4m for submit@debbugs.gnu.org; Wed, 23 Sep 2020 18:59:09 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:49460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLDj8-0006GX-MJ for 43572@debbugs.gnu.org; Wed, 23 Sep 2020 18:59:07 -0400 Original-Received: from sdf.org (IDENT:ghe@otaku.sdf.org [205.166.94.8]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08NMx5pm006037 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 23 Sep 2020 22:59:05 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08NMxLCS023757; Wed, 23 Sep 2020 22:59:21 GMT In-Reply-To: <837dskuvx3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188834 Archived-At: >>> Binding the variable inside the minibuffer-setup-hook will affect all >>> the subsequent calls to resize_mini_window, until the next call to >>> read-from-minibuffer resets it, which may not be what the Lisp program >>> wants, and could have unintended consequences. >> >> I can't think of such unintended consequences. In the use case of >> displaying completion candidates, this (the fact that it affects all >> successive calls to resize_mini_window) is indeed what is wanted. > > Well, I _can_ think of such consequences. As I said, resize_mini_window > is called in many situations that don't involve completion, so setting > that variable to affect all of them is a bad idea. We need something > more fine-grained if we want to implement such a feature. > I believe I have dealt with these consequences (or at least with some of them) in the update patch I just sent. Feel free to tell me if there are other cases in which resize_mini_window() is called with a wrong value for start_display_at_beginning_of_minibuffer. It is now saved by read_minibuf(), and reset by read_minibuf() and read_minibuf_unwind().