From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43572: Feature request: make it possible to choose whether the first lines of the minibuffer should be displayed instead of the last ones Date: Wed, 23 Sep 2020 22:47:05 +0000 Message-ID: References: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="-212064758-1977573190-1600895041=:713" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18634"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: 43572@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 24 00:48:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLDYb-0004kG-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Sep 2020 00:48:13 +0200 Original-Received: from localhost ([::1]:37126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLDYa-0006pE-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 18:48:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLDYQ-0006p0-BB for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 18:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLDYQ-0005mW-1i for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 18:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLDYP-00060z-U2 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 18:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Sep 2020 22:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43572 X-GNU-PR-Package: emacs Original-Received: via spool by 43572-submit@debbugs.gnu.org id=B43572.160090123323063 (code B ref 43572); Wed, 23 Sep 2020 22:48:01 +0000 Original-Received: (at 43572) by debbugs.gnu.org; 23 Sep 2020 22:47:13 +0000 Original-Received: from localhost ([127.0.0.1]:38121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLDXc-0005zu-UJ for submit@debbugs.gnu.org; Wed, 23 Sep 2020 18:47:13 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:49981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLDXa-0005zk-FR for 43572@debbugs.gnu.org; Wed, 23 Sep 2020 18:47:11 -0400 Original-Received: from sdf.org (IDENT:ghe@otaku.sdf.org [205.166.94.8]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08NMl8ua022086 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 23 Sep 2020 22:47:09 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08NMlLk6022420; Wed, 23 Sep 2020 22:47:21 GMT In-Reply-To: Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188833 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---212064758-1977573190-1600895041=:713 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-ID: > > Really? Despite the `-Q`? Is it using a proportional font? > Oh, wait, is it because you're running that Emacs session in a tty rather than in a GUI? > Yes, yes, no, no ;-) > > How many columns wide is the frame? > 167, Sir! ;-) >> No, if you look at the patch its value is reset to nil whenever the >> minibuffer is entered. > > That still leaves the non-minibuffer uses of the mini window (i.e. the > echo area). > > And of course, that will also result in the use of an incorrect value > when you exit a *nested* minibuffer (unless both minibuffers were using > the same value). > Thank you very much for the pointers, indeed I completely forgot about these cases. See the attached corrected patch, in which they are dealt with. I believe start_display_at_beginning_of_minibuffer how has the value it should have whenever resize_mini_window() is called. >>> I don't have a patch to suggest, but I think ideally, I'd want clients >>> like icomplete to tell the redisplay either something like "please >>> display as much as possible of *this* chunk of text" or maybe "feel >>> free not to display all of this overlay, it's not super important". >> >> Yes, that's the point. The patch I proposed tells redisplay "please >> display as much as possible of the text between BOB and point", when >> the current behavior tells redisplay "please display as much as >> possible of the text between point and EOB". Something more >> fine-grained would of course be possible, but I don't think it is a >> good idea to implement a feature when there is no clear need for it. > > I think what I was getting at is that this "request" should come from > the minibuffer's text rather than from a variable. > If this were possible, it would be even better indeed. An "importance" text property, which would inform redisplay (?) of the relative importance of the parts of the buffer. But implementing this is several orders of magnitude harder than implementing my proposal. ---212064758-1977573190-1600895041=:713 Content-Type: text/x-diff; name=start-display-at-beginning-of-minibuffer.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=start-display-at-beginning-of-minibuffer.patch ZGlmZiAtLWdpdCBhL3NyYy9taW5pYnVmLmMgYi9zcmMvbWluaWJ1Zi5jDQpp bmRleCBmOTU3YjJhZTE3Li42OTFhOGM0ZjliIDEwMDY0NA0KLS0tIGEvc3Jj L21pbmlidWYuYw0KKysrIGIvc3JjL21pbmlidWYuYw0KQEAgLTQ3Miw2ICs0 NzIsOCBAQCByZWFkX21pbmlidWYgKExpc3BfT2JqZWN0IG1hcCwgTGlzcF9P YmplY3QgaW5pdGlhbCwgTGlzcF9PYmplY3QgcHJvbXB0LA0KICAgICA9IEZj b25zIChWb3ZlcnJpZGluZ19sb2NhbF9tYXAsDQogCSAgICAgRmNvbnMgKG1p bmlidWZfd2luZG93LA0KIAkJICAgIG1pbmlidWZfc2F2ZV9saXN0KSk7DQor ICBtaW5pYnVmX3NhdmVfbGlzdA0KKyAgICA9IEZjb25zIChWc3RhcnRfZGlz cGxheV9hdF9iZWdpbm5pbmdfb2ZfbWluaWJ1ZmZlciwgbWluaWJ1Zl9zYXZl X2xpc3QpOw0KICAgbWluaWJ1Zl9zYXZlX2xpc3QNCiAgICAgPSBGY29ucyAo bWluaWJ1Zl9wcm9tcHQsDQogCSAgICAgRmNvbnMgKG1ha2VfZml4bnVtICht aW5pYnVmX3Byb21wdF93aWR0aCksDQpAQCAtNDk0LDYgKzQ5Niw3IEBAIHJl YWRfbWluaWJ1ZiAoTGlzcF9PYmplY3QgbWFwLCBMaXNwX09iamVjdCBpbml0 aWFsLCBMaXNwX09iamVjdCBwcm9tcHQsDQogDQogICAvKiBOb3cgdGhhdCB3 ZSBjYW4gcmVzdG9yZSBhbGwgdGhvc2UgdmFyaWFibGVzLCBzdGFydCBjaGFu Z2luZyB0aGVtLiAgKi8NCiANCisgIFZzdGFydF9kaXNwbGF5X2F0X2JlZ2lu bmluZ19vZl9taW5pYnVmZmVyID0gUW5pbDsNCiAgIG1pbmlidWZfcHJvbXB0 X3dpZHRoID0gMDsNCiAgIG1pbmlidWZfcHJvbXB0ID0gRmNvcHlfc2VxdWVu Y2UgKHByb21wdCk7DQogICBWbWluaWJ1ZmZlcl9oaXN0b3J5X3Bvc2l0aW9u ID0gaGlzdHBvczsNCkBAIC04MDIsNiArODA1LDggQEAgcmVhZF9taW5pYnVm X3Vud2luZCAodm9pZCkNCiAgIG1pbmlidWZfc2F2ZV9saXN0ID0gRmNkciAo bWluaWJ1Zl9zYXZlX2xpc3QpOw0KICAgVm1pbmlidWZmZXJfaGlzdG9yeV92 YXJpYWJsZSA9IEZjYXIgKG1pbmlidWZfc2F2ZV9saXN0KTsNCiAgIG1pbmli dWZfc2F2ZV9saXN0ID0gRmNkciAobWluaWJ1Zl9zYXZlX2xpc3QpOw0KKyAg VnN0YXJ0X2Rpc3BsYXlfYXRfYmVnaW5uaW5nX29mX21pbmlidWZmZXIgPSBG Y2FyIChtaW5pYnVmX3NhdmVfbGlzdCk7DQorICBtaW5pYnVmX3NhdmVfbGlz dCA9IEZjZHIgKG1pbmlidWZfc2F2ZV9saXN0KTsNCiAgIFZvdmVycmlkaW5n X2xvY2FsX21hcCA9IEZjYXIgKG1pbmlidWZfc2F2ZV9saXN0KTsNCiAgIG1p bmlidWZfc2F2ZV9saXN0ID0gRmNkciAobWluaWJ1Zl9zYXZlX2xpc3QpOw0K ICNpZiAwDQpAQCAtMjA5Nyw2ICsyMTAyLDE1IEBAIHN5bXNfb2ZfbWluaWJ1 ZiAodm9pZCkNCiB1c2VzIHRvIGhpZGUgcGFzc3dvcmRzLiAgKi8pOw0KICAg VnJlYWRfaGlkZV9jaGFyID0gUW5pbDsNCiANCisgIERFRlZBUl9MSVNQICgi c3RhcnQtZGlzcGxheS1hdC1iZWdpbm5pbmctb2YtbWluaWJ1ZmZlciIsIFZz dGFydF9kaXNwbGF5X2F0X2JlZ2lubmluZ19vZl9taW5pYnVmZmVyLA0KKwkg ICAgICAgZG9jOiAvKiBXaGV0aGVyIHRvIHByZWZlcmFibHkgZGlzcGxheSB0 aGUgYmVnaW5uaW5nIG9mIHRoZSBtaW5pYnVmZmVyLg0KK1doZW4gdGhlIG1p bmktd2luZG93IGlzIG5vdCBsYXJnZSBlbm91Z2ggdG8gZGlzcGxheSB0aGUg Y29tcGxldGUgbWluaWJ1ZmZlciwNCit0aGUgZGVmYXVsdCBiZWhhdmlvciBp cyB0byBkaXNwbGF5IHRoZSBsYXN0IHBhcnQgb2YgdGhlIG1pbmlidWZmZXIg YW5kIHRvDQoraGlkZSBpdHMgZmlyc3QgcGFydC4gIFRoaXMgdmFyaWFibGUg cmV2ZXJzZXMgdGhhdCBiZWhhdmlvci4gIFRoaXMgdmFyaWFibGUNCitpcyBy ZXNldCBiZWZvcmUgYW5kIGFmdGVyIGVhY2ggcmVhZCBmcm9tIHRoZSBtaW5p YnVmZmVyLCBhbmQgbXVzdCBiZSBzZXQgaW4NCitgbWluaWJ1ZmZlci1zZXR1 cC1ob29rJy4gICovKTsNCisgIFZzdGFydF9kaXNwbGF5X2F0X2JlZ2lubmlu Z19vZl9taW5pYnVmZmVyID0gUW5pbDsNCisNCiAgIGRlZnN1YnIgKCZTYWN0 aXZlX21pbmlidWZmZXJfd2luZG93KTsNCiAgIGRlZnN1YnIgKCZTc2V0X21p bmlidWZmZXJfd2luZG93KTsNCiAgIGRlZnN1YnIgKCZTcmVhZF9mcm9tX21p bmlidWZmZXIpOw0KZGlmZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hk aXNwLmMNCmluZGV4IDQ5MjI1YzU2ZmUuLjFiMWEzNGI5N2YgMTAwNjQ0DQot LS0gYS9zcmMveGRpc3AuYw0KKysrIGIvc3JjL3hkaXNwLmMNCkBAIC0xMTgw NCw3ICsxMTgwNCw3IEBAIHJlc2l6ZV9taW5pX3dpbmRvdyAoc3RydWN0IHdp bmRvdyAqdywgYm9vbCBleGFjdF9wKQ0KIAl9DQogDQogICAgICAgLyogQ29t cHV0ZSBhIHN1aXRhYmxlIHdpbmRvdyBzdGFydC4gICovDQotICAgICAgaWYg KGhlaWdodCA+IG1heF9oZWlnaHQpDQorICAgICAgaWYgKGhlaWdodCA+IG1h eF9oZWlnaHQgJiYgIUVRIChWc3RhcnRfZGlzcGxheV9hdF9iZWdpbm5pbmdf b2ZfbWluaWJ1ZmZlciwgUXQpKQ0KIAl7DQogCSAgaGVpZ2h0ID0gKG1heF9o ZWlnaHQgLyB1bml0KSAqIHVuaXQ7DQogCSAgaW5pdF9pdGVyYXRvciAoJml0 LCB3LCBaViwgWlZfQllURSwgTlVMTCwgREVGQVVMVF9GQUNFX0lEKTsNCkBA IC0xMTgxMiw3ICsxMTgxMiwxMCBAQCByZXNpemVfbWluaV93aW5kb3cgKHN0 cnVjdCB3aW5kb3cgKncsIGJvb2wgZXhhY3RfcCkNCiAJICBzdGFydCA9IGl0 LmN1cnJlbnQucG9zOw0KIAl9DQogICAgICAgZWxzZQ0KLQlTRVRfVEVYVF9Q T1MgKHN0YXJ0LCBCRUdWLCBCRUdWX0JZVEUpOw0KKwl7DQorCSAgaWYgKGhl aWdodCA+IG1heF9oZWlnaHQpIGhlaWdodCA9IChtYXhfaGVpZ2h0IC8gdW5p dCkgKiB1bml0Ow0KKwkgIFNFVF9URVhUX1BPUyAoc3RhcnQsIEJFR1YsIEJF R1ZfQllURSk7DQorCX0NCiANCiAgICAgICBTRVRfTUFSS0VSX0ZST01fVEVY VF9QT1MgKHctPnN0YXJ0LCBzdGFydCk7DQogDQo= ---212064758-1977573190-1600895041=:713--