From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43519: 28.0.50; Overlay at end of minibuf hides minibuf's real content Date: Mon, 21 Sep 2020 20:49:05 +0000 Message-ID: References: <83wo0p1twr.fsf@gnu.org> <83r1qx1q9v.fsf@gnu.org> <838sd425l2.fsf@gnu.org> <83y2l3xm15.fsf@gnu.org> <83eemvxbvg.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Eli Zaretskii , 43519@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 23 17:19:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL6Yl-0007DF-4B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 17:19:55 +0200 Original-Received: from localhost ([::1]:41280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL6Yk-0003bL-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 11:19:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL6U7-0007i3-2I for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 11:15:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kL6U2-0004Ef-JJ for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 11:15:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kL6U2-0007ZK-FU for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 11:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Sep 2020 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43519 X-GNU-PR-Package: emacs Original-Received: via spool by 43519-submit@debbugs.gnu.org id=B43519.160087408128996 (code B ref 43519); Wed, 23 Sep 2020 15:15:02 +0000 Original-Received: (at 43519) by debbugs.gnu.org; 23 Sep 2020 15:14:41 +0000 Original-Received: from localhost ([127.0.0.1]:37488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kL6Th-0007Xc-0h for submit@debbugs.gnu.org; Wed, 23 Sep 2020 11:14:41 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:51814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kL6Tf-0007XU-MR for 43519@debbugs.gnu.org; Wed, 23 Sep 2020 11:14:40 -0400 Original-Received: from sdf.org (IDENT:smmsp@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 08NFEGVL000557 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 23 Sep 2020 15:14:39 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 08LKnL0r015524; Mon, 21 Sep 2020 20:49:21 GMT In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188795 Archived-At: >> IOW, you leave it entirely to the generic window-display code to select >> window-start based just on the value of point? > > Yes. It seems to work very well. Even the corner case regression above > doesn't seem very serious and can be addressed using the > scroll_conservatively code. > A last note: w->start has already been set to its default value (BEGV) just after entering resize_mini_window(), so the else part in your patch is not necessary anymore. Your code has the same effect as simply doing: if (height > max_height) height = (max_height / unit) * unit; in place of the "Compute a suitable window start" part.