From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Date: Fri, 28 Aug 2020 13:17:21 +0000 Message-ID: References: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9183"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) To: 41423@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 15:18:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBeGg-0002HN-A5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 15:18:10 +0200 Original-Received: from localhost ([::1]:44968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBeGf-0008Ch-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 09:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBeGY-0008CO-6A for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 09:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBeGX-0004DG-SX for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 09:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBeGX-0007R6-Nr for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41423 X-GNU-PR-Package: emacs Original-Received: via spool by 41423-submit@debbugs.gnu.org id=B41423.159862065028540 (code B ref 41423); Fri, 28 Aug 2020 13:18:01 +0000 Original-Received: (at 41423) by debbugs.gnu.org; 28 Aug 2020 13:17:30 +0000 Original-Received: from localhost ([127.0.0.1]:45604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBeG1-0007QG-VH for submit@debbugs.gnu.org; Fri, 28 Aug 2020 09:17:30 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:60326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBeFz-0007Q5-Cn for 41423@debbugs.gnu.org; Fri, 28 Aug 2020 09:17:28 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07SDHORK025628 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 28 Aug 2020 13:17:24 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07SDHNLG003722; Fri, 28 Aug 2020 13:17:23 GMT In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186605 Archived-At: A last note: this bug exists because in Emacs 27 eshell uses `pcomplete-completions-at-point': TAB is bound to `completion-at-point' and `completion-at-point-functions' is `(pcomplete-completions-at-point t)'. In Emacs 26 eshell used the (now obsolete) `pcomplete' function: TAB was bound to `eshell-pcomplete', which was defined as follows: (defun eshell-pcomplete (&optional interactively) "Eshell wrapper for `pcomplete'." (interactive "p") (setq this-command 'pcomplete) (condition-case nil (if interactively (call-interactively 'pcomplete) (pcomplete)) (text-read-only (completion-at-point)))) IOW, pcomplete-completions-at-point was called only if `pcomplete' failed, and is now called by default. (`completion-at-point-functions' was set to `(pcomplete-completions-at-point t)', as in Emacs 27.) A simple fix is to eval (setq completion-at-point-functions '(pcomplete t)) after starting eshell (or to put this in one of the eshell hooks), which will restore the previous default behavior. I have no idea how `pcomplete-completions-at-point' should be adapted to avoid this bug.