From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Date: Fri, 28 Aug 2020 09:32:48 +0000 Message-ID: References: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) To: 41423@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 11:38:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBapr-000ACE-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 11:38:15 +0200 Original-Received: from localhost ([::1]:35252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBapq-0006TT-V5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 05:38:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBako-0003jw-C2 for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 05:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBako-0005Oa-1l for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 05:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBakn-0005l0-V0 for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 05:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41423 X-GNU-PR-Package: emacs Original-Received: via spool by 41423-submit@debbugs.gnu.org id=B41423.159860717522118 (code B ref 41423); Fri, 28 Aug 2020 09:33:01 +0000 Original-Received: (at 41423) by debbugs.gnu.org; 28 Aug 2020 09:32:55 +0000 Original-Received: from localhost ([127.0.0.1]:45099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBakh-0005kg-E4 for submit@debbugs.gnu.org; Fri, 28 Aug 2020 05:32:55 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBakf-0005kW-G1 for 41423@debbugs.gnu.org; Fri, 28 Aug 2020 05:32:54 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07S9WoBi001963 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 28 Aug 2020 09:32:51 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07S9WoXl022017; Fri, 28 Aug 2020 09:32:50 GMT In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186588 Archived-At: > > The root of this bug is that `eshell-complete-commands-list' loops > through all executables *on the remote server* with (while comps-in-path > ...). That means typically 1000-2000 commands to check, one by one, > hence the 3 minutes delay. > > The easy fix is to hit C-g, which stops this loop. > Another note: in fact this bug exists because `eshell-complete-commands-list' is, in this context, called in Emacs 27, but not in Emacs 26 and earlier. The backtrace is: * eshell-complete-commands-list() #f(compiled-function () #)() pcomplete--here(#f(compiled-function () #) nil nil nil) #f(compiled-function () #)() pcomplete-completions() pcomplete-completions-at-point() #f(compiled-function () #)() completion-in-region--postch() In Emacs 26 `pcomplete--here' is called only once, with `pcomplete-entries' and `file-directory-p' in its `form' argument, and `pcomplete-completions' returns. In Emacs 27 `pcomplete--here' is called twice with these arguments, and a third time with `eshell-complete-commands-list' as its `form' argument. It is this third call which takes about three minutes to complete.