From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#42383: 28.0.50; Two bugs with M-x compile Date: Thu, 16 Jul 2020 09:48:56 +0000 Message-ID: References: Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28038"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.21 (NEB 202 2017-01-01) To: 42383@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 11:50:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw0Wo-0007Ai-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 11:50:10 +0200 Original-Received: from localhost ([::1]:35980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw0Wn-00014i-Hk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 05:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw0Wg-00013a-HB for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 05:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw0Wg-0006Mk-7A for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 05:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw0Wg-0005wd-5Z for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 05:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 09:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42383 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159489296022798 (code B ref -1); Thu, 16 Jul 2020 09:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Jul 2020 09:49:20 +0000 Original-Received: from localhost ([127.0.0.1]:54629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw0W0-0005ve-Iv for submit@debbugs.gnu.org; Thu, 16 Jul 2020 05:49:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw0Vy-0005vV-Bc for submit@debbugs.gnu.org; Thu, 16 Jul 2020 05:49:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw0Vy-00011M-4C for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 05:49:18 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:51933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw0Vw-00066g-0O for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 05:49:17 -0400 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 06G9n0Um023963 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 16 Jul 2020 09:49:00 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 06G9mxBh009577; Thu, 16 Jul 2020 09:48:59 GMT In-Reply-To: Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 05:49:14 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183045 Archived-At: > > ** Bug 1 ** > > Steps to reproduce: > > 1. create a Makefile with a few targets > 2. start emacs -Q > 3. M-x compile > 4. press TAB: the list of targets is displayed > 5. type the first character of an existing target, and press TAB > 6. the result is a "[No match]" > > This has been working correctly for years (tested with Emacs 24, 25, > 26), and does not work anymore with Emacs 28. > > It seems that at step 5 above the list of completion candidates that is > considered are subdirectories. > Upon further investigation, this bug has been introduced by the patch for bug#34330, which moved pcomplete-completions-at-point last in shell-dynamic-complete-functions in shell.el: (defcustom shell-dynamic-complete-functions '(comint-c-a-p-replace-by-expanded-history shell-environment-variable-completion shell-command-completion shell-c-a-p-replace-by-expanded-directory shell-filename-completion comint-filename-completion ;; Put `pcomplete-completions-at-point' last so that other ;; functions can run before it does, see bug#34330. pcomplete-completions-at-point) See https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e4d17d8cb479ffeeb7dfb7320a1432722ac8df75 . The obvious fix is to revert the situation (that is, to move pcomplete-completions-at-point again before shell-filename-completion), but I'm not sure, because bug#34330 would again exist. That being said, I'm not sure that handling the exceptional case of filenames with '&' characters correctly when completing in M-x shell (which is what bug#34330 is about) justifies to break normal behavior in other situations. Gregory