unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gregory Heytings via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 42383@debbugs.gnu.org
Subject: bug#42383: 28.0.50; Two bugs with M-x compile
Date: Wed, 15 Jul 2020 23:23:37 +0000	[thread overview]
Message-ID: <alpine.NEB.2.21.2007160054001394.22866@sdf.lonestar.org> (raw)


** Bug 1 **

Steps to reproduce:

1. create a Makefile with a few targets
2. start emacs -Q
3. M-x compile
4. press TAB: the list of targets is displayed
5. type the first character of an existing target, and press TAB
6. the result is a "[No match]"

This has been working correctly for years (tested with Emacs 24, 25, 26), 
and does not work anymore with Emacs 28.

It seems that at step 5 above the list of completion candidates that is 
considered are subdirectories.

** Bug 2 **

There are too many completion candidates for the list of targets.  For 
example, for the Makefile "foo:\n\techo foo:\n" two candidates are 
displayed: "foo" and "echo".  It seems that the regexp in 
pcmpl-gnu-make-targets is too large, and should be fixed as follows:

--- pcmpl-gnu.el.orig	2020-06-29 17:39:26.000000000 +0000
+++ pcmpl-gnu.el	2020-07-15 22:43:14.368938346 +0000
@@ -118,7 +118,7 @@
  Return the new list."
    (goto-char (point-min))
    (while (re-search-forward
-	  "^\\s-*\\([^\n#%.$][^:=\n]*\\)\\s-*:[^=]" nil t)
+          "^\\([^\t\n#%.$][^:=\n]*\\)\\s-*:[^=]" nil t)
      (setq targets (nconc (split-string (match-string-no-properties 1))
                           targets)))
    targets)

I see no reason to allow one or more TABs or spaces at the beginning of 
targets, as does the "^\\s-*".

Gregory





             reply	other threads:[~2020-07-15 23:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 23:23 Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-07-16  9:48 ` bug#42383: 28.0.50; Two bugs with M-x compile Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-16 15:17   ` Eli Zaretskii
2020-07-16 18:55     ` Stefan Monnier
2020-07-16 21:39       ` Alex Branham
2020-07-16 22:37         ` Stefan Monnier
2020-07-18  8:22         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.NEB.2.21.2007160054001394.22866@sdf.lonestar.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=42383@debbugs.gnu.org \
    --cc=ghe@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).