* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
@ 2020-12-22 19:51 E. Choroba
2020-12-25 6:02 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: E. Choroba @ 2020-12-22 19:51 UTC (permalink / raw)
To: 45373
[-- Attachment #1: Type: text/plain, Size: 20 bytes --]
Patch attached.
Ch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch; NAME=0001-cperl-mode-Correctly-syntax-highlight-index-value-ar.patch, Size: 1020 bytes --]
From 3d34a658b8fe8de791f65f97bce4cb19545faadf Mon Sep 17 00:00:00 2001
From: "E. Choroba" <choroba@matfyz.cz>
Date: Tue, 22 Dec 2020 20:44:24 +0100
Subject: [PATCH] cperl-mode: Correctly syntax highlight index/value array
slices
%array[0, 1] should use the array face, not the hash one.
---
lisp/progmodes/cperl-mode.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index 87542ea133..2fc2d14ee6 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -5666,7 +5666,7 @@ indentation and initial hashes. Behaves usually outside of comment."
'cperl-hash-face
'cperl-array-face)
nil) ; arrays and hashes
- ("\\(\\([$@]+\\)[a-zA-Z_:][a-zA-Z0-9_:]*\\)[ \t]*\\([[{]\\)"
+ ("\\(\\([$@%]+\\)[a-zA-Z_:][a-zA-Z0-9_:]*\\)[ \t]*\\([[{]\\)"
1
(if (= (- (match-end 2) (match-beginning 2)) 1)
(if (eq (char-after (match-beginning 3)) ?{)
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
2020-12-22 19:51 bug#45373: cperl-mode: Correctly syntax highlight index/value array slices E. Choroba
@ 2020-12-25 6:02 ` Lars Ingebrigtsen
2020-12-25 17:27 ` E. Choroba
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25 6:02 UTC (permalink / raw)
To: E. Choroba; +Cc: 45373
"E. Choroba" <choroba@matfyz.cz> writes:
> Patch attached.
Thanks; applied to Emacs 28.
This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
2020-12-25 6:02 ` Lars Ingebrigtsen
@ 2020-12-25 17:27 ` E. Choroba
2020-12-25 19:41 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: E. Choroba @ 2020-12-25 17:27 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 45373
Paperwork sounds scary :-) What does it really mean?
Ch.
==============================================================================
On Fri, 25 Dec 2020, Lars Ingebrigtsen wrote:
> "E. Choroba" <choroba@matfyz.cz> writes:
>
>> Patch attached.
>
> Thanks; applied to Emacs 28.
>
> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
2020-12-25 17:27 ` E. Choroba
@ 2020-12-25 19:41 ` Lars Ingebrigtsen
2020-12-30 21:36 ` E. Choroba
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25 19:41 UTC (permalink / raw)
To: E. Choroba; +Cc: 45373
"E. Choroba" <choroba@matfyz.cz> writes:
> Paperwork sounds scary :-) What does it really mean?
It's a copyright assignment to the Free Software Foundation for the code
contributed to Emacs. Here's a page that explains the reasoning behind
this:
https://www.gnu.org/licenses/why-assign.en.html
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
2020-12-25 19:41 ` Lars Ingebrigtsen
@ 2020-12-30 21:36 ` E. Choroba
2020-12-31 4:49 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: E. Choroba @ 2020-12-30 21:36 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 45373
Sounds OK, thank you. Where can I sign it?
Ch.
==============================================================================
On Fri, 25 Dec 2020, Lars Ingebrigtsen wrote:
> "E. Choroba" <choroba@matfyz.cz> writes:
>
>> Paperwork sounds scary :-) What does it really mean?
>
> It's a copyright assignment to the Free Software Foundation for the code
> contributed to Emacs. Here's a page that explains the reasoning behind
> this:
>
> https://www.gnu.org/licenses/why-assign.en.html
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45373: cperl-mode: Correctly syntax highlight index/value array slices
2020-12-30 21:36 ` E. Choroba
@ 2020-12-31 4:49 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-31 4:49 UTC (permalink / raw)
To: E. Choroba; +Cc: 45373
"E. Choroba" <choroba@matfyz.cz> writes:
> Sounds OK, thank you. Where can I sign it?
Here's the form to get started:
Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.
Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
[What is the name of the program or package you're contributing to?]
Emacs
[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]
[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]
[For the copyright registration, what country are you a citizen of?]
[What year were you born?]
[Please write your email address here.]
[Please write your postal address here.]
[Which files have you changed so far, and which new files have you written
so far?]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-31 4:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-22 19:51 bug#45373: cperl-mode: Correctly syntax highlight index/value array slices E. Choroba
2020-12-25 6:02 ` Lars Ingebrigtsen
2020-12-25 17:27 ` E. Choroba
2020-12-25 19:41 ` Lars Ingebrigtsen
2020-12-30 21:36 ` E. Choroba
2020-12-31 4:49 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).