From: Tino Calancha <f92capac@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tino Calancha <f92capac@gmail.com>, 23325@debbugs.gnu.org
Subject: bug#23325: 25.0.92; insert-char: cannot find all chars if input is unicode name
Date: Fri, 22 Apr 2016 12:08:31 +0900 (JST) [thread overview]
Message-ID: <alpine.LRH.2.20.1604221205500.9748@calancha-ilc.kek.jp> (raw)
In-Reply-To: <83fuue6959.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
> It would be better if the code didn't have to
> define in yet another place which characters are omitted; instead, how
> about checking if the character is in the ucs-names list?
Absolutely. Implemented in the new patch.
[-- Attachment #2: Type: text/plain, Size: 1137 bytes --]
From 592473bed4a6986e9dc96489f63a174112cc90d5 Mon Sep 17 00:00:00 2001
From: Tino Calancha <f92capac@gmail.com>
Date: Fri, 22 Apr 2016 12:00:14 +0900
Subject: [PATCH] describe-char: fix insert char documentation
* lisp/descr-text.el (describe-char):
Only 'ucs-names' entries can be inserted by unicode name (Bug#23325).
---
lisp/descr-text.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/descr-text.el b/lisp/descr-text.el
index a352ed0..4dac6bb 100644
--- a/lisp/descr-text.el
+++ b/lisp/descr-text.el
@@ -619,7 +619,8 @@ describe-char
(let ((name
(or (get-char-code-property char 'name)
(get-char-code-property char 'old-name))))
- (if name
+ (if (and name
+ (assoc-string name (or ucs-names (ucs-names))))
(format
"type \"C-x 8 RET %x\" or \"C-x 8 RET %s\""
char name)
--
2.8.0.rc3
next prev parent reply other threads:[~2016-04-22 3:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 4:40 bug#23325: 25.0.92; insert-char: cannot find all chars if input is unicode name Tino Calancha
2016-04-21 14:00 ` Eli Zaretskii
2016-04-21 14:32 ` Tino Calancha
2016-04-21 15:44 ` Eli Zaretskii
2016-04-21 17:39 ` Tino Calancha
2016-04-21 19:42 ` Eli Zaretskii
2016-04-22 3:08 ` Tino Calancha [this message]
2016-04-22 7:32 ` Andreas Schwab
2016-04-22 7:56 ` Tino Calancha
2016-04-23 19:52 ` bug#23325: 25.0.92; insert-char: cannot find all chars if input, " Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1604221205500.9748@calancha-ilc.kek.jp \
--to=f92capac@gmail.com \
--cc=23325@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).