From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#22893: 25.1.50; dired-get-marked-files get all marked Date: Thu, 10 Mar 2016 13:19:10 +0900 (JST) Message-ID: References: <87mvqel8xy.fsf@gnus.org> <83io0xrmam.fsf@gnu.org> <87h9gfus7a.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-844313517-1457583550=:23082" X-Trace: ger.gmane.org 1457583447 7155 80.91.229.3 (10 Mar 2016 04:17:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2016 04:17:27 +0000 (UTC) Cc: Tino Calancha , 22893@debbugs.gnu.org, larsi@gnus.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 10 05:17:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ads2A-0003vx-Vv for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 05:17:11 +0100 Original-Received: from localhost ([::1]:46126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ads2A-0007wK-Ef for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Mar 2016 23:17:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ads25-0007wE-DN for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 23:17:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ads22-00028o-65 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 23:17:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ads22-00028k-34 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 23:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1ads21-0008Ti-T4 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 23:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2016 04:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22893 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22893-submit@debbugs.gnu.org id=B22893.145758336532517 (code B ref 22893); Thu, 10 Mar 2016 04:17:01 +0000 Original-Received: (at 22893) by debbugs.gnu.org; 10 Mar 2016 04:16:05 +0000 Original-Received: from localhost ([127.0.0.1]:42141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1ads17-0008SP-IA for submit@debbugs.gnu.org; Wed, 09 Mar 2016 23:16:05 -0500 Original-Received: from calancha-ilc.kek.jp ([130.87.234.234]:59508) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1ads14-0008Re-Vb for 22893@debbugs.gnu.org; Wed, 09 Mar 2016 23:16:03 -0500 Original-Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id D63FFB496; Thu, 10 Mar 2016 13:19:10 +0900 (JST) Original-Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id B872356B8; Thu, 10 Mar 2016 13:19:10 +0900 (JST) X-X-Sender: calancha@calancha-ilc.kek.jp In-Reply-To: <87h9gfus7a.fsf@mail.linkov.net> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114685 Archived-At: --1468197610-844313517-1457583550=:23082 Content-Type: text/plain; format=flowed; charset=US-ASCII > Since you are changing the function signatures anyway, > you could make them consistent between `dired-map-over-marks' > and `dired-get-marked-files' by adding an explicit arg `marker-char', > i.e. both `dired-get-marked-files' and `dired-map-over-marks' > could end with "distinguish-one-marked marker-char all-marks", > thus explicitly passing `marker-char' arg down the call chain. > Then you'll need `(or marker-char dired-marker-char)' in > `dired-marker-regexp' for backward-compatibility. And then also > no need to let-bind `dired-marker-char' in `dired-get-marked-files' > (it's better to avoid dynamically binding global variables where possible). It sounds good. Thank you. Implemented in the new patch. --1468197610-844313517-1457583550=:23082 Content-Type: text/plain; charset=US-ASCII; name=0001-Avoid-dynamic-global-var-binding.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Avoid-dynamic-global-var-binding.patch RnJvbSA1NDQyODQ0NDQxMGFhYWNjOGQxZTg2Njc4ZGNiOWE4ZTk1ZmNjZDRi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogVGlubyBDYWxhbmNo YSA8ZjkyY2FwYWNAZ21haWwuY29tPg0KRGF0ZTogVGh1LCAxMCBNYXIgMjAx NiAxMzoxMToyMyArMDkwMA0KU3ViamVjdDogW1BBVENIXSBBdm9pZCBkeW5h bWljIGdsb2JhbCB2YXIgYmluZGluZw0KDQoqIGxpc3AvZGlyZWQuZWwgKGRp cmVkLW1hcC1vdmVyLW1hcmtzKTogTGFzdCAzIGFyZ3VtZW50cw0KbGlrZSBp biAnZGlyZWQtZ2V0LW1hcmtlZC1maWxlcycgKEJ1ZyMyMjg5MykuDQooZGly ZWQtZ2V0LW1hcmtlZC1maWxlcyk6IFBhc3NpbmcgYXJnLiBNQVJLRVItQ0hB UiBkaXJlY3RseSB0bw0KJ2RpcmVkLW1hcC1vdmVyLW1hcmtzJyBjYWxsIGlu c3RlYWQgb2YgYmluZGluZyAnZGlyZWQtbWFya2VyLWNoYXInDQphcyBiZWZv cmUuDQpGaXhlZCB0eXBvIGluIGRvYy4gc3RyaW5nLg0KKGRpcmVkLW1hcmtl ci1yZWdleHApOiBBY2NlcHQgdHdvIG9wdGlvbmFsIGFyZ3MuDQo7ICogZXRj L05FV1M6IERvY3VtZW50IHRoZSBjaGFuZ2UuDQotLS0NCiBldGMvTkVXUyAg ICAgIHwgIDUgKysrKysNCiBsaXNwL2RpcmVkLmVsIHwgMzQgKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLQ0KIDIgZmlsZXMgY2hhbmdlZCwg MjUgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1n aXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTDQppbmRleCBiNjUxYjllLi44M2Y2 NmIzIDEwMDY0NA0KLS0tIGEvZXRjL05FV1MNCisrKyBiL2V0Yy9ORVdTDQpA QCAtMTUxMiw2ICsxNTEyLDExIEBAIHByZXZpb3VzIGNvbW1hbmRzLCBgZGly ZWQtZG8tc2VhcmNoJyBhbmQNCiBrZXlzOyByZWJpbmQgYEEnIGFuZCBgUScg dG8gaW52b2tlIHRoZW0gaWYgeW91IHdhbnQgdGhlIG9sZCBiZWhhdmlvcg0K IGJhY2suICBXZSBpbnRlbmQgdG8gb2Jzb2xldGUgdGhlIG9sZCBjb21tYW5k cyBpbiBhIGZ1dHVyZSByZWxlYXNlLg0KIA0KKyoqKiBOZXcgb3B0aW9uYWwg YXJncyBNQVJLRVItQ0hBUiBhbmQgQUxMLU1BUktTIGZvcg0KK2BkaXJlZC1t YXAtb3Zlci1tYXJrcycsIGBkaXJlZC1nZXQtbWFya2VkLWZpbGVzJyBhbmQg YGRpcmVkLW1hcmtlci1yZWdleHAnDQorYWxsb3cgdG8gb3BlcmF0ZSBvdmVy IGZpbGVzIG1hcmtlZCB3aXRoIE1BUktFUi1DSEFSLCBvciBvdmVyIGFsbA0K K21hcmtlZCBmaWxlcy4NCisNCiAqKiBUYWJ1bGF0ZWQgTGlzdCBNb2RlDQog DQogKysrDQpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC5lbCBiL2xpc3AvZGly ZWQuZWwNCmluZGV4IGJmODE2NDkuLjYxOGZlYjIgMTAwNjQ0DQotLS0gYS9s aXNwL2RpcmVkLmVsDQorKysgYi9saXNwL2RpcmVkLmVsDQpAQCAtNTUzLDcg KzU1Myw3IEBAIGRpcmVkLW1hcmstaWYNCiAgICAgKGFuZCAoPiBjb3VudCAw KSBjb3VudCkpKQ0KIA0KIChkZWZtYWNybyBkaXJlZC1tYXAtb3Zlci1tYXJr cyAoYm9keSBhcmcgJm9wdGlvbmFsIHNob3ctcHJvZ3Jlc3MNCi0gICAgICAg ICAgICAgICAgICAgICBkaXN0aW5ndWlzaC1vbmUtbWFya2VkIGFsbC1tYXJr cykNCisgICAgICAgICAgICAgICAgICAgICBkaXN0aW5ndWlzaC1vbmUtbWFy a2VkIG1hcmtlci1jaGFyIGFsbC1tYXJrcykNCiAgICJFdmFsIEJPRFkgd2l0 aCBwb2ludCBvbiBlYWNoIG1hcmtlZCBsaW5lLiAgUmV0dXJuIGEgbGlzdCBv ZiBCT0RZJ3MgcmVzdWx0cy4NCiBJZiBubyBtYXJrZWQgZmlsZSBjb3VsZCBi ZSBmb3VuZCwgZXhlY3V0ZSBCT0RZIG9uIHRoZSBjdXJyZW50DQogbGluZS4g IEFSRywgaWYgbm9uLW5pbCwgc3BlY2lmaWVzIHRoZSBmaWxlcyB0byB1c2Ug aW5zdGVhZCBvZiB0aGUNCkBAIC01ODEsOCArNTgxLDExIEBAIGRpcmVkLW1h cC1vdmVyLW1hcmtzDQogSWYgRElTVElOR1VJU0gtT05FLU1BUktFRCBpcyBu b24tbmlsLCB0aGVuIGlmIHdlIGZpbmQganVzdCBvbmUNCiBtYXJrZWQgZmls ZSwgcmV0dXJuICh0IEZJTEVOQU1FKSBpbnN0ZWFkIG9mIChGSUxFTkFNRSku DQogDQorSWYgTUFSS0VSLUNIQVIgaXMgbm9uLW5pbCwgdGhlbiBpdCBpcyB0 aGUgbWFyaw0KK2NoYXJhY3RlciB0byBzZWFyY2guICBPdGhlcndpc2UgdXNl IGBkaXJlZC1tYXJrZXItY2hhcicuDQorDQogSWYgQUxMLU1BUktTIGlzIG5v bi1uaWwsIGFjY2VwdCBhbGwgbWFyayBjaGFyYWN0ZXJzLiAgT3RoZXJ3aXNl IHVzZQ0KLWp1c3QgYGRpcmVkLW1hcmtlci1jaGFyJy4iDQoranVzdCBNQVJL RVItQ0hBUi4iDQogICA7Ow0KICAgOztXYXJuaW5nOiBCT0RZIG11c3Qgbm90 IGFkZCBuZXcgbGluZXMgYmVmb3JlIHBvaW50IC0gdGhpcyBtYXkgY2F1c2Ug YW4NCiAgIDs7ZW5kbGVzcyBsb29wLg0KQEAgLTYwMiw3ICs2MDUsOCBAQCBk aXJlZC1tYXAtb3Zlci1tYXJrcw0KICAgICAgICAgICAgICByZXN1bHRzKSkN CiAgICAgICAgICAgIDs7IG5vbi1uaWwsIG5vbi1pbnRlZ2VyIEFSRyBtZWFu cyB1c2UgY3VycmVudCBmaWxlOg0KICAgICAgICAgICAgKGxpc3QgLGJvZHkp KQ0KLSAgICAgICAobGV0ICgocmVnZXhwIChkaXJlZC1tYXJrZXItcmVnZXhw ICxhbGwtbWFya3MpKSBuZXh0LXBvc2l0aW9uKQ0KKyAgICAgICAobGV0ICgo cmVnZXhwIChkaXJlZC1tYXJrZXItcmVnZXhwICxtYXJrZXItY2hhciAsYWxs LW1hcmtzKSkNCisgICAgICAgICAgICAgbmV4dC1wb3NpdGlvbikNCiAgICAg ICAgICAoc2F2ZS1leGN1cnNpb24NCiAgICAgICAgICAgIChnb3RvLWNoYXIg KHBvaW50LW1pbikpDQogICAgICAgICAgICA7OyByZW1lbWJlciBwb3NpdGlv biBvZiBuZXh0IG1hcmtlZCBmaWxlIGJlZm9yZSBCT0RZDQpAQCAtNjMzLDcg KzYzNyw3IEBAIGRpcmVkLW1hcC1vdmVyLW1hcmtzDQogKGRlZnVuIGRpcmVk LWdldC1tYXJrZWQtZmlsZXMgKCZvcHRpb25hbCBsb2NhbHAgYXJnIGZpbHRl cg0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGlzdGluZ3Vpc2gtb25lLW1hcmtlZA0KICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbWFya2VyLWNoYXIgYWxsLW1hcmtzKQ0K LSAgIlJldHVybiB0aGUgbWFya2VkIGZpbGVzJyBuYW1lcyBhcyBsaXN0IG9m IHN0cmluZ3MuDQorICAiUmV0dXJuIHRoZSBtYXJrZWQgZmlsZXMgbmFtZXMg YXMgYSBsaXN0IG9mIHN0cmluZ3MuDQogVGhlIGxpc3QgaXMgaW4gdGhlIHNh bWUgb3JkZXIgYXMgdGhlIGJ1ZmZlciwgdGhhdCBpcywgdGhlIGNhciBpcyB0 aGUNCiAgIGZpcnN0IG1hcmtlZCBmaWxlLg0KIFZhbHVlcyByZXR1cm5lZCBh cmUgbm9ybWFsbHkgYWJzb2x1dGUgZmlsZSBuYW1lcy4NCkBAIC02NTYsMTMg KzY2MCwxMiBAQCBkaXJlZC1nZXQtbWFya2VkLWZpbGVzDQogDQogT3B0aW9u YWwgYXJnIEFMTC1NQVJLUywgaWYgbm9uLW5pbCwgdGhlbiBhY2NlcHQgYWxs IG1hcmsgY2hhcmFjdGVycy4NCiBPdGhlcndpc2UgdXNlIGp1c3QgTUFSS0VS LUNIQVIuIg0KLSAgKGxldCogKChkaXJlZC1tYXJrZXItY2hhciAob3IgbWFy a2VyLWNoYXIgZGlyZWQtbWFya2VyLWNoYXIpKQ0KLSAgICAgICAgIChhbGwt b2YtdGhlbQ0KLSAgICAgICAgICAoc2F2ZS1leGN1cnNpb24NCi0gICAgICAg ICAgICAoZGVscSBuaWwgKGRpcmVkLW1hcC1vdmVyLW1hcmtzDQotICAgICAg ICAgICAgICAgICAgICAgICAoZGlyZWQtZ2V0LWZpbGVuYW1lIGxvY2FscCAn bm8tZXJyb3ItaWYtbm90LWZpbGVwKQ0KLSAgICAgICAgICAgICAgICAgICAg ICAgYXJnIG5pbCBkaXN0aW5ndWlzaC1vbmUtbWFya2VkIGFsbC1tYXJrcykp KSkNCi0gICAgICAgICByZXN1bHQpDQorICAobGV0ICgoYWxsLW9mLXRoZW0N CisgICAgICAgICAoc2F2ZS1leGN1cnNpb24NCisgICAgICAgICAgIChkZWxx IG5pbCAoZGlyZWQtbWFwLW92ZXItbWFya3MNCisgICAgICAgICAgICAgICAg ICAgICAgKGRpcmVkLWdldC1maWxlbmFtZSBsb2NhbHAgJ25vLWVycm9yLWlm LW5vdC1maWxlcCkNCisgICAgICAgICAgICAgICAgICAgICAgYXJnIG5pbCBk aXN0aW5ndWlzaC1vbmUtbWFya2VkIG1hcmtlci1jaGFyIGFsbC1tYXJrcykp KSkNCisgICAgICAgIHJlc3VsdCkNCiAgICAgKHdoZW4gKGVxdWFsIGFsbC1v Zi10aGVtICcodCkpDQogICAgICAgKHNldHEgYWxsLW9mLXRoZW0gbmlsKSkN CiAgICAgKGlmIChub3QgZmlsdGVyKQ0KQEAgLTMwNDMsMTMgKzMwNDYsMTYg QEAgZGlyZWQtY2xlYW4tdXAtYWZ0ZXItZGVsZXRpb24NCiAMDQogOzsgQ29u ZmlybWF0aW9uDQogDQotKGRlZnVuIGRpcmVkLW1hcmtlci1yZWdleHAgKCZv cHRpb25hbCBhbGwtbWFya3MpDQorKGRlZnVuIGRpcmVkLW1hcmtlci1yZWdl eHAgKCZvcHRpb25hbCBtYXJrZXItY2hhciBhbGwtbWFya3MpDQogICAiUmV0 dXJuIGEgcmVnZXhwIG1hdGNoaW5nIGBkaXJlZC1tYXJrZXItY2hhcicgYXQg dGhlIGJlZ2lubmluZyBvZiBsaW5lLg0KLUlmIG9wdGlvbmFsIGFyZ3VtZW50 IEFMTC1NQVJLUyBldmFsdWF0ZXMgdG8gbm9uLW5pbCwgdGhlIHJlZ2V4cA0K K0lmIE1BUktFUi1DSEFSIGV2YWx1YXRlcyBub24tbmlsLCB0aGVuIHRoZSBy ZWdleHAgbWF0Y2hlcyBNQVJLRVItQ0hBUg0KK2luc3RlYWQgb2YgYGRpcmVk LW1hcmtlci1jaGFyJy4NCitJZiBvcHRpb25hbCBhcmd1bWVudCBBTEwtTUFS S1MgZXZhbHVhdGVzIHRvIG5vbi1uaWwsIHRoZW4gdGhlIHJlZ2V4cA0KIG1h dGNoZXMgYW55IG1hcmsgY2hhcmFjdGVyLiINCiAgIChpZiBhbGwtbWFya3MN CiAgICAgICAiXlteXHQgXSINCi0gICAgKGNvbmNhdCAiXiIgKHJlZ2V4cC1x dW90ZSAoY2hhci10by1zdHJpbmcgZGlyZWQtbWFya2VyLWNoYXIpKSkpKQ0K KyAgICAoY29uY2F0ICJeIiAocmVnZXhwLXF1b3RlIChjaGFyLXRvLXN0cmlu ZyAob3IgbWFya2VyLWNoYXINCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLW1hcmtlci1jaGFyKSkp KSkpDQogDQogKGRlZnVuIGRpcmVkLXBsdXJhbC1zIChjb3VudCkNCiAgIChp ZiAoPSAxIGNvdW50KSAiIiAicyIpKQ0KLS0gDQoyLjcuMA0KDQo= --1468197610-844313517-1457583550=:23082--