From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#22894: 25.1.50; dired-mark: Not remark a marked file Date: Sat, 5 Mar 2016 22:41:18 +0900 (JST) Message-ID: References: <87r3fql90m.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1457185158 4353 80.91.229.3 (5 Mar 2016 13:39:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Mar 2016 13:39:18 +0000 (UTC) To: 22894@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 05 14:39:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acCQH-0005pc-VS for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Mar 2016 14:39:10 +0100 Original-Received: from localhost ([::1]:46552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acCQH-0008V1-5G for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Mar 2016 08:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acCQD-0008UQ-54 for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2016 08:39:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acCQ9-0002az-Td for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2016 08:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acCQ9-0002av-R7 for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2016 08:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1acCQ9-0002H7-K7 for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2016 08:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Mar 2016 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22894 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22894-submit@debbugs.gnu.org id=B22894.14571850918686 (code B ref 22894); Sat, 05 Mar 2016 13:39:01 +0000 Original-Received: (at 22894) by debbugs.gnu.org; 5 Mar 2016 13:38:11 +0000 Original-Received: from localhost ([127.0.0.1]:34363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acCPL-0002G2-FM for submit@debbugs.gnu.org; Sat, 05 Mar 2016 08:38:11 -0500 Original-Received: from calancha-ilc.kek.jp ([130.87.234.234]:57599) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acCPJ-0002Fk-Fs for 22894@debbugs.gnu.org; Sat, 05 Mar 2016 08:38:10 -0500 Original-Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 92794DA83; Sat, 5 Mar 2016 22:41:18 +0900 (JST) Original-Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 784EE54C0 for <22894@debbugs.gnu.org>; Sat, 5 Mar 2016 22:41:18 +0900 (JST) X-X-Sender: calancha@calancha-ilc.kek.jp In-Reply-To: <87r3fql90m.fsf@gnus.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114449 Archived-At: > You're right. :-) I think if the user tries to change the marks in a > region, then the marks in the region should be changed. So I'm not sure > I understand the use case at all... User can change the marks with: 1) `dired-change-marks': this is, IMO, the recommended way: you control what you want to change, let's say, the mark 'F' into the mark 'G'. 2) Calling `dired-mark-files-regexp': the patch does't prevent this function changing mark 'F' into `dired-marker-char'. 3) Calling `dired-flag-file-deletion', that is, changing from mark 'F' to 'D' (that is what i called before 1) in previous comunication). 4) In two steps: unmarking the file, and after that marking it. What i am trying to prevent is related with `dired-mark' and `dired-mark-files-in-region'. The former is bound to 'm'. I can imagine someone, keeping push the 'm' button to mark a bunch of files, and releasing such button one fraction of seocnd late, so one marked file with 'F' get remarked by `dired-marker-char'. Similar thing could happen if using the second function setting the region not very carefully (pick uping one additional file up/down in the region). The patch just prevent in this two function, one marked file be remarked. Those files still not marked are marked. I am against to restrict users, and i understand this thread is controversial, but i use a lot these features and i believe it could prevent people (including me) doing unintentional changes.