unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <f92capac@gmail.com>
To: 22894@debbugs.gnu.org
Subject: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Sat, 5 Mar 2016 22:41:18 +0900 (JST)	[thread overview]
Message-ID: <alpine.LRH.2.20.1603052220450.3772@calancha-ilc.kek.jp> (raw)
In-Reply-To: <87r3fql90m.fsf@gnus.org>


> You're right.  :-)  I think if the user tries to change the marks in a
> region, then the marks in the region should be changed.  So I'm not sure
> I understand the use case at all...
User can change the marks with:
1) `dired-change-marks': this is, IMO, the recommended way: you control 
what you want to change, let's say, the mark 'F' into the mark 'G'.
2) Calling `dired-mark-files-regexp': the patch does't prevent this 
function changing mark 'F' into `dired-marker-char'.
3) Calling `dired-flag-file-deletion', that is, changing from mark 'F'
to 'D' (that is what i called before 1) in previous comunication).
4) In two steps: unmarking the file, and after that marking it.

What i am trying to prevent is related with `dired-mark' and 
`dired-mark-files-in-region'. The former is bound to 'm'. I can imagine
someone, keeping push the 'm' button to mark a bunch of files, and 
releasing such button one fraction of seocnd late, so one marked file with
'F' get remarked by `dired-marker-char'.
Similar thing could happen if using the second function setting the region 
not very carefully (pick uping one additional file up/down in the region).

The patch just prevent in this two function, one marked file be remarked. 
Those files still not marked are marked.

I am against to restrict users, and i understand this thread is 
controversial, but i use a lot these features and i believe it could
prevent people (including me) doing unintentional changes.





  reply	other threads:[~2016-03-05 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 10:09 bug#22894: 25.1.50; dired-mark: Not remark a marked file Tino Calancha
2016-03-04 12:31 ` Lars Ingebrigtsen
2016-03-05 13:41   ` Tino Calancha [this message]
2016-03-05 18:59     ` Drew Adams
2016-03-05 14:06   ` Tino Calancha
2016-07-01  3:22     ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.20.1603052220450.3772@calancha-ilc.kek.jp \
    --to=f92capac@gmail.com \
    --cc=22894@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).