From: Tino Calancha <f92capac@gmail.com>
To: 21663@debbugs.gnu.org
Cc: Tino Calancha <f92capac@gmail.com>
Subject: bug#21663: 25.0.50; isearch-edit-string dont resume multi isearches
Date: Tue, 13 Oct 2015 14:18:25 +0900 (JST) [thread overview]
Message-ID: <alpine.LRH.2.20.1510131416330.28366@calancha-ilc.kek.jp> (raw)
In-Reply-To: <handler.21663.B.144453929427612.ack@debbugs.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
In previous patch (isearch_3.patch) the variables are not
restored because they were bind to the same symbol name, and
multi-isearch-end will set them to nil.
In addition, multi-isearch-end need to be added again to
isearch-mode-end-hook, otherwise, even after exiting with C-g, C-s will
start a multisearch instead of a normal isearch in the current buffer.
See attached patch: isearch_4.patch
[-- Attachment #2: Type: text/plain, Size: 2034 bytes --]
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 4fc9b38..617f3e7 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -1242,6 +1242,15 @@ with-isearch-suspended
(isearch-adjusted isearch-adjusted)
(isearch-yank-flag isearch-yank-flag)
(isearch-error isearch-error)
+ ;; multi isearch variables
+ (is-multi-isearch (or multi-isearch-buffer-list multi-isearch-file-list))
+ (multi-isearch-file-list-new multi-isearch-file-list)
+ (multi-isearch-buffer-list-new multi-isearch-buffer-list)
+ (multi-isearch-next-buffer-current-function-new multi-isearch-next-buffer-current-function)
+ (multi-isearch-current-buffer-new multi-isearch-current-buffer)
+ (isearch-push-state-function isearch-push-state-function)
+ (isearch-wrap-function isearch-wrap-function)
+ (isearch-search-fun-function isearch-search-fun-function)
;;; Don't bind this. We want isearch-search, below, to set it.
;;; And the old value won't matter after that.
;;; (isearch-other-end isearch-other-end)
@@ -1298,12 +1307,17 @@ with-isearch-suspended
nil
isearch-word)
+ (when is-multi-isearch (add-hook 'isearch-mode-end-hook 'multi-isearch-end))
;; Copy new local values to isearch globals
(setq isearch-string isearch-new-string
isearch-message isearch-new-message
isearch-forward isearch-new-forward
isearch-word isearch-new-word
- isearch-case-fold-search isearch-new-case-fold))
+ isearch-case-fold-search isearch-new-case-fold
+ multi-isearch-file-list multi-isearch-file-list-new
+ multi-isearch-buffer-list multi-isearch-buffer-list-new
+ multi-isearch-current-buffer multi-isearch-current-buffer-new
+ multi-isearch-next-buffer-current-function multi-isearch-next-buffer-current-function-new))
;; Empty isearch-string means use default.
(when (= 0 (length isearch-string))
next prev parent reply other threads:[~2015-10-13 5:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 4:57 bug#21663: Subject: 25.0.50; isearch-edit-string dont resume multi isearches Tino Calancha
[not found] ` <handler.21663.B.144453929427612.ack@debbugs.gnu.org>
2015-10-12 15:25 ` bug#21663: 25.0.50; isearch-edit-string dont resume multi-isearch-files Tino Calancha
2015-10-12 20:17 ` Juri Linkov
2015-10-13 1:35 ` Tino Calancha
2015-10-13 5:18 ` Tino Calancha [this message]
2015-10-13 22:04 ` bug#21663: 25.0.50; isearch-edit-string dont resume multi isearches Juri Linkov
2015-10-14 6:48 ` Tino Calancha
2015-10-14 16:17 ` Juri Linkov
-- strict thread matches above, loose matches on Subject: below --
2015-10-14 13:26 bug#21684: 25.0.50; undo in query-replace w/o exit Tino Calancha
2015-10-14 16:23 ` Juri Linkov
2015-10-17 13:04 ` Tino Calancha
2015-10-17 21:49 ` Juri Linkov
2015-10-18 9:45 ` Tino Calancha
2015-10-18 15:58 ` Richard Stallman
2015-10-19 1:20 ` Tino Calancha
2015-10-19 22:04 ` Juri Linkov
2015-10-20 12:02 ` Tino Calancha
2016-02-23 8:40 ` Lars Ingebrigtsen
2016-02-23 16:46 ` Tino Calancha
2016-02-24 1:36 ` Lars Ingebrigtsen
2016-05-31 22:32 ` Glenn Morris
2016-06-04 22:06 ` bug#21663: 25.0.50; isearch-edit-string dont resume multi isearches Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1510131416330.28366@calancha-ilc.kek.jp \
--to=f92capac@gmail.com \
--cc=21663@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).