From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#21663: 25.0.50; isearch-edit-string dont resume multi-isearch-files Date: Tue, 13 Oct 2015 10:35:31 +0900 (JST) Message-ID: References: <87io6b6dva.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-194859354-1444700131=:27198" X-Trace: ger.gmane.org 1444700000 21351 80.91.229.3 (13 Oct 2015 01:33:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 01:33:20 +0000 (UTC) Cc: Tino Calancha To: 21663@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 13 03:33:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZloSk-0006mF-GX for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Oct 2015 03:33:10 +0200 Original-Received: from localhost ([::1]:59885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZloSj-00057U-53 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Oct 2015 21:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZloSg-000579-Ah for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 21:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZloSd-00079f-3w for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 21:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZloSd-00079b-0A for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 21:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZloSc-0004k9-NY for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2015 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2015 01:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21663-submit@debbugs.gnu.org id=B21663.144469994718191 (code B ref 21663); Tue, 13 Oct 2015 01:33:02 +0000 Original-Received: (at 21663) by debbugs.gnu.org; 13 Oct 2015 01:32:27 +0000 Original-Received: from localhost ([127.0.0.1]:37617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZloS2-0004jJ-LT for submit@debbugs.gnu.org; Mon, 12 Oct 2015 21:32:26 -0400 Original-Received: from calancha-ilc.kek.jp ([130.87.234.234]:58242) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZloRz-0004j7-Eu for 21663@debbugs.gnu.org; Mon, 12 Oct 2015 21:32:24 -0400 Original-Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 3215C8648; Tue, 13 Oct 2015 10:35:31 +0900 (JST) Original-Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 238AA85F1; Tue, 13 Oct 2015 10:35:31 +0900 (JST) X-X-Sender: calancha@calancha-ilc.kek.jp In-Reply-To: <87io6b6dva.fsf@mail.linkov.net> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107554 Archived-At: --1468197610-194859354-1444700131=:27198 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT > I wonder why ‘isearch-mode-end-hook-quit’ is not initialized as > ‘(and nopush edit)’ in the first place? If it was so, then > you could just check for it in ‘multi-isearch-end’. My understanding about that variable (i may be wrong) is that is should be non nil just when the user quit the search with C-g we dont want this variable being non nil in the case of editing the string with the idea to resume the same kind of search. > have you tried to re-initialize multi-isearch on resuming isearch > after exiting from the minibuffer? (This could be achieved by > remembering its state variables). I like your proposal: this way is more consistent with the original code. See attached new patch. --1468197610-194859354-1444700131=:27198 Content-Type: text/plain; charset=US-ASCII; name=isearch_3.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=isearch_3.patch ZGlmZiAtLWdpdCBhL2xpc3AvaXNlYXJjaC5lbCBiL2xpc3AvaXNlYXJjaC5l bA0KaW5kZXggNGZjOWIzOC4uNzRiMTI1MCAxMDA2NDQNCi0tLSBhL2xpc3Av aXNlYXJjaC5lbA0KKysrIGIvbGlzcC9pc2VhcmNoLmVsDQpAQCAtMTI0Miw2 ICsxMjQyLDE0IEBAIHdpdGgtaXNlYXJjaC1zdXNwZW5kZWQNCiAJICAgICAg KGlzZWFyY2gtYWRqdXN0ZWQgaXNlYXJjaC1hZGp1c3RlZCkNCiAJICAgICAg KGlzZWFyY2gteWFuay1mbGFnIGlzZWFyY2gteWFuay1mbGFnKQ0KIAkgICAg ICAoaXNlYXJjaC1lcnJvciBpc2VhcmNoLWVycm9yKQ0KKyAgICAgICAgICAg ICAgOzsgIG11bHRpIGlzZWFyY2ggdmFyaWFibGVzDQorCSAgICAgIChtdWx0 aS1pc2VhcmNoLWZpbGUtbGlzdCBtdWx0aS1pc2VhcmNoLWZpbGUtbGlzdCkN CisJICAgICAgKG11bHRpLWlzZWFyY2gtYnVmZmVyLWxpc3QgbXVsdGktaXNl YXJjaC1idWZmZXItbGlzdCkNCisJICAgICAgKG11bHRpLWlzZWFyY2gtbmV4 dC1idWZmZXItY3VycmVudC1mdW5jdGlvbiBtdWx0aS1pc2VhcmNoLW5leHQt YnVmZmVyLWN1cnJlbnQtZnVuY3Rpb24pDQorCSAgICAgIChtdWx0aS1pc2Vh cmNoLWN1cnJlbnQtYnVmZmVyIG11bHRpLWlzZWFyY2gtY3VycmVudC1idWZm ZXIpDQorCSAgICAgIChpc2VhcmNoLXB1c2gtc3RhdGUtZnVuY3Rpb24gaXNl YXJjaC1wdXNoLXN0YXRlLWZ1bmN0aW9uKQ0KKwkgICAgICAoaXNlYXJjaC13 cmFwLWZ1bmN0aW9uIGlzZWFyY2gtd3JhcC1mdW5jdGlvbikNCisJICAgICAg KGlzZWFyY2gtc2VhcmNoLWZ1bi1mdW5jdGlvbiBpc2VhcmNoLXNlYXJjaC1m dW4tZnVuY3Rpb24pDQogICA7OzsgRG9uJ3QgYmluZCB0aGlzLiAgV2Ugd2Fu dCBpc2VhcmNoLXNlYXJjaCwgYmVsb3csIHRvIHNldCBpdC4NCiAgIDs7OyBB bmQgdGhlIG9sZCB2YWx1ZSB3b24ndCBtYXR0ZXIgYWZ0ZXIgdGhhdC4NCiAg IDs7OwkgICAgKGlzZWFyY2gtb3RoZXItZW5kIGlzZWFyY2gtb3RoZXItZW5k KQ0K --1468197610-194859354-1444700131=:27198--