From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore Date: Thu, 10 May 2018 11:13:44 +0900 (JST) Message-ID: References: <87a7wxd1g9.fsf@mail.linkov.net> <83607kinmx.fsf@gnu.org> <877erz41re.fsf@tcd.ie> <87zi4tu2ic.fsf@mail.linkov.net> <83lggbd661.fsf@gnu.org> <87tvuyqhz8.fsf@tcd.ie> <87tvuxojag.fsf@mail.linkov.net> <874ljkn4fb.fsf@tcd.ie> <87zi1budeg.fsf@gmail.com> <87zi1911tg.fsf@tcd.ie> <87r2mlszhx.fsf@gmail.com> <87lgcs1y4a.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1609083803-1525918427=:27615" X-Trace: blaine.gmane.org 1525918613 14617 195.159.176.226 (10 May 2018 02:16:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 10 May 2018 02:16:53 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 30280@debbugs.gnu.org, rrt@sc3d.org, Tino Calancha , Noam Postavsky , Juri Linkov To: contovob@tcd.ie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 10 04:16:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGb8P-0003bW-60 for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 May 2018 04:16:45 +0200 Original-Received: from localhost ([::1]:59819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGbAW-0003D2-3Z for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 May 2018 22:18:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGb5r-0007UO-5B for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 22:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGb5m-00008j-5G for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 22:14:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGb5m-00008Y-2T for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 22:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fGb5l-0001tO-Oy for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 22:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 May 2018 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30280-submit@debbugs.gnu.org id=B30280.15259184377257 (code B ref 30280); Thu, 10 May 2018 02:14:01 +0000 Original-Received: (at 30280) by debbugs.gnu.org; 10 May 2018 02:13:57 +0000 Original-Received: from localhost ([127.0.0.1]:55788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGb5g-0001sz-Ss for submit@debbugs.gnu.org; Wed, 09 May 2018 22:13:57 -0400 Original-Received: from mail-pl0-f50.google.com ([209.85.160.50]:42439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGb5e-0001sm-TR for 30280@debbugs.gnu.org; Wed, 09 May 2018 22:13:55 -0400 Original-Received: by mail-pl0-f50.google.com with SMTP id u6-v6so358016pls.9 for <30280@debbugs.gnu.org>; Wed, 09 May 2018 19:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=wKkOIh64kJYHgWxNQTEWeCPiaYF57Imey55DZ7NVIOI=; b=Do+z40Rd/isBdX4sF3UkFOtghOAGawQExhnheIZOtJwLHr1rzmM8257KS8GsIBEk8z EZqbjkIRNcm71XYjo2NOJRRkQnwU1XojP6zA6zdi6PG7QvNAMoXLyoEjlfIlgJqjs39a AEPalg4xmcYRY7QQa0vwdIYWRb1TdEwWNhasme2/1lmd25jz0W85gM+EdzIQr2juWTC2 MY4dM5kufBGg+d68jlTy9kP3MOQfJfjTyXwjrDEJkElzOnhVXHHf4XUog4NZYPOgtOv0 /+taEfzwJdM7CM79Kq9433gaMpj7Tsp66P88YlYlGAbLfueU6A5ZcxvNycDteA4Ksch4 Yd+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=wKkOIh64kJYHgWxNQTEWeCPiaYF57Imey55DZ7NVIOI=; b=gJSA/7bZXbgJKVFdnYlRjN7hrcvVBtHJMSBKBnnfpm7Dl78NSFF4OfEui6+DQjUbcd s0NK7K4RgmclR6qRQqit8NFNRboWCXiuOJQDaIYDTGAtUE+HE746H9xnWGfLOSIl9C7P 0hSOoZyG6lS7kKlf+s3pCe7j2SU32c2FX6VQBqJRV9R/aUzMBioPHWGIHYeccv0+breq q+ntRiRvtayoTwTNSZabL3cM8L1egXd47/PfhAn/RWgK+CDYIw1voOn8EODgotBiTouy n9VRgTiQE2cOazmahR83/bcolcIEcOmYCaY9rkh87Jk0aOdUoC0Q3HmGsKqqF0zlBehU gYsw== X-Gm-Message-State: ALQs6tBTs3w0LXKLInUSs19gcXshxjRJ3C2isAr1uAYRkOPB0dY6mV+l iSHH6wXOGBl++DgE3dEe15E= X-Google-Smtp-Source: AB8JxZrwa5uYD2x4S83uFIGhNxtpqKYaG6IqrCK1H4IV7N6jYA6/ezxvIs9fnFI7GzGVhtnti/qd5A== X-Received: by 2002:a17:902:1aa:: with SMTP id b39-v6mr47811768plb.120.1525918428893; Wed, 09 May 2018 19:13:48 -0700 (PDT) Original-Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id p71sm65368275pfl.170.2018.05.09.19.13.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 19:13:47 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87lgcs1y4a.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146100 Archived-At: --8323329-1609083803-1525918427=:27615 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Thank you Basil for your prompt response! Your patches LGTM. Let's wait few more days if some people want to make further comments. Otherwise, I will push them in your name into the master branch. On Wed, 9 May 2018, Basil L. Contovounesios wrote: >> I) >>> +(declare-function comint-output-filter "comint" (process string)) >>> + >> What is the purpose of this? AFICT no warning is shown when compiling >> the file. > > On my end, removing the function declaration and invoking 'make' results > in the following output: > > ... > make[2]: Entering directory '/home/blc/.local/src/emacs/lisp' > ELC ../lisp/simple.elc > Reloading stale loaddefs.el > Loading /home/blc/.local/src/emacs/lisp/loaddefs.el (source)... > > In end of data: > simple.el:9030:1:Warning: the function ‘comint-output-filter’ is not known to > be defined. > ... > > Note that this warning is only emitted when comint-output-filter is > #'-quoted. This is in line with the usual behaviour of the > byte-compiler that I am accustomed to, i.e. I don't see anything out of > the ordinary here. Oh, I see. I overlooked the fact that we changed `quote' with `function'. With: make bootstrap there is no warning. I am OK with clearing the warning in all cases. >> * We require `shell.el' inside `shell-coomand'. >> * `shell.el' requires `comint.el'. > > Yes, I understand that using comint-output-filter at this point in the > program is kosher, but the byte-compiler evidently does not. > >> Is the purpose to serve as documentation? In that case I don't think we >> need it (the prefix 'comint-' already makes obvious where this function >> belongs to). > > No, the only intention is to pacify the byte-compiler. > >> II) >> It's better to keep consistent with the indentation of the function you >> are modifying: here, `shell-command' is indenting with TAB. >> >> Tip: >> You can see the tabs searching them with: >> C-s C-q C-I >> or you can persistenly highlight them with: >> M-s h r C-I RET RET > > Thanks for the tip. I personally prefer to use [global-]whitespace-mode > with a whitespace-style setting which includes (face tab-mark). > I additionally avoid accidentally committing tabs by configuring the git > option core.whitespace to include tab-in-indent. > >> For instance, here you are changing: >> 1) ' ---> #' >> ;; and >> 2) \t\t\s\s 000> \s\s\s\s...\s (18 white spaces) >> >> Please, do not change 2). > > I have no strong feeling on this; I was merely going along with the > (emacs-lisp-mode . ((indent-tabs-mode . nil))) setting in the project's > toplevel dir-locals-file, as well what I had inferred to be accepted > policy (as Noam mentions in a separate email) from following Emacs > development for the last couple of years. > > If it weren't for the above and the fact that most everything I have > come across in the Emacs tree has Frankindentation (including the target > function shell-command), I would be more inclined to remain consistent > with the surrounding source. > > Let me know if it's still a problem and I'll gladly resend the patches > with indent-tabs-mode enabled. It's OK, Frankenstein is a glorious novel after all; I recommend anyone to revisit such classical masterpiece :-) --8323329-1609083803-1525918427=:27615--