From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Sun, 11 Mar 2018 20:02:08 +0900 (JST) Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> <83y3j0t9qs.fsf@gnu.org> <87woykoysm.fsf@gmail.com> <83sh98szdy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1520766076 28291 195.159.176.226 (11 Mar 2018 11:01:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2018 11:01:16 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 30190@debbugs.gnu.org, Tino Calancha , rms@gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 11 12:01:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyiz-0007Bw-UY for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2018 12:01:10 +0100 Original-Received: from localhost ([::1]:53787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euyl2-0002fH-HP for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Mar 2018 07:03:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euyks-0002ez-FQ for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euyko-0002j3-Gu for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:03:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46811) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euyko-0002ir-D1 for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euyko-0000qN-1s for bug-gnu-emacs@gnu.org; Sun, 11 Mar 2018 07:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Mar 2018 11:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.15207661403179 (code B ref 30190); Sun, 11 Mar 2018 11:03:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 11 Mar 2018 11:02:20 +0000 Original-Received: from localhost ([127.0.0.1]:54708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyk7-0000pD-Vb for submit@debbugs.gnu.org; Sun, 11 Mar 2018 07:02:20 -0400 Original-Received: from mail-pf0-f174.google.com ([209.85.192.174]:36458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euyk6-0000oz-KH for 30190@debbugs.gnu.org; Sun, 11 Mar 2018 07:02:18 -0400 Original-Received: by mail-pf0-f174.google.com with SMTP id 68so3143775pfx.3 for <30190@debbugs.gnu.org>; Sun, 11 Mar 2018 04:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=XxW5i3SLvp4kiYzuDHmzPFaMTv3l1dkYB5pUtYNFmAk=; b=ZJqEwhpDm6y/ef3ATWWl3RraWMAWy7zcEQp+HEAy/EIyVUXtwKPaWsEzBVEyEZYMy+ Az8TU/wSbWthW1xhwAfzpdUtmKcdFotRmBxJrFJ/l954hB1F/WlSzJaQh2aRjg11lbMJ WwVPIaVwWyFxIj+Uspp2A02EXS+udDR1VhkizBADqDh2y+ueengnEk4Y6e0mhT0OuUxG kYMRC/z2vGIxGieX29fvKu4lUfdWZKOsAobkF5IKn8FpIlMfE/mbJ2YxHspbHeYYhl6S wgew06hcqd5CQpjBOPDRoOvOmi1TSpwGymSPghTJ6+yT0rOyn7YtypbpmgsNknVcMDbw 7wTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=XxW5i3SLvp4kiYzuDHmzPFaMTv3l1dkYB5pUtYNFmAk=; b=Oo7FgkYxR7+Y+YS2DvxyorbkJXU1e/ddhQdKJO4TDe3myj088mhCwYwAEZC/fqt38M qG0xvngNEc0hZQa1yk724lAcsvCZMyEXxtSRYaKPf5qghf0BaeasqMTAxQQt98QYufA/ 8CXQg5CStvzwrLfhYOjV+OLr7e/CGiV0zyEFj9RewcuvXmIS1UAOMey0/Er++nO32oJj DqGbGaT79c4A8ezfwsruno+wxWou3vbpy+jQJCS5x6BpZ5KMqmRYfMWGQWoQpbwbEia8 +fA82kEiExGs/NdEmWrIItODk0cslDHIhwY/TfuDH56kjnparvb18OHGlSXfGNwnlvKn SV/A== X-Gm-Message-State: AElRT7HhqTDrDxf2StEtiKakEiYMjd7pFAoettJ6tLIulb1Ub3zeF0Kd vNm2Uy8+dRTJkaBnsd42dvc= X-Google-Smtp-Source: AG47ELs5XLZBACqZhDPKOvXvqvBIfmE5o8EpWpAYiDlihHeI+0c1rhkxZ52Q7c5YzvVvlmZdwFTysQ== X-Received: by 10.98.162.26 with SMTP id m26mr4451112pff.217.1520766132643; Sun, 11 Mar 2018 04:02:12 -0700 (PDT) Original-Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id l129sm12135823pfl.82.2018.03.11.04.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 04:02:11 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83sh98szdy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144124 Archived-At: On Sat, 10 Mar 2018, Eli Zaretskii wrote: >> From: Tino Calancha >> Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net >> Date: Sat, 10 Mar 2018 22:17:13 +0900 >> >> Bad behaviour: >> [sudo] password for foo: >> # This throws 'command not found' BUT _sometimes_ you are prompted for >> # your password in the minibuffer. >> # Note: This happens in a dumb shell buffer as well. > > What happens if you have a command (say, a shell script) that prompts > for something that is not a password with a prompt that starts with > text that matches the regexp -- what is the behavior then, after your > changes? What I see here is that the filter redirects that to the > minibuffer, and doesn't show the text I type, unlike what happened > before your changes. Wouldn't that look like a bug and cause bug > reports? IMO, if the regexp is matched, then you must be prompt in the minibuffer. It is the responsability of the person writing the script to chose sensible variable names, and right prompts. If I am prompted and I expect I shouldn't, then what is happening is that I wrote a poor script. > I'm also worried by the "_sometimes_" part: does it mean the behavior > is not deterministic? Why? This is not crafted from me; it how it's designed in comint.el. It must mean that the long strings are send in chunks. That would be a totally independent bug report. Actually if it's a bug or not is arguable: don't think it is, at least until we canot fire it in a more sensical example that the toy string: [sudo] password for: >> Whatever misfunction of my patch should happen in a dumb shell buffer >> started with: >> M-x shell > > Yes, but two wrongs don't make a right... There levels of wrongs: showing a password is simply too wrong. And 2 wrongs, sharing same code give more testers, i.e., more chances to detect the anomaly to finally fix it. Anyway I already have patched my local sources and I am happy with that. I don't have time to argue further, so I give up. My team is pushing me to focus in our project.