From: Tino Calancha <tino.calancha@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 28631@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection
Date: Sat, 14 Oct 2017 10:42:15 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710141030010.31750@calancha-pc> (raw)
In-Reply-To: <87y3of9nrn.fsf@users.sourceforge.net>
On Fri, 13 Oct 2017, Noam Postavsky wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> ((and (/= (region-beginning) (region-end))
>>> (or (gui-backend-selection-owner-p 'PRIMARY)
>>> - (null (gui-backend-selection-exists-p 'PRIMARY))))
>>> + (null (gui-backend-selection-exists-p 'PRIMARY)))
>>> + ;; `winner-undo' shouldn't update the selection (Bug#28631).
>>> + (not (eq this-command 'winner-undo)))
>>> (gui-set-selection 'PRIMARY
>>> (funcall region-extract-function nil)))))
>
>> Is there really no way to solve this in winner? It seems like a
>> winner bug/misfeature, and I'm worried by the possible effect of this
>> patch on use cases that have nothing to do with the specific scenario
>> of this bug. deactivate-mark is used a lot in places and ways we
>> cannot possibly predict.
>
> That patch only has affect during winner-undo, no?
I think so.
>> + ;; `winner-undo' shouldn't update the selection (Bug#28631) when
>> + ;; select-enable-primary is non-nil.
>> + (unless select-enable-primary
>> + (save-current-buffer
>> + (cl-loop for buf in buffers
>> + for entry = (cadr (assq buf winner-point-alist))
>> + do (progn (set-buffer buf)
>> + (set-mark (car entry))
>> + (setf (winner-active-region) (cdr entry))))))
>
> Maybe only the (setf (winner-active-region) (cdr entry)) part should be
> skipped?
We need to ban
(set-mark (car entry))
as well, because it updates the primary selection.
emacs -Q -eval '(winner-mode 1)' \
-eval "(customize-set-variable 'select-enable-clipboard nil)" \
-eval "(customize-set-variable 'select-enable-primary t)"
M-<
M-: (set-mark 15) RET
M-: C-y ; It inserts in minibuffer ";; This buffer"
I prefer this patch because:
1) Make the fix inside winner.el
2) The fix takes effect just if user has enabled select-enable-primary
I don't fully understand the purpose of that part of the code, but
I assume if someone have set select-enable-primary, then she
probably doesn't want winner-undo to change her selection.
next prev parent reply other threads:[~2017-10-14 1:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 8:02 bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Tino Calancha
2017-10-12 0:52 ` Tino Calancha
2017-10-12 2:06 ` Noam Postavsky
2017-10-12 2:53 ` Tino Calancha
2017-10-13 0:46 ` Noam Postavsky
2017-10-13 1:54 ` Tino Calancha
2017-10-13 6:48 ` Eli Zaretskii
2017-10-13 8:06 ` Tino Calancha
2017-10-13 13:32 ` Noam Postavsky
2017-10-14 1:42 ` Tino Calancha [this message]
2017-10-14 2:09 ` Noam Postavsky
2017-10-14 6:56 ` Eli Zaretskii
2017-10-17 7:25 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710141030010.31750@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=28631@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).