From: Tino Calancha <tino.calancha@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: 27952@debbugs.gnu.org, stefan monnier <monnier@iro.umontreal.ca>,
Tino Calancha <tino.calancha@gmail.com>
Subject: bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode
Date: Wed, 16 Aug 2017 22:10:17 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708162200590.23343@calancha-pc> (raw)
In-Reply-To: <mvmshgrsok5.fsf@suse.de>
On Wed, 16 Aug 2017, Andreas Schwab wrote:
> On Aug 16 2017, Tino Calancha <tino.calancha@gmail.com> wrote:
>
>> +Note: This is not the inverse of `file-modes-symbolic-to-number';
>> +The reason is that this function might return an string containing 'S'
>> +or 'T' i.e., not valid characters for `file-modes-symbolic-to-number'.
>> +For example, (file-modes-symbolic-to-number \"o=t\") returns 512;
>> +and (file-modes-number-to-symbolic 512 t) returns \"o=T\"."
>
> Why would it use uppercase T in the detailed case? Uppercase is only
> needed when it would overlay the 'x' position in the non-detailed case.
Not special reason i think. To keep more similar with
the case when DETAILED is nil.
(file-modes-number-to-symbolic 512)
=> "---------T"
At the end of the function that is changed into
"o=T"
with:
(funcall replace-fn
(replace-regexp-in-string
"-" "" ...
I liked like this when i wrote the patch. We could changed it in
case is confusing.
next prev parent reply other threads:[~2017-08-16 13:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 12:32 bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode Tino Calancha
2017-08-16 11:43 ` Tino Calancha
2017-08-16 12:00 ` npostavs
2017-08-16 13:13 ` Tino Calancha
2017-08-16 12:08 ` Andreas Schwab
2017-08-16 13:10 ` Tino Calancha [this message]
2019-06-24 20:35 ` Lars Ingebrigtsen
2019-06-24 20:42 ` Tino Calancha
2019-11-11 3:07 ` Stefan Kangas
2019-11-13 16:58 ` Tino Calancha
2020-05-04 11:55 ` Stefan Kangas
2020-05-08 19:53 ` Tino Calancha
2020-05-08 20:06 ` Stefan Monnier
2020-05-08 20:20 ` Tino Calancha
2020-05-14 16:47 ` Tino Calancha
2020-05-14 17:23 ` Eli Zaretskii
2020-05-14 20:08 ` Tino Calancha
2020-05-15 6:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708162200590.23343@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=27952@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).