From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name Date: Tue, 1 Aug 2017 23:06:01 +0900 (JST) Message-ID: References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1501596443 10243 195.159.176.226 (1 Aug 2017 14:07:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 14:07:23 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 27844@debbugs.gnu.org, Tino Calancha To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 01 16:07:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXpE-0001ve-5n for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 16:07:08 +0200 Original-Received: from localhost ([::1]:42731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXpK-000640-4W for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 10:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXpC-00062v-Jr for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 10:07:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcXp8-0001d0-5O for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 10:07:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcXp8-0001c9-16 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcXp7-0006Yz-KX for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2017 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27844-submit@debbugs.gnu.org id=B27844.150159637225169 (code B ref 27844); Tue, 01 Aug 2017 14:07:01 +0000 Original-Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 14:06:12 +0000 Original-Received: from localhost ([127.0.0.1]:37039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXoK-0006Xt-2B for submit@debbugs.gnu.org; Tue, 01 Aug 2017 10:06:12 -0400 Original-Received: from mail-pg0-f66.google.com ([74.125.83.66]:36950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXoI-0006Xb-Ah for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 10:06:10 -0400 Original-Received: by mail-pg0-f66.google.com with SMTP id 83so2859164pgb.4 for <27844@debbugs.gnu.org>; Tue, 01 Aug 2017 07:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=uNe1Gq6bvSZIrKr23J1P5uNLQF9LazUJgBsB4AnehLs=; b=vEJ3ADLkiPEoBq8UsAE3+OG6vwr3gw6L3QTVmCt90IIf++8BGSdz2xT1kCttIjcH2C mLe5uxMsbjrXKKIym/vMoNULjXUPnkYXWXI9NZk8PqTHubkSpTF44nJvQG5xdX7wfZ75 RZXTptS+jRAdkwmUSiEEQAR7tLQicDpl36n6AdlPV8OR22MQ+3IUvb3dkHgvbi8JL9OE sTveiov8DJlTiK/zJv5Hd0Y1SweRZfYHik6Q+oYU8a0Kwtrjtv6Ix4+5lCqH8m3BTi/c olb+uWlEVQ/jiWl3zYdlhgFUEPYiACbKeNpTYe9F6NOFHP9bGwASEV2BS8NEyYqGt0GW yjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=uNe1Gq6bvSZIrKr23J1P5uNLQF9LazUJgBsB4AnehLs=; b=B1VK4Tlzs+7WGe+DgdzJNlMPz5kftm7k8u1rOFTZQWVDFCp5rOhLyCQF69QvCwOk4q 02byfthFyl/EqxU8dkhle2PEHHfsEdt69Ye9xIjmFRdTVbuVK7A3xl/N2qS99RaaWA5D RZWiAFnAAupopvKKzVLozHLYdqAo0H+0V1wtrPYILTm0FCAhlbM6PO0M8dKikgzLKQRb 31sLLSfMiF2rodUcDcrtkHg07b1k3qvlMK7Xe3zQelRA9LzKS7H6CrShcL3kJhsuSeZX DMq0tjKdJ8Shg4cWg14yX9NL47XZn8oUECmqGAfbMvyBBOMD3QxzLIyJkQyMUFmCliS8 NNUw== X-Gm-Message-State: AIVw110EsvcP7XTT1KM36SvHbAC7sDy/ppthEnVjZEpT8LW+janG9yrN +n5Ei2tqiuTOlA== X-Received: by 10.84.217.74 with SMTP id e10mr7728524plj.410.1501596364559; Tue, 01 Aug 2017 07:06:04 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id f87sm54341610pfe.108.2017.08.01.07.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 07:06:03 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <8360e71k5p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135214 Archived-At: On Tue, 1 Aug 2017, Eli Zaretskii wrote: > I'm confused: I wasn't commenting on what eshell-extended-glob does, I > was commenting about your code: > > + (let ((matches (eshell-extended-glob file))) > + (if (consp matches) > + (mapcar #'file-relative-name matches) > + (user-error (format "%s: No files matching wildcard" file)))) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > If eshell-extended-glob already signals an error when it's TRT, why do > you need to signal an error if Eshell doesn't? What am I missing? I prefer to throw an error because looks familiar compared with what i see when using GNU/ls. If i try: C-x d ~/emacs-master/lisp/*.Z RET I) with GNU/ls or with ls-lisp: i get an error and i read in the echo area: Reading directory: No such file or directory, ~/emacs-master/lisp/*Z II) with eshell-ls: I actualy get a Dired buffer with an entry (the directory itself). I rather prefer if II) behaves as I) regardless on 'eshell-error-if-no-glob', that means, my second patch with the user-error.