From: Tino Calancha <tino.calancha@gmail.com>
To: Paul Rankin <hello@paulwrankin.com>
Cc: Tino Calancha <tino.calancha@gmail.com>, 27634@debbugs.gnu.org
Subject: bug#27634: 25.2.1; C-g does not quit register-read-with-preview
Date: Tue, 11 Jul 2017 14:50:21 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707111437450.16870@calancha-pc> (raw)
In-Reply-To: <3D7307DF-FB47-49FF-AEA9-67659E12821A@paulwrankin.com>
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
On Tue, 11 Jul 2017, Paul Rankin wrote:
>>>
>>> One overlooked thing about Tino's solution is that C-g is a keystroke and keyboard-quit is a function, which obviously aren't necessarily equivalent. What if the user remaps keyboard quit to "7"?
>> I thought about that, but i discarded because i think binding something
>> other that `keyboard-quit' to `C-g' is a misuse. The Emacs manual is full
>> of mentions to `C-g' as `keyboard-quit'.
>> There is even the following remark in the tips section:
>>
>> "don't bind a key sequence ending in @key{C-g}, since that
>> is commonly used to cancel a key sequence."
>>
>> If a user want to ignore such kind of advice he/she should
>> not expect everything will work the same.
>
> I'm gonna do this just to mess with you 😉
Thank you. Actually i feel quite boring now, so it's OK :-)
>> Maybe we can fix this so that `register-read-with-preview'
>> will work with `C-g' bound to `my-cool-foo-command'; but we
>> cannot assure that no other Emacs part is affected because such
>> misguided `C-g' binding. We must encourage users to follow
>> good practices.
>
>the point about C-g is more what if the user *also* binds keyboard-quit
>to "7". In this case the user expects 7 to call keyboard-quit, not just
>C-g.
I see. Good point!
Paul, what do you think about this?
--- a/lisp/register.el
+++ b/lisp/register.el
@@ -164,6 +164,9 @@ register-read-with-preview
help-chars)
(unless (get-buffer-window buffer)
(register-preview buffer 'show-empty)))
+ (when (and (characterp last-input-event)
+ (eq 'keyboard-quit (key-binding (string last-input-event))))
+ (keyboard-quit))
(if (characterp last-input-event) last-input-event
(error "Non-character input-event")))
I) Note, that my patch won't work in case our fearless user
bind "7" to ...:
(lambda () (message "What the hell are you doing?")
(keyboard-quit))
... But i don't think we must protect about things like I).
next prev parent reply other threads:[~2017-07-11 5:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 3:58 bug#27634: 25.2.1; C-g does not quit register-read-with-preview Paul Rankin
2017-07-10 6:33 ` Tino Calancha
2017-07-10 7:20 ` Paul Rankin
2017-07-10 7:59 ` Tino Calancha
2017-07-10 17:06 ` Eli Zaretskii
2017-07-11 4:14 ` Paul Rankin
2017-07-11 4:48 ` Tino Calancha
2017-07-11 5:07 ` Paul Rankin
2017-07-11 5:50 ` Tino Calancha [this message]
2017-07-11 7:20 ` Andreas Schwab
2017-07-11 14:36 ` Eli Zaretskii
2017-07-12 2:12 ` Paul Rankin
2017-07-10 19:01 ` Andreas Schwab
2017-07-21 3:47 ` Allen Li
2017-07-21 6:19 ` Tino Calancha
2017-07-21 8:40 ` Eli Zaretskii
2017-07-21 8:55 ` Tino Calancha
2017-07-25 2:45 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707111437450.16870@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=27634@debbugs.gnu.org \
--cc=hello@paulwrankin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).