From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el Date: Wed, 5 Jul 2017 22:29:02 +0900 (JST) Message-ID: References: <87zicmxdyl.fsf@lylat> <87o9t1c0vm.fsf@calancha-pc> <874luti81g.fsf@lylat> <87wp7oaj3l.fsf@calancha-pc> <87bmp0c794.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1499261418 19146 195.159.176.226 (5 Jul 2017 13:30:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Jul 2017 13:30:18 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 27559@debbugs.gnu.org, Tino Calancha To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 05 15:30:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSkNc-0004TC-0t for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 15:30:08 +0200 Original-Received: from localhost ([::1]:46231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSkNf-0003Tx-PG for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Jul 2017 09:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSkNZ-0003ST-Ss for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 09:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSkNW-0001N5-Oo for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 09:30:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSkNW-0001Mv-KG for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSkNW-0006kz-7q for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2017 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2017 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27559-submit@debbugs.gnu.org id=B27559.149926135525891 (code B ref 27559); Wed, 05 Jul 2017 13:30:02 +0000 Original-Received: (at 27559) by debbugs.gnu.org; 5 Jul 2017 13:29:15 +0000 Original-Received: from localhost ([127.0.0.1]:53095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSkMk-0006jX-PU for submit@debbugs.gnu.org; Wed, 05 Jul 2017 09:29:14 -0400 Original-Received: from mail-pg0-f51.google.com ([74.125.83.51]:34330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSkMi-0006jF-K8 for 27559@debbugs.gnu.org; Wed, 05 Jul 2017 09:29:12 -0400 Original-Received: by mail-pg0-f51.google.com with SMTP id t186so125044648pgb.1 for <27559@debbugs.gnu.org>; Wed, 05 Jul 2017 06:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=inVlcLLadZFk03shlWNBoyIzpOhaJJ5lDtX5Wb1Iczs=; b=ZYeiox+1sDuCBfyIn9S57HdrTr4n3o61v6ZMQpPACdn9ecgoWvlHY98xLhHrfFeVq9 /RYTWiWldJVRkpK1pj/uKoQ9ISdZtlzebQzQEzQOp9ALioxQOa/4UA9HoncrnJv0WbLS SCICl976qfVvYToHcnjwq2dG06fJKLQ8hDaqj7Capuo/RBiQSSVtcpJDHXrjBu7X4wCY +/4XGEKT2YPdtgZjlYSMlm+LDvrKieZ5T4KsoLj9AdRUxbhudPT+GMN9lxz7wqnjMqox jBDD/q9LnfsM6AMUVwOc1sD3evovVbx4Go7AabnboVUHE4ukbRzl9mU9gztPV0KnJmsJ 20vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=inVlcLLadZFk03shlWNBoyIzpOhaJJ5lDtX5Wb1Iczs=; b=Yurzk/izcDX+3EmEee37xy7ljdU652CctHAMeGiZ0kTiD7xrhYaq0iHK1wa5Sbek9D x2ui3Rcx3d9Tdpd6vtOEn1PMU2T+o0NmWbESg2wrq2+JqR8bn4Hcd9ehtXf1VJ0e12Ec x3Jx4LRm2b+iASB0VhzAhUon2ctbUF0oIrXZZkRWe/Ww4VSp0uzXdAR4pS3D/drOC1G+ Wvf4wnvymcTm7y7NWhmQl7jaEa67o41qv9WnflRRQZqJ02vEVBN5tMA1KGxpOcMUc1CJ 0Oh0aJns91yLSO+/D5XWvCic7dTKaZapsZFTsi1d8dmO43vzhvwWxcMgbdj6FDJgcg2B OOng== X-Gm-Message-State: AIVw1113vokD47IbgVtCDwwliBIZE4ubUwG6v/0SjbQ6qKKfwEtTC9Hy HEtmpYrlHiZfIQ== X-Received: by 10.99.95.147 with SMTP id t141mr20583032pgb.263.1499261346972; Wed, 05 Jul 2017 06:29:06 -0700 (PDT) Original-Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id o13sm54367321pfa.120.2017.07.05.06.29.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jul 2017 06:29:06 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87bmp0c794.fsf@lylat> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134204 Archived-At: On Tue, 4 Jul 2017, Alex wrote: > Tino Calancha writes: > >> Alex writes: >> >>> That's more or less what I did at first, but I figured since cl-loop is >>> a large macro, that it's best to quote the macro so that an accidental >>> error doesn't halt testing. >> I prefer just use (eval '...) in those cases where the expansion fails. >> That way the file is more readable, and a reader focus her eye in those >> failing expansions. > > I agree that it's more readable, and if I was doing this for my own > project I'd just leave the (eval '...) out where possible. > >> Maybe we could add a comment in the file saying that those >> `should-error' are failing expansions to be fixed. > > Part of the problem is that the "failing expansions that should be fixed" aren't > wrapped in a should-error, but are wrapped in a should. The test itself > is marked as ":expected-result :failed". Feel free to adapt the patch to your taste: in the way you find it more convenient. > I also have a patch that appears to do this, but it breaks a few tests > due to Bug#24402[1]. Perhaps a fix to that bug will also make it so that > macro-expansion errors will be caught be should*. > > I hope that Bug#24402 can be fixed before committing these tests, so we > can just remove the (eval '...) noise altogether. I agree with you. Thanks for point me out to such bug report (i wasn't aware of it). I will teletransport to that bug report. See you there!