bug#26084: closed (Re: bug#26084: 24.5; epatch save wrong backups in Git multipatches)

[Tino Calancha <tino.calancha@gmail.com>]

Thank you for fixing this.
From now on i will look on Hydra whenver i write a new test.

On Fri, 31 Mar 2017, Glenn Morris wrote:

>
> FYI, the test for this has been failing on hydra since it was added.
> Sadly Hydra is deleting build products very quickly at the moment,
> but I managed to catch the latest coverage evaluation while it was in
> progress. The not very informative failure message is:
>
> Running 2 tests (2017-03-31 22:21:13+0000)
>   passed  1/2  ediff-ptch-test-bug25010
> Test ediff-ptch-test-bug26084 backtrace:
>  (if (not (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq
>  (let (form-description-19) (if (not (unwind-protect (setq value-17 (
>  (let ((value-17 (quote ert-form-evaluation-aborted-18))) (let (form-
>  (let ((fn-15 (function string=)) (args-16 (list (let ((temp-buffer (
>  (while --dolist-tail-- (setq x (car --dolist-tail--)) (let ((fn-15 (
>  (let ((--dolist-tail-- (list qux bar)) x) (while --dolist-tail-- (se
>  (let* ((info (progn (ediff-map-patch-buffer (current-buffer)) ediff-
>  (unwind-protect (let* ((info (progn (ediff-map-patch-buffer (current
>  (let* ((tmpdir (make-temp-file "ediff-ptch-test" t)) (default-direct
>  (lambda nil (let ((fn-5 (function executable-find)) (args-6 (list "g
>  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
>  ert-run-test([cl-struct-ert-test ediff-ptch-test-bug26084 "Test for
>  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test e
>  ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\211@\20
>  ert-run-tests-batch(nil)
>  ert-run-tests-batch-and-exit(nil)
>  eval((ert-run-tests-batch-and-exit nil))
>  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/vc/ediff-ptch-tests.
>  command-line()
>  normal-top-level()
> Test ediff-ptch-test-bug26084 condition:
>    (ert-test-failed
>     ((should-not
>       (string=
> 	(with-temp-buffer ... ...)
> 	(with-temp-buffer ... ...)))
>      :form
>      (string= "foo here
> " "foo here
> ")
>      :value t))
>   FAILED  2/2  ediff-ptch-test-bug26084
>
> Ran 2 tests, 1 results as expected, 1 unexpected (2017-03-31 22:21:14+0000)
>
> 1 unexpected results:
>   FAILED  ediff-ptch-test-bug26084
>
> ERROR: lisp/vc/ediff-ptch-tests.log
>