From: Tino Calancha <tino.calancha@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25618@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests
Date: Sat, 4 Feb 2017 23:13:16 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1702042303170.26452@calancha-pc> (raw)
In-Reply-To: <CAM-tV-_KaxjcA5R=AvGSvb-E=aQWdVJuvRf6QOtSORJb2O6zvg@mail.gmail.com>
On Sat, 4 Feb 2017, Noam Postavsky wrote:
> On Sat, Feb 4, 2017 at 8:42 AM, Tino Calancha <tino.calancha@gmail.com> wrote:
>>
>> Prefer set a numeric limit of seconds than using the word 'few'.
>>
>> For instance, in my box the test `cl-seq-test-bug24264' in
>> test/lisp/emacs-lisp/cl-seq-tests.el
>> takes 7 s.
>> With an explicit numeric threshold is easier to decide whether this test
>> must be tagged as expensive or not.
>>
>> In following patch i define a few as 2-3 seconds. Other people might
>> prefer 4-5 or even higher.
>> Please, suggest a proper value to consider a test as expensive.
>
> Is it worth specifying this so precisely? The time elapsed depends on
> the speed of the computer you run it on (also, whether Emacs is
> compiled with optimization or not). A test that takes 2 seconds on
> your computer might easily take 5 seconds on mine.
When i run the test suite, the test mentioned before takes significantly
longer than the others. I feel like it could be considered as
slightly expensive.
After reading 'some few seconds' in CONTRIBUTE i am still in doubt on
that. It could be more clear.
next prev parent reply other threads:[~2017-02-04 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 13:42 bug#25618: 25.1.91; More precise limit for tagging expensive tests Tino Calancha
2017-02-04 14:01 ` Noam Postavsky
2017-02-04 14:13 ` Tino Calancha [this message]
2017-02-04 16:50 ` Eli Zaretskii
2017-02-04 17:54 ` Tino Calancha
2017-02-10 8:49 ` Eli Zaretskii
2017-02-10 9:28 ` Tino Calancha
2017-02-05 9:53 ` Michael Albinus
2017-02-05 13:53 ` Noam Postavsky
2017-02-05 15:35 ` bug#25618: AW: " michael.albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702042303170.26452@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=25618@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).