From: Tino Calancha <tino.calancha@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Tino Calancha <tino.calancha@gmail.com>,
npostavs@users.sourceforge.net, Mark Oteiza <mvoteiza@udel.edu>,
Stefan Monnier <monnier@iro.umontreal.ca>,
25105@debbugs.gnu.org, Dima Kogan <dima@secretsauce.net>
Subject: bug#25105: M-p in diff-mode jumps too far
Date: Wed, 18 Jan 2017 15:11:16 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1701181508090.1916@calancha-pc> (raw)
In-Reply-To: <9dba6552-cd54-c6f0-18de-6822d43b0944@yandex.ru>
On Wed, 18 Jan 2017, Dmitry Gutov wrote:
> On 16.01.2017 09:26, Tino Calancha wrote:
>
>> OK, below is my draft for the second commit.
>> Please don't hesitate to send me comments to make it more clear or/and
>> fix some broken grammar.
>
> Here's a fresh idea. If we're not going to worry about (not) showing Dima's
> commit message in the generated change log, maybe the new message should talk
> about tweaking the code, and not retell the original message.
>
> Or the users will read it twice, basically. But only those users that read
> change logs, of course.
OK, it's reasonable.
See my new draft for commit 0beb7d2968ab76878eb3be26f2d749977fdcaa2f
in branch scratch/calancha-revert-2c8a7e5:
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Make diff-apply-hunk independent of point within a diff header
Make diff-apply-hunk and diff-hunk-kill independent of the point
position in a diff header (Bug#17544).
This change allows to apply hunks in order. It also makes possible to
press M-k repeatedly to kill hunks in the order they appear in the buffer.
* lisp/vc/diff-mode.el (diff-file-junk-re):
Move definition before it's used.
(diff--at-diff-header-p): New predicate; return non-nil when point
is inside a hunk header, a file header, or within a line
matching diff-file-junk-re.
(diff-beginning-of-hunk): Use it.
Check if the point is inside a diff header, in the middle of a hunk,
or before the first hunk.
(diff-apply-hunk): Call diff-beginning-of-hunk with non-nil arg
before apply the hunk.
(diff-hunk-kill, diff-file-kill):
Call diff-beginning-of-hunk with non-nil arg after kill the hunks.
(diff-post-command-hook): Call diff-beginning-of-hunk with non-nil argument.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
next prev parent reply other threads:[~2017-01-18 6:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 21:21 bug#25400: M-p in diff-mode jumps too far Stefan Monnier
2017-01-08 23:27 ` Mark Oteiza
2017-01-09 4:34 ` Stefan Monnier
2017-01-11 4:38 ` bug#25105: " Tino Calancha
2017-01-11 23:27 ` Mark Oteiza
2017-01-11 23:34 ` Dmitry Gutov
2017-01-12 3:53 ` bug#25400: " Tino Calancha
2017-01-13 3:35 ` Dmitry Gutov
2017-01-13 3:55 ` Tino Calancha
2017-01-14 3:11 ` bug#25105: bug#25400: " Dmitry Gutov
2017-01-21 3:02 ` Tino Calancha
2017-01-23 3:42 ` bug#25105: " Dmitry Gutov
2017-01-13 4:25 ` Tino Calancha
2017-01-13 5:57 ` bug#25105: " npostavs
2017-01-13 6:26 ` Tino Calancha
2017-01-13 6:42 ` bug#25105: " npostavs
2017-01-13 6:54 ` Tino Calancha
2017-01-14 1:49 ` npostavs
2017-01-14 5:47 ` Tino Calancha
2017-01-16 6:26 ` Tino Calancha
2017-01-17 23:24 ` Dmitry Gutov
2017-01-18 6:11 ` Tino Calancha [this message]
2017-01-14 3:16 ` bug#25105: bug#25400: " Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701181508090.1916@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=25105@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=dima@secretsauce.net \
--cc=monnier@iro.umontreal.ca \
--cc=mvoteiza@udel.edu \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).