From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame Date: Fri, 23 Sep 2016 15:26:36 +0900 (JST) Message-ID: References: <83eg6froxn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1474612053 32603 195.159.176.226 (23 Sep 2016 06:27:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 06:27:33 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) To: 24086-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 08:27:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJx6-0006ST-55 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 08:27:16 +0200 Original-Received: from localhost ([::1]:41163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJx4-0003jN-B7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 02:27:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJwv-0003hv-AZ for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnJws-0001iW-3p for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJws-0001iO-0d for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnJwr-0003iy-TX for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:27:01 -0400 Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 06:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24086@debbugs.gnu.org, tino.calancha@gmail.com, tino.calancha@gmail.com Original-Received: via spool by 24086-done@debbugs.gnu.org id=D24086.147461200614290 (code D ref 24086); Fri, 23 Sep 2016 06:27:01 +0000 Original-Received: (at 24086-done) by debbugs.gnu.org; 23 Sep 2016 06:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:32972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJwc-0003iQ-0S for submit@debbugs.gnu.org; Fri, 23 Sep 2016 02:26:46 -0400 Original-Received: from mail-pf0-f169.google.com ([209.85.192.169]:36494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJwa-0003iB-9L for 24086-done@debbugs.gnu.org; Fri, 23 Sep 2016 02:26:44 -0400 Original-Received: by mail-pf0-f169.google.com with SMTP id q2so38656114pfj.3 for <24086-done@debbugs.gnu.org>; Thu, 22 Sep 2016 23:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:in-reply-to:message-id:references:user-agent :mime-version; bh=ap3+m/TCAnJ4WME1YfOeJ1t1MfvFvdhloefzLLNbePg=; b=yWgZv+aZDyQtzIawlq0kx5lwWx+7ziXsABMkF3413ID+JtXNmwp7cy9M+hHioXTwrI oo82Gv9RiFRwXDrBPK9CWA7e2np56ny6f2uGfGWYOkJrUN1r9VFg8dI66l+SX1UVH1HD oQmDn6pl1skS+cp1NIWYQOSEih09Rjhh6rUlhBXIqYL3Us91aIkpi2m6aMv52ijdviOV p2Y7XOZt8yqe+aKkv8AT1cC0/iNFee+OaelQl9vaiy4ox3kBrD4nqsyYAPDRpVKgpByC sAyNqOvIV/EsZij0/v4QaBicpWMnQu7LIW2NUfwN78/gptj8d1hn7IL+GIpQoQlKu4Wd Yi4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ap3+m/TCAnJ4WME1YfOeJ1t1MfvFvdhloefzLLNbePg=; b=XWJzttKnUVllWX5D5twypuU7p3NYjS+jJIc9LJlrIeKRl0uijD+pYlzR+vRZe6hf8w YkSKHCO4DaV7PN3gCBPycAnYagLPnXJtpLkfo+9lJSWc3mrjG2DkOpegHl/uSgoloqNu uLkfZ5xadqKIkW86bY8NE/5boPWC/915Su/LouhN7lVXYck16aAR64zzGLQIOtlKhQno mNTiKnkwrQgQMi5dc3t/s75UIBDDMSXfeM+ezFXAp6eloyophv5MFSwe6/kuiK2qRNKS XDS9Zrge3pGF1O9XLf+bdIgSf8v0OnHuw8U5aTeLcBfZTuQ2D3y8NLSVzddMD5+v1S/0 QG7w== X-Gm-Message-State: AE9vXwMef5nMbZy5aEvG8gWYm0IskzBj0fktE+291GlHx6Z1bKgZAJunkXplqWwiWiwt4w== X-Received: by 10.98.193.193 with SMTP id i184mr9795593pfg.69.1474611998668; Thu, 22 Sep 2016 23:26:38 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id fm6sm8315943pab.37.2016.09.22.23.26.37 for <24086-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 23:26:38 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123579 Archived-At: Fixed in master branch as commit: 87925f11 On Fri, 23 Sep 2016, Tino Calancha wrote: > On Wed, 14 Sep 2016, Tino Calancha wrote: > >> If there are no further objections i will push this patch to master in >> a few days. > > I have pushed to master the following much simple patch: > > > From 87925f1125acf95439e4563f9a30864cadf7cafb Mon Sep 17 00:00:00 2001 > From: Tino Calancha > Date: Fri, 23 Sep 2016 15:16:15 +0900 > Subject: [PATCH] ibuffer-do-view-other-frame: Display each buffer in a new > frame > > * lisp/ibuffer.el (ibuffer-do-view-1): > When TYPE equals 'other-frame, then display each buffer > in a new frame (Bug#24086). > --- > lisp/ibuffer.el | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el > index 0336f1d..e965535 100644 > --- a/lisp/ibuffer.el > +++ b/lisp/ibuffer.el > @@ -1143,17 +1143,17 @@ ibuffer-do-view-horizontally > (ibuffer-do-view-1 (if other-frame 'other-frame 'horizontally))) > > (defun ibuffer-do-view-1 (type) > - (let ((marked-bufs (ibuffer-get-marked-buffers))) > - (when (null marked-bufs) > - (setq marked-bufs (list (ibuffer-current-buffer t)))) > + (let ((marked-bufs (or (ibuffer-get-marked-buffers) > + (list (ibuffer-current-buffer t))))) > (unless (and (eq type 'other-frame) > (not ibuffer-expert) > (> (length marked-bufs) 3) > (not (y-or-n-p (format "Really create a new frame for %s > buffers? " > (length marked-bufs))))) > - (set-buffer-modified-p nil) > - (delete-other-windows) > - (switch-to-buffer (pop marked-bufs)) > + (unless (eq type 'other-frame) > + (set-buffer-modified-p nil) > + (delete-other-windows) > + (switch-to-buffer (pop marked-bufs))) > (let ((height (/ (1- (if (eq type 'horizontally) (frame-width) > (frame-height))) > (1+ (length marked-bufs))))) > -- > 2.9.3 > > > Repository revision: 0041ce81897ef837d04674b634720645379f3b18 >