From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame Date: Fri, 23 Sep 2016 15:24:17 +0900 (JST) Message-ID: References: <83eg6froxn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1474611926 7630 195.159.176.226 (23 Sep 2016 06:25:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 06:25:26 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 24086@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 08:25:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJv9-0000eB-CJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 08:25:15 +0200 Original-Received: from localhost ([::1]:41134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJv7-0003Co-Oj for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 02:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJuz-0003AV-Rr for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnJuw-0000eq-L5 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:25:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJuw-0000em-Hs for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnJuw-0003fl-D2 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24086-submit@debbugs.gnu.org id=B24086.147461186714072 (code B ref 24086); Fri, 23 Sep 2016 06:25:02 +0000 Original-Received: (at 24086) by debbugs.gnu.org; 23 Sep 2016 06:24:27 +0000 Original-Received: from localhost ([127.0.0.1]:32968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJuN-0003et-Kc for submit@debbugs.gnu.org; Fri, 23 Sep 2016 02:24:27 -0400 Original-Received: from mail-pf0-f181.google.com ([209.85.192.181]:36054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnJuL-0003ee-Ry for 24086@debbugs.gnu.org; Fri, 23 Sep 2016 02:24:26 -0400 Original-Received: by mail-pf0-f181.google.com with SMTP id q2so38634376pfj.3 for <24086@debbugs.gnu.org>; Thu, 22 Sep 2016 23:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+nfwAHXTqLEX7xGblG822Mx7T9UL4VKrMDi7ZSeCqDQ=; b=aZs4G4kpBrkQCot0tLnnAPxCB5fWwYsEMGfeQr8zHYhUyrgyXUf6xI4u+ZMu8mFMqp yqDq+Yz7PGaYpKZzfbI1v5Lli0zJPPQ76loa6uz+2prldP1yfEn+v7wgEL2UROjwyfd1 rn4Nca4aRw/xmUAocsWzE7nMtaJ20rjsqut799E6nMf+8ky4hTF4v59C0Mih40nCD3WK vGIMTjXhFPd4/A+IkIwT7thBA3N5nYIbVfZe4zRiYNzU73Lxh6L3N2IR3atNrJo+rDEn RA4TuuMUerPww8p0TbE/vwvagj2s521DPkuoLdgq1dgJu4fBIVCxIILLvjDv9d6/3Nqg 3aCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+nfwAHXTqLEX7xGblG822Mx7T9UL4VKrMDi7ZSeCqDQ=; b=LudCyKlWsEAI2VmUDMvdTkXXTHxz9oNsMbmOKad1DYIKY5fc5tRi1TbdrUbCl3Uiyy J7PmB8iwM7a6DexMEtbdC6VuFVWxWdA9lKpFr0yELO7RrbCnlN9GuZ7c9i5L2GSXtnUl y2IFHiP/TBjP1mFMdS9yzLxTfgwSGzzSg1l9kqVTpxYXKE5ul45GE5R5O+FBxOMqQzLx pu0T3DJcgolyNGJA+oZxTeljfVPbPXcexNr4iz4edMrVrM7Kdss3bY9TkdZ1VqpyVQ7q fdoa+9cPzJ46nTUAdmpBZ3kteFhCxTamBGSuzuu5/uNp9+NoMRvfQfoGTdCiAcY+GMCT SDcg== X-Gm-Message-State: AE9vXwMCtbQUOabbS85NLD4sQUznnNC12S30NHq8XFVbf0Tnyss/yAiz3GiqohCEID5SqQ== X-Received: by 10.98.223.218 with SMTP id d87mr10036071pfl.48.1474611860196; Thu, 22 Sep 2016 23:24:20 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id y1sm8259617pfd.90.2016.09.22.23.24.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 23:24:19 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123578 Archived-At: On Wed, 14 Sep 2016, Tino Calancha wrote: > If there are no further objections i will push this patch to master in > a few days. I have pushed to master the following much simple patch: >From 87925f1125acf95439e4563f9a30864cadf7cafb Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Fri, 23 Sep 2016 15:16:15 +0900 Subject: [PATCH] ibuffer-do-view-other-frame: Display each buffer in a new frame * lisp/ibuffer.el (ibuffer-do-view-1): When TYPE equals 'other-frame, then display each buffer in a new frame (Bug#24086). --- lisp/ibuffer.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 0336f1d..e965535 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -1143,17 +1143,17 @@ ibuffer-do-view-horizontally (ibuffer-do-view-1 (if other-frame 'other-frame 'horizontally))) (defun ibuffer-do-view-1 (type) - (let ((marked-bufs (ibuffer-get-marked-buffers))) - (when (null marked-bufs) - (setq marked-bufs (list (ibuffer-current-buffer t)))) + (let ((marked-bufs (or (ibuffer-get-marked-buffers) + (list (ibuffer-current-buffer t))))) (unless (and (eq type 'other-frame) (not ibuffer-expert) (> (length marked-bufs) 3) (not (y-or-n-p (format "Really create a new frame for %s buffers? " (length marked-bufs))))) - (set-buffer-modified-p nil) - (delete-other-windows) - (switch-to-buffer (pop marked-bufs)) + (unless (eq type 'other-frame) + (set-buffer-modified-p nil) + (delete-other-windows) + (switch-to-buffer (pop marked-bufs))) (let ((height (/ (1- (if (eq type 'horizontally) (frame-width) (frame-height))) (1+ (length marked-bufs))))) -- 2.9.3 Repository revision: 0041ce81897ef837d04674b634720645379f3b18