From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#23954: 25.1.50; Unexpected failing test Date: Thu, 21 Jul 2016 21:42:40 +0900 (JST) Message-ID: References: <07eg6xmpiq.fsf@fencepost.gnu.org> <560rz19nf.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1469105008 3658 80.91.229.3 (21 Jul 2016 12:43:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 12:43:28 +0000 (UTC) Cc: 23954@debbugs.gnu.org, Tino Calancha To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 14:43:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQDJs-0002u9-2r for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 14:43:16 +0200 Original-Received: from localhost ([::1]:40503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDJr-0002AH-6Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 08:43:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDJh-00028s-Sl for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQDJe-0004WP-Pd for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDJe-0004WL-M1 for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQDJe-0005xV-Go for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 08:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 12:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23954-submit@debbugs.gnu.org id=B23954.146910497422893 (code B ref 23954); Thu, 21 Jul 2016 12:43:02 +0000 Original-Received: (at 23954) by debbugs.gnu.org; 21 Jul 2016 12:42:54 +0000 Original-Received: from localhost ([127.0.0.1]:59359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQDJW-0005x9-Ii for submit@debbugs.gnu.org; Thu, 21 Jul 2016 08:42:54 -0400 Original-Received: from mail-pf0-f182.google.com ([209.85.192.182]:35594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQDJS-0005wv-R7 for 23954@debbugs.gnu.org; Thu, 21 Jul 2016 08:42:52 -0400 Original-Received: by mail-pf0-f182.google.com with SMTP id x72so30210338pfd.2 for <23954@debbugs.gnu.org>; Thu, 21 Jul 2016 05:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=PxCk/Gf+ueGkcaNcd+5QN9AGs7BqYe84BHk/o0+5IDc=; b=t7nG5SF1O3gNK6Y1ux1uF2hTKfPDsCWXR4fZ7L1x2Bj6KGneEciKojHlOaauFx2lO3 eYxi9WomBrBRKnxLYxwRje6/qPceV568i3pK7y5UNT1aNlg5EYb4V6pRuRO4o4l6kpPW WrP3s7yWZo1Ftf6rju7pAPpGR+PaFhcu+Dc4vTT7MhROO1MMCS3m7BDt3HpBNsH+977f 8qcEtquPYXq/4VEur1z2bKrvY3LBZby+p4XqNg4KuFDQy1FSr5dJjgJq1mEtwNFhpVeU Ayf8K1l44nGZeNl8B7CfYspLPj4reyVdGH37qasrbBQMV0GsPmPp0j3fmmFufsEjLg/h imog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=PxCk/Gf+ueGkcaNcd+5QN9AGs7BqYe84BHk/o0+5IDc=; b=U+k2vi5L64IkibTVldWAkDHGgb6SpyRaZtSoA4bUiivoikRskq+gNukNE3mcOLMmqJ b89Y3zVEmGuhEphYa5iLYLGdbTKjcj44oUayCvtEStGh2oVIX7VouQOz4DP6CTbWnM8i oXMo6HznmBIcbzonSuaYgXXIbwHtXJuMsslMv5PzlDSheREGpT61qcgcAw02QVWZbWrX uksKHf1aAXeinlpHhuQT0IXXCz7zUMbKpuJ6E3k1sncD8JMRsUwXOisIq5Inc0EDkiNR pJj/mIu/ni1WJc4q7GyT2Ix9R6rSk1DTwIRaAqgPRVmGx0Ts2DSHvLw6rAC4UtQi7HX6 nnfg== X-Gm-Message-State: ALyK8tKo0/EmrBf+z6KC8sgfxS+6BsdpYJqlEUugg7jnlTNCABiRorHL87dwsaxTEIJ7fQ== X-Received: by 10.98.93.25 with SMTP id r25mr72843886pfb.122.1469104965068; Thu, 21 Jul 2016 05:42:45 -0700 (PDT) Original-Received: from calancha-pc ([103.5.140.164]) by smtp.gmail.com with ESMTPSA id e187sm12189927pfg.43.2016.07.21.05.42.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 05:42:44 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <560rz19nf.fsf@fencepost.gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121375 Archived-At: On Thu, 21 Jul 2016, Glenn Morris wrote: > > It's bad to have persistently failing tests, because it can mask new failures. > (eg several xref tests started failing in > http://hydra.nixos.org/build/37558515, but there was no notification > email due to this pre-existing failure.) > > So please consider applying your change to fix this. Thanks for the replay. > I see it is similar to what turn-on-font-lock does, so if explicitly > turning on font-lock in this test also fixes it, that might be better. Yeah, for our purposes it is the same: set `char-property-alias-alist' to '((face font-lock-face)). I am going to apply following patch: diff --git a/test/lisp/erc/erc-track-tests.el b/test/lisp/erc/erc-track-tests.el index 24dfcfb..7cf3ef7 100644 --- a/test/lisp/erc/erc-track-tests.el +++ b/test/lisp/erc/erc-track-tests.el @@ -24,6 +24,7 @@ (require 'ert) (require 'erc-track) +(require 'font-core) (ert-deftest erc-track--shorten-aggressive-nil () "Test non-aggressive erc track buffer name shortening." @@ -107,9 +108,12 @@ (ert-deftest erc-track--erc-faces-in () "`erc-faces-in' should pick up both 'face and 'font-lock-face properties." (let ((str0 "is bold") - (str1 "is bold") - ;;(char-property-alias-alist '((face font-lock-face))) - ) + (str1 "is bold")) + ;; Turn on Font Lock mode: this initialize `char-property-alias-alist' + ;; to '((face font-lock-face)). Note that `font-lock-mode' don't + ;; turn on the mode if the test is run on batch mode or if the + ;; buffer name starts with ?\s (Bug#23954). + (unless font-lock-mode (font-lock-default-function 1)) (put-text-property 3 (length str0) 'font-lock-face '(bold erc-current-nick-face) str0) (put-text-property 3 (length str1) 'face