* bug#23954: 25.1.50; Unexpected failing test
@ 2016-07-12 15:34 Tino Calancha
2016-07-13 17:11 ` Glenn Morris
2016-07-21 12:59 ` bug#23954: (no subject) Tino Calancha
0 siblings, 2 replies; 6+ messages in thread
From: Tino Calancha @ 2016-07-12 15:34 UTC (permalink / raw)
To: 23954
The test 'erc-track--erc-faces-in' always fails but is not tagged
as failed.
While running the test 'char-property-alias-alist' is nil,
so that 'face cannot be translated to 'font-lock-face in the
call to 'erc-faces-in'.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From c1ebac5d441de3154d3f786d1fff54d6c3acf9f7 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Wed, 13 Jul 2016 00:26:04 +0900
Subject: [PATCH] Fix unexpected failing test
* test/lisp/erc/erc-track-tests.el (erc-track--erc-faces-in):
Initialize 'char-property-alias-alist' (Bug#xxxxxx).
---
test/lisp/erc/erc-track-tests.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/test/lisp/erc/erc-track-tests.el
b/test/lisp/erc/erc-track-tests.el
index 24dfcfb..641b307 100644
--- a/test/lisp/erc/erc-track-tests.el
+++ b/test/lisp/erc/erc-track-tests.el
@@ -108,8 +108,7 @@
"`erc-faces-in' should pick up both 'face and 'font-lock-face
properties."
(let ((str0 "is bold")
(str1 "is bold")
- ;;(char-property-alias-alist '((face font-lock-face)))
- )
+ (char-property-alias-alist '((face font-lock-face))))
(put-text-property 3 (length str0) 'font-lock-face
'(bold erc-current-nick-face) str0)
(put-text-property 3 (length str1) 'face
--
2.8.1
GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6)
of 2016-07-12
Repository revision: 5155144bd4cece3bab200a0eb613ffcdef523202
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#23954: 25.1.50; Unexpected failing test
2016-07-12 15:34 bug#23954: 25.1.50; Unexpected failing test Tino Calancha
@ 2016-07-13 17:11 ` Glenn Morris
2016-07-21 12:02 ` Glenn Morris
2016-07-21 12:37 ` Tino Calancha
2016-07-21 12:59 ` bug#23954: (no subject) Tino Calancha
1 sibling, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2016-07-13 17:11 UTC (permalink / raw)
To: Tino Calancha; +Cc: 23954
Tino Calancha wrote:
> The test 'erc-track--erc-faces-in' always fails but is not tagged
> as failed.
I don't know what you mean by "not tagged as failed".
It's been failing since 1efb20803.
http://hydra.nixos.org/build/37443517
http://lists.gnu.org/archive/html/emacs-buildstatus/2016-07/msg00009.html
> While running the test 'char-property-alias-alist' is nil,
> so that 'face cannot be translated to 'font-lock-face in the
> call to 'erc-faces-in'.
Yet somehow it seemed to work from compiled code...
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23954: 25.1.50; Unexpected failing test
2016-07-13 17:11 ` Glenn Morris
@ 2016-07-21 12:02 ` Glenn Morris
2016-07-21 12:42 ` Tino Calancha
2016-07-21 12:37 ` Tino Calancha
1 sibling, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2016-07-21 12:02 UTC (permalink / raw)
To: Tino Calancha; +Cc: 23954
It's bad to have persistently failing tests, because it can mask new failures.
(eg several xref tests started failing in
http://hydra.nixos.org/build/37558515, but there was no notification
email due to this pre-existing failure.)
So please consider applying your change to fix this.
I see it is similar to what turn-on-font-lock does, so if explicitly
turning on font-lock in this test also fixes it, that might be better.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23954: 25.1.50; Unexpected failing test
2016-07-21 12:02 ` Glenn Morris
@ 2016-07-21 12:42 ` Tino Calancha
0 siblings, 0 replies; 6+ messages in thread
From: Tino Calancha @ 2016-07-21 12:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23954, Tino Calancha
On Thu, 21 Jul 2016, Glenn Morris wrote:
>
> It's bad to have persistently failing tests, because it can mask new failures.
> (eg several xref tests started failing in
> http://hydra.nixos.org/build/37558515, but there was no notification
> email due to this pre-existing failure.)
>
> So please consider applying your change to fix this.
Thanks for the replay.
> I see it is similar to what turn-on-font-lock does, so if explicitly
> turning on font-lock in this test also fixes it, that might be better.
Yeah, for our purposes it is the same: set `char-property-alias-alist'
to '((face font-lock-face)).
I am going to apply following patch:
diff --git a/test/lisp/erc/erc-track-tests.el
b/test/lisp/erc/erc-track-tests.el
index 24dfcfb..7cf3ef7 100644
--- a/test/lisp/erc/erc-track-tests.el
+++ b/test/lisp/erc/erc-track-tests.el
@@ -24,6 +24,7 @@
(require 'ert)
(require 'erc-track)
+(require 'font-core)
(ert-deftest erc-track--shorten-aggressive-nil ()
"Test non-aggressive erc track buffer name shortening."
@@ -107,9 +108,12 @@
(ert-deftest erc-track--erc-faces-in ()
"`erc-faces-in' should pick up both 'face and 'font-lock-face
properties."
(let ((str0 "is bold")
- (str1 "is bold")
- ;;(char-property-alias-alist '((face font-lock-face)))
- )
+ (str1 "is bold"))
+ ;; Turn on Font Lock mode: this initialize
`char-property-alias-alist'
+ ;; to '((face font-lock-face)). Note that `font-lock-mode' don't
+ ;; turn on the mode if the test is run on batch mode or if the
+ ;; buffer name starts with ?\s (Bug#23954).
+ (unless font-lock-mode (font-lock-default-function 1))
(put-text-property 3 (length str0) 'font-lock-face
'(bold erc-current-nick-face) str0)
(put-text-property 3 (length str1) 'face
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#23954: 25.1.50; Unexpected failing test
2016-07-13 17:11 ` Glenn Morris
2016-07-21 12:02 ` Glenn Morris
@ 2016-07-21 12:37 ` Tino Calancha
1 sibling, 0 replies; 6+ messages in thread
From: Tino Calancha @ 2016-07-21 12:37 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23954, Tino Calancha
On Wed, 13 Jul 2016, Glenn Morris wrote:
> Tino Calancha wrote:
>
>> The test 'erc-track--erc-faces-in' always fails but is not tagged
>> as failed.
Sorry. I meant with that sentence that the test don't include
':expected-result :failed'
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23954: (no subject)
2016-07-12 15:34 bug#23954: 25.1.50; Unexpected failing test Tino Calancha
2016-07-13 17:11 ` Glenn Morris
@ 2016-07-21 12:59 ` Tino Calancha
1 sibling, 0 replies; 6+ messages in thread
From: Tino Calancha @ 2016-07-21 12:59 UTC (permalink / raw)
To: 23954-done
Fixed in master branch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-21 12:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-12 15:34 bug#23954: 25.1.50; Unexpected failing test Tino Calancha
2016-07-13 17:11 ` Glenn Morris
2016-07-21 12:02 ` Glenn Morris
2016-07-21 12:42 ` Tino Calancha
2016-07-21 12:37 ` Tino Calancha
2016-07-21 12:59 ` bug#23954: (no subject) Tino Calancha
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).