unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: 23936@debbugs.gnu.org
Subject: bug#23936: 25.1.50; shell-command shell-command-on-region doc fix
Date: Thu, 21 Jul 2016 17:48:36 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1607211740300.18492@calancha-pc> (raw)
In-Reply-To: <handler.23936.D23936.14681733126268.ackdone@debbugs.gnu.org>


There is another wrong sentence in the doc strings for 
shell-command[-on-region]

The output buffer is not deleted: the code killing that buffer was 
commented:

;; It is rude to delete a buffer which the command is not using.
;; Don't kill: there might be useful info in the undo-log.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 33e7bb2c459ffdf918ccbad4693c641d09349178 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Thu, 21 Jul 2016 17:35:17 +0900
Subject: [PATCH] Doc string fixes

* lisp/simple.el (shell-command, shell-command-on-region): These
commands never delete the buffer '*Shell-Command Output*'; update
their doc strings (Bug#23936).
---
  lisp/simple.el | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 51c9100..e91b6e0 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3288,9 +3288,6 @@ shell-command
  in the current buffer\", a message about the error goes at the end
  of the output.

-If there is no output, or if output is inserted in the current buffer,
-then `*Shell Command Output*' is deleted.
-
  If the optional third argument ERROR-BUFFER is non-nil, it is a buffer
  or buffer name to which to direct the command's standard error output.
  If it is nil, error output is mingled with regular output.
@@ -3535,9 +3532,7 @@ shell-command-on-region
  The output is available in that buffer in both cases.

  If there is output and an error, a message about the error
-appears at the end of the output.  If there is no output, or if
-output is inserted in the current buffer, the buffer `*Shell
-Command Output*' is deleted.
+appears at the end of the output.

  Optional fourth arg OUTPUT-BUFFER specifies where to put the
  command's output.  If the value is a buffer or buffer name,
-- 
2.8.1


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;





  parent reply	other threads:[~2016-07-21  8:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 16:41 bug#23936: 25.1.50; shell-command shell-command-on-region doc fix Tino Calancha
2016-07-10 17:22 ` Clément Pit--Claudel
2016-07-10 17:51 ` Tino Calancha
2016-07-10 17:55 ` bug#23936: (no subject) Tino Calancha
2016-07-10 17:59   ` Noam Postavsky
2016-07-10 18:09     ` Tino Calancha
     [not found] ` <handler.23936.D23936.14681733126268.ackdone@debbugs.gnu.org>
2016-07-21  8:48   ` Tino Calancha [this message]
2016-07-21  8:52 ` bug#23936: 25.1.50; shell-command shell-command-on-region doc fix Tino Calancha
2016-07-22  5:54 ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1607211740300.18492@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=23936@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).