From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc Date: Mon, 11 Jul 2016 02:31:52 +0900 (JST) Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <83poqle7nh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1468172004 18952 80.91.229.3 (10 Jul 2016 17:33:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2016 17:33:24 +0000 (UTC) Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com, Stefan Monnier , npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 10 19:33:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMIbR-0005we-TH for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 19:33:14 +0200 Original-Received: from localhost ([::1]:56145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMIbR-0000J2-2K for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 13:33:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMIbJ-0000Iu-Tg for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 13:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMIbG-0002Fg-OI for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 13:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMIbG-0002Fc-Ke for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMIbG-00015a-Fk for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2016 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23933-submit@debbugs.gnu.org id=B23933.14681719244120 (code B ref 23933); Sun, 10 Jul 2016 17:33:02 +0000 Original-Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:32:04 +0000 Original-Received: from localhost ([127.0.0.1]:45521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIaJ-00014O-VY for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:32:04 -0400 Original-Received: from mail-pf0-f175.google.com ([209.85.192.175]:33571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIaI-00013u-9m for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:32:02 -0400 Original-Received: by mail-pf0-f175.google.com with SMTP id i123so27921780pfg.0 for <23933@debbugs.gnu.org>; Sun, 10 Jul 2016 10:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2uKmMvsesJ1q7VuaUZxSZgbujUiDy1MAZCLlnhgNxnI=; b=jQYfdhKIaiD4TpHsf8lRV2sz0GARilQ4YDzoGwFq/MpWhZr2cqm8mTDye5dMrD+Nk9 IB5qONeATifhJ1RUdjLL4xRUEia5zlN4e7XdNmLnrl+S5g6Ms4cduOkmpME8cbH3Kt9Q 8Z5b8jNSFtNacQUGAgBrrdeDsz+qFsMCZfm5vSnHvMrHuyrVGDK9g1Gq1AUfXdSQI2xS mMubj6pVDaopz7Kho/8lnFm1tXw1tu2DpHhQzOPfPkLvykTlyImIBEj6OOSZJq4ZRoZY yTzA0cLByLw/eLJxfUA4TPjJjM9AEcwsykRqYk6KGv2JrRPa5EZvsOw9OOBgS7L3L3zg 5isw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2uKmMvsesJ1q7VuaUZxSZgbujUiDy1MAZCLlnhgNxnI=; b=D9JmZQG5HYqMM08dxUVxJ9uq7oxDcJ8WP70rCrGApMb/QiwkKPxtQVqGE3ihsoVJk8 psx4TCzvnbkocA788iRZ7d/OkvGhaHeUGvyspwAOyVCUElpyEbCTE8OCo3t7kuiF1d6b I17eLIRTbT5qrpULqU7cFqi2crBVyabCplxaZnAsQz/iCexQX6EjqYVGy/61xnImTCfh 5/Rw+cENXADCBHsS1mNbLpWyydDiQ/O+XFePAOuk7AfmmsbrgUdcIgZwNpoQeAyDLpbp ke8eD+dlJjAViLJ612tLV33Nq2O4OkJFjV7DXjQ0vRind8MYFbOkPAHqlXAsHtsSzJ2j 5LCA== X-Gm-Message-State: ALyK8tLOOotvzeMzpOuwFgq2C3cuS3lQuxR1SrPRmq1uVsvFyQ7KJLMw8qPai/6yeaZFvA== X-Received: by 10.98.65.2 with SMTP id o2mr27999027pfa.97.1468171916746; Sun, 10 Jul 2016 10:31:56 -0700 (PDT) Original-Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id o68sm3845571pfb.18.2016.07.10.10.31.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 10:31:56 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83poqle7nh.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120797 Archived-At: On Sun, 10 Jul 2016, Eli Zaretskii wrote: > Tino, can you figure out why t is there? Perhaps the solution is > simply to remove it? Just explained in previous e-mail by Noam. I have tried another approach: drop the let binding and call run-hooks over the actual hook, as follows: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a6b88d5..b50ac6d 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -2439,7 +2439,6 @@ ediff-really-quit ;; restore buffer mode line id's in buffer-A/B/C (let ((control-buffer ediff-control-buffer) (meta-buffer ediff-meta-buffer) - (after-quit-hook-internal ediff-after-quit-hook-internal) (session-number ediff-meta-session-number) ;; suitable working frame (warp-frame (if (and (ediff-window-display-p) (eq ediff-grab-mouse t)) @@ -2522,7 +2521,7 @@ ediff-really-quit (frame-selected-window warp-frame)) 2 1)) - (mapc #'funcall after-quit-hook-internal) + (run-hooks 'ediff-after-quit-hook-internal) )) ;; Returns frame under mouse, if this frame is not a minibuffer ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; but it doesn't work: the meta-buffer is not shown. I prefer my initial patch which behaves the same as before adding the lexical-binding. Tino