unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org,
	tino.calancha@gmail.com,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	npostavs@users.sourceforge.net
Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc
Date: Mon, 11 Jul 2016 02:31:52 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1607110223230.568@calancha-pc> (raw)
In-Reply-To: <83poqle7nh.fsf@gnu.org>



On Sun, 10 Jul 2016, Eli Zaretskii wrote:

> Tino, can you figure out why t is there?  Perhaps the solution is
> simply to remove it?
Just explained in previous e-mail by Noam.
I have tried another approach: drop the let binding
and call run-hooks over the actual hook, as follows:

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el
index a6b88d5..b50ac6d 100644
--- a/lisp/vc/ediff-util.el
+++ b/lisp/vc/ediff-util.el
@@ -2439,7 +2439,6 @@ ediff-really-quit
    ;; restore buffer mode line id's in buffer-A/B/C
    (let ((control-buffer ediff-control-buffer)
  	(meta-buffer ediff-meta-buffer)
-	(after-quit-hook-internal ediff-after-quit-hook-internal)
  	(session-number ediff-meta-session-number)
  	;; suitable working frame
  	(warp-frame (if (and (ediff-window-display-p) (eq ediff-grab-mouse 
t))
@@ -2522,7 +2521,7 @@ ediff-really-quit
  			    (frame-selected-window warp-frame))
  			  2 1))

-  (mapc #'funcall after-quit-hook-internal)
+  (run-hooks 'ediff-after-quit-hook-internal)
    ))

  ;; Returns frame under mouse, if this frame is not a minibuffer
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

but it doesn't work: the meta-buffer is not shown.
I prefer my initial patch which behaves the same as before
adding the lexical-binding.

Tino





  reply	other threads:[~2016-07-10 17:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 10:18 bug#23933: 25.1.50; Run a buffer-local hook with mapc Tino Calancha
2016-07-10 14:44 ` Eli Zaretskii
2016-07-10 15:18   ` Stefan Monnier
2016-07-10 15:55     ` Eli Zaretskii
2016-07-10 17:01       ` Stefan Monnier
2016-07-10 17:12         ` npostavs
2016-07-10 21:12           ` Stefan Monnier
2016-07-11 16:02             ` Tino Calancha
2016-07-11 16:05               ` Tino Calancha
2016-07-10 17:15         ` Eli Zaretskii
2016-07-10 17:31           ` Tino Calancha [this message]
2016-07-10 17:41             ` Noam Postavsky
2016-07-10 17:52             ` Eli Zaretskii
2016-07-10 18:14               ` Tino Calancha
2016-07-10 15:56     ` Eli Zaretskii
2016-07-10 17:02       ` Stefan Monnier
2016-07-10 18:28       ` Andreas Schwab
2016-07-11 16:06 ` bug#23933: (no subject) Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1607110223230.568@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=23933@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kifer@cs.stonybrook.edu \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).