From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vivek Dasmohapatra Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Thu, 18 Oct 2018 18:26:34 +0100 (BST) Message-ID: References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> <5BC05EEB.9010609@gmx.at> <5BC0E405.90805@gmx.at> <5BC1AAE2.7070808@gmx.at> <5BC4DB0E.3050501@gmx.at> <5BC6E4F2.2030607@gmx.at> <5BC83F03.4050006@gmx.at> <83o9brqs6e.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-901760997-1539883594=:19047" X-Trace: blaine.gmane.org 1539883513 15553 195.159.176.226 (18 Oct 2018 17:25:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 17:25:13 +0000 (UTC) User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) Cc: 22000@debbugs.gnu.org, deng@randomsample.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 18 19:25:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDC2m-0003vU-Cn for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 19:25:08 +0200 Original-Received: from localhost ([::1]:43567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDC4s-0001kN-KQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 13:27:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDC4f-0001iw-BK for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 13:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDC4c-00009X-0O for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 13:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDC4b-00008e-SZ for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 13:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDC4b-0007xN-KI for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vivek Dasmohapatra Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2018 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.153988359830552 (code B ref 22000); Thu, 18 Oct 2018 17:27:01 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 18 Oct 2018 17:26:38 +0000 Original-Received: from localhost ([127.0.0.1]:57338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDC4E-0007wi-0i for submit@debbugs.gnu.org; Thu, 18 Oct 2018 13:26:38 -0400 Original-Received: from ceres.etla.org ([85.119.82.193]:34005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDC4C-0007wa-3h for 22000@debbugs.gnu.org; Thu, 18 Oct 2018 13:26:36 -0400 Original-Received: from yaffle.pepperfish.net ([88.99.213.221] helo=[10.112.101.20]) by ceres.etla.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gDC4A-0006Ch-Hm; Thu, 18 Oct 2018 18:26:34 +0100 X-X-Sender: vivek@platypus.pepperfish.net In-Reply-To: <83o9brqs6e.fsf@gnu.org> X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam_report: Spam detection software, running on the system "ceres.etla.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> +(defcustom menu-bar-scrollbar-mode nil >> + "Specify how GTK menu bars deal with the frame being too narrow to hold them.\n >> +Valid values are: >> + `always' - the menu bar always has a scrollbar >> + `automatic' - a scrollbar is added when required >> + `forced-resize' - no scrollbar, the frame is forced to resize to accommodate >> + the menu bar. >> + nil (or any other value) - the menu bar is truncated\n >> +Note that prior to GTK 3.16 truncation is not possible and the default >> +is equivalent to 'forced-resize.\n > > Do you really need these X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151391 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-901760997-1539883594=:19047 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT >> +(defcustom menu-bar-scrollbar-mode nil >> + "Specify how GTK menu bars deal with the frame being too narrow to hold them.\n >> +Valid values are: >> + `always' - the menu bar always has a scrollbar >> + `automatic' - a scrollbar is added when required >> + `forced-resize' - no scrollbar, the frame is forced to resize to accommodate >> + the menu bar. >> + nil (or any other value) - the menu bar is truncated\n >> +Note that prior to GTK 3.16 truncation is not possible and the default >> +is equivalent to 'forced-resize.\n > > Do you really need these explicit \n newlines? I wouldn't say need but I find they make the documentation more readable, per item 3 in (elisp)Top > Tips > Documentation tips … D.6 Tips for… > More generally, shouldn't this mode have "gtk" somewhere in the name? > Or, if we hope to implement it for other toolkits at some future date, > the doc string should not say "GTK menu bars", it should say "menu > bars" and then have a note that this currently has effect only with > GTK menus. I prefer the second option, I will adjust the docstrings accordingly. >> +(defun menu-bar-showhide-menu-bar-scrollbar-mode-customize-nil () >> + "Truncate the menu bar to fit the frame." >> + (interactive) >> + (customize-set-variable 'menu-bar-scrollbar-mode 'default)) > > I think doc strings of these functions are too laconic for interactive > functions. AIUI they are interactive purely because that is a requirement for the way they are used by the menu infrastructure, not because they are intended to be used as commands with M-x or similar by the user. The other …-customize-… shim commands in that file are similarly laconically documented. However if the objection still stands, I will add more verbose docstrings. I will make the other changes suggested (to which I have not responded individually here). --8323329-901760997-1539883594=:19047--