From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vivek Dasmohapatra Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Mon, 16 Jul 2018 10:46:56 +0100 (BST) Message-ID: References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B4C4911.8040900@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1531734367 5586 195.159.176.226 (16 Jul 2018 09:46:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Jul 2018 09:46:07 +0000 (UTC) User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) Cc: 22000@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 16 11:46:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ff04w-0001LT-5s for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2018 11:46:02 +0200 Original-Received: from localhost ([::1]:50109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff073-0002TG-1t for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2018 05:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff06w-0002T9-T4 for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2018 05:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ff06s-0002Zz-1K for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2018 05:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ff06r-0002Zt-TQ for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2018 05:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ff06r-0004gN-ML for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2018 05:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vivek Dasmohapatra Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jul 2018 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.153173442217930 (code B ref 22000); Mon, 16 Jul 2018 09:48:01 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 16 Jul 2018 09:47:02 +0000 Original-Received: from localhost ([127.0.0.1]:42282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ff05u-0004f8-4M for submit@debbugs.gnu.org; Mon, 16 Jul 2018 05:47:02 -0400 Original-Received: from ceres.etla.org ([85.119.82.193]:43403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ff05r-0004eg-Rx for 22000@debbugs.gnu.org; Mon, 16 Jul 2018 05:47:00 -0400 Original-Received: from yaffle.pepperfish.net ([88.99.213.221] helo=[10.112.101.20]) by ceres.etla.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ff05q-0004EP-3B; Mon, 16 Jul 2018 10:46:58 +0100 X-X-Sender: vivek@platypus.pepperfish.net In-Reply-To: <5B4C4911.8040900@gmx.at> X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam_report: Spam detection software, running on the system "ceres.etla.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 16 Jul 2018, martin rudalics wrote: > Making the menu bar a "scrolled window" appears like a rather gross > hack to me and I think we should use it only as a last resort. Can > you tell what actually is different for a scrolled window in order to > not trigger auto-resizing of its parent? [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148561 Archived-At: On Mon, 16 Jul 2018, martin rudalics wrote: > Making the menu bar a "scrolled window" appears like a rather gross > hack to me and I think we should use it only as a last resort. Can > you tell what actually is different for a scrolled window in order to > not trigger auto-resizing of its parent? Literally what the scrolled window is for, from what I can tell: Make a widget that otherwise makes hard demands of its parent for space allocation into a scrollable one. > I wonder why 'gtk_widget_set_size_request' does not handle this > problem in the first place. In 'create_menus' we do > Is it possible that this gets reset later and/or another such call is > needed when adding a new menu bar item? After all, you can set a Yes, I've been digging through the code a bit and it looks like the menu bar recalculates everything when its contents change. In addition there's an idle callback which occasionally asks the menu bar what it thinks its size is. I was hoping to be able to figure out if this was controllable from user code by comparing with the tool bar, which does not seem to display this symptom, but no luck so far. >> It does make the menu bar taller than it was - This may be >> addressable by using overlay scrollbars but there is currently >> a bad focus interaction with those so the patch suppresses them >> (overlay scrollbars) for now. > > How much taller does the menu bar get? By the possible height of a > horizontal scroll bar? If you have overlay scrolling, no taller: If you don't, the height of a scrollbar plus whatever spacing is defined for the scrollable window by your gtk style (default: 3px). > Thank you for working on this problem, martin No problem, it's been annoying me for a few years now.