whitespace.el: auto-cleanup on kill prevents killing read-only buffers

whitespace.el: auto-cleanup on kill prevents killing read-only buffers

[Reuben Thomas]

I have whitespace-global-mode on and have it set to auto-cleanup on kill. 
This stops read-only buffers from being killed, as auto-cleanup tries to 
clean them up, gets an error, and aborts the kill.

The old whitespace mode used to check to see if it was being called in a 
read-only buffer, and didn't try to clean up under those circumstances.

I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists 
in CVS head.

-- 
http://rrt.sc3d.org/ | Floc: an egregiously good aperitif

bug#360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers

[Reuben Thomas]

On Fri, 2 May 2008, Reuben Thomas wrote:

> I have whitespace-global-mode on and have it set to auto-cleanup on kill. 
> This stops read-only buffers from being killed, as auto-cleanup tries to 
> clean them up, gets an error, and aborts the kill.
>
> The old whitespace mode used to check to see if it was being called in a 
> read-only buffer, and didn't try to clean up under those circumstances.
>
> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists 
> in CVS head.

This problem can be fixed by wrapping the body of whitespace-clean in 
(unless buffer-read-only). I don't know if that fix has problems, but it at 
least works for me.

-- 
http://rrt.sc3d.org/ | Matthew 5:37 <-- tri-state logic considered harmful

bug#360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers

[Stefan Monnier]

>> I have whitespace-global-mode on and have it set to auto-cleanup on
>> kill. This stops read-only buffers from being killed, as auto-cleanup
>> tries to clean them up, gets an error, and aborts the kill.
>> 
>> The old whitespace mode used to check to see if it was being called in
>> a read-only buffer, and didn't try to clean up under those circumstances.
>> 
>> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still
>> exists in CVS head.

> This problem can be fixed by wrapping the body of whitespace-clean in
> (unless buffer-read-only). I don't know if that fix has problems, but it at
> least works for me.

That would probably fix the problem, but now I wonder: why on earth
would someone worry about whitespace when killing a buffer?
Why would you want to strip whitespace just microseconds before throwing
away this piece of data anyway?


        Stefan

bug#360: marked as done (whitespace.el: auto-cleanup on kill prevents killing read-only buffers)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]


Your message dated Fri, 5 Sep 2008 23:15:37 -0400
with message-id <18625.62937.543118.985492@fencepost.gnu.org>
and subject line Re: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers
has caused the Emacs bug report #360,
regarding whitespace.el: auto-cleanup on kill prevents killing read-only buffers
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
360: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=360
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4126 bytes --]

From: Reuben Thomas <rrt@sc3d.org>
To: bug-emacs@gnu.org
Subject: Re: whitespace.el: auto-cleanup on kill prevents killing read-only buffers
Date: Wed, 4 Jun 2008 15:52:19 +0100 (BST)
Message-ID: <alpine.DEB.1.00.0806041551340.6727@canta>

On Fri, 2 May 2008, Reuben Thomas wrote:

> I have whitespace-global-mode on and have it set to auto-cleanup on kill. 
> This stops read-only buffers from being killed, as auto-cleanup tries to 
> clean them up, gets an error, and aborts the kill.
>
> The old whitespace mode used to check to see if it was being called in a 
> read-only buffer, and didn't try to clean up under those circumstances.
>
> I'm using Emacs 23.0.60.1, but as far as I can tell the problem still exists 
> in CVS head.

This problem can be fixed by wrapping the body of whitespace-clean in 
(unless buffer-read-only). I don't know if that fix has problems, but it at 
least works for me.

-- 
http://rrt.sc3d.org/ | Matthew 5:37 <-- tri-state logic considered harmful




[-- Attachment #3: Type: message/rfc822, Size: 1444 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 360-done@emacsbugs.donarmstrong.com
Subject: Re: #360: whitespace.el: auto-cleanup on kill prevents killing read-only buffers
Date: Fri, 5 Sep 2008 23:15:37 -0400
Message-ID: <18625.62937.543118.985492@fencepost.gnu.org>


2008-09-05  Vinicius Jose Latorre  <viniciusjl@ig.com.br>

        * whitespace.el: Fix auto-cleanup on kill prevents killing read-only
        buffers (bug#360).