unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 1261@emacsbugs.donarmstrong.com, Stephen Berman <stephen.berman@gmx.net>
Subject: bug#1261: 23.0.60; diary-insert-entry and mouse-autoselect-window
Date: Tue, 04 Nov 2008 13:51:27 -0500	[thread overview]
Message-ID: <aimygfs4sw.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <490FFB60.6030600@gmx.at> (martin rudalics's message of "Tue, 04 Nov 2008 08:36:00 +0100")

martin rudalics wrote:

> Would it help to check popup_activated, like
>
>                 if (WINDOWP (window)
> 		    && !popup_activated ()
> 		    && !EQ (window, last_window)
> 		    && !EQ (window, selected_window)
>
> in handle_one_xevent?

Not exactly like that, but with a tweak it seems to work (see below).
It feels a bit like covering up the real problem (gtk associating
popup with funny window), but I have no better solution; and indeed
one probably does not want to switch windows when popups are active.

I don't use mouse-autoselect-window, so Stephen please could you check
this works ok?

*** xterm.c	4 Nov 2008 16:47:34 -0000	1.1010
--- xterm.c	4 Nov 2008 18:49:39 -0000
***************
*** 6723,6729 ****
            {
  
              /* Generate SELECT_WINDOW_EVENTs when needed.  */
!             if (!NILP (Vmouse_autoselect_window))
                {
                  Lisp_Object window;
  
--- 6723,6729 ----
            {
  
              /* Generate SELECT_WINDOW_EVENTs when needed.  */
!             if (!NILP (Vmouse_autoselect_window) && !popup_activated ())
                {
                  Lisp_Object window;
  







  reply	other threads:[~2008-11-04 18:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 16:18 bug#1261: 23.0.60; diary-insert-entry and mouse-autoselect-window Stephen Berman
2008-10-27 17:25 ` martin rudalics
2008-10-27 20:42   ` Stephen Berman
2008-10-28  1:17     ` Stefan Monnier
2008-10-28  8:08     ` martin rudalics
2008-11-03 22:17       ` Glenn Morris
2008-11-04  7:36         ` martin rudalics
2008-11-04 18:51           ` Glenn Morris [this message]
2008-11-04 20:41             ` Stephen Berman
2008-10-27 21:34   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aimygfs4sw.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=1261@emacsbugs.donarmstrong.com \
    --cc=rudalics@gmx.at \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).