From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: 50704@debbugs.gnu.org
Subject: bug#50704: Feature request: Add ensure-list in cl-lib
Date: Mon, 20 Sep 2021 15:43:30 -0400 [thread overview]
Message-ID: <aff4b636-b66b-6e00-73e3-36437d4ce05a@gmail.com> (raw)
Hi all,
There are 40+ instances of the following code pattern in Emacs' code base, and many more in packages:
(if (listp x) x (list x))
It's easy to find single-line instances of it using the regexp [(]if [(]listp .*[(]list .
This pattern is called "ensure-list" in CL:
(defun ensure-list (thing)
"Returns THING as a list.
If THING is already a list (as per listp) it is returned,
otherwise a one element list containing THING is returned."
(if (listp thing)
thing
(list thing)))
I would like to add a similar function in Emacs, since it comes up so often. Is that an acceptable change?
If so:
- Which cl-*.el file should it go into, and where in that file?
- Should it be a defun or a define-inline?
- And once it is introduced, should the 40-some instances that could use it be updated, or left as-is?
- Finally, where should it be documented?
Cheers,
Clément.
next reply other threads:[~2021-09-20 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 19:43 Clément Pit-Claudel [this message]
2021-09-20 21:05 ` bug#50704: Feature request: Add ensure-list in cl-lib Lars Ingebrigtsen
2021-09-21 15:29 ` Stefan Kangas
2021-09-21 18:31 ` Lars Ingebrigtsen
2021-09-21 18:43 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aff4b636-b66b-6e00-73e3-36437d4ce05a@gmail.com \
--to=cpitclaudel@gmail.com \
--cc=50704@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).